From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D810EC4332F for ; Fri, 14 Oct 2022 07:55:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iyAz8UplLfJIA6CUYtpVYMV8qifWvxN15NVBbb7VYpQ=; b=Owb7YyFLICjbwS TRhb3Xha3PnewuarI82RbSVRLZcKpFdHBYFvSyqD0DCAfUji/7GUz31BZQ4iqOmWVHzW/3hHysSh8 /YXdjs4zh/aCJZ8eolx8tF//AUW12pFe+P+G96Yeq668RR6u4RN9M5nPZADzGctQJjV0wpRXpvFSQ 9AvXJGhSaxMWDLF9hz6+dekLZ79ECUIY0UER0U0Tr2hvpSpr8IuhUfMfTcsbn22MV7jp8URGzOhvt burb65zoUpc7H3PbSljRmjzKdS78wBZmvWrP3ORW8i90RdXqbkE9hPLrcptRPnSwsRNo0Jxi/oWgw IOaHXcQUPokHmG5ClIxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojFVq-00DyFd-PX; Fri, 14 Oct 2022 07:53:46 +0000 Received: from esa1.hgst.iphmx.com ([68.232.141.245]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojFVn-00DyE0-4g for linux-arm-kernel@lists.infradead.org; Fri, 14 Oct 2022 07:53:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1665734022; x=1697270022; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=e43rx5lrlAT5OV5I6ek/4TNY/F1pHFYbWzrhPY/2w98=; b=cag+e3g0f0n0rFhiWnpA/d0ZwsRcwoSHRRNhRSGa4HZKi0iFxziI8d0n YWRW+h7dEKKbI+wEyPzq7jW15ViPGMMLBsSp3r8ktZhZUp0NHNBf9KvPH LUFYg5E97Bq2ABhNYHwyyei6gkTzTyfg1r7GvZhBJFeaGgUHCBjpj97Uk owwPRyXZ/ivBPwZX0FgJzeC5BpkcaXuqLalXiMugX78mT8VFZkY96Uy5/ O+5YrBUSfh5U6LIQkJaXnr8qd0OHis4oZG4VL35U3LnqWqh8zLln5xini NW5t1iI7RCAvt/1MOPbedhYEKSVYueya+4r2LKfScHcLNda/iMIPRqleO Q==; X-IronPort-AV: E=Sophos;i="5.95,182,1661788800"; d="scan'208";a="325884673" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 14 Oct 2022 15:53:39 +0800 IronPort-SDR: /M2tf9DesKPef/QQVTvx7gBsYM15Uy1V5D0Udlj2u4sAv+A3kObbniJM8YS0dCjc0SxShiqO2k XkVn40uOjSDmM0va0iQhbwQkq0eBbJ1ae4D7Wu4L3IYw2fXTlyNePi6XYxG2jNkKZ2zOMaBr0B 2NGKD8Fc2558dqjXeVn/I/Q9lS3mtUvB4eP58lIH6rE0fQCC3rxYWtcdBOwOkY2XHaVKD8AkUY 22OkM0Gz7ICaxSQniaHxD21l1DtU6Ojc9sPrrDRi+dB6oCSb1FI123ld0F3pXjB19QmKkC0uzc n1DxhFa4hXtytAyFmp6spY9v Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Oct 2022 00:13:16 -0700 IronPort-SDR: 3ilMHArUMLGjL4QN6fpAySDEwTrT11cYy3dPwD3eWAc/nlQXkP9x0L30sixJHvAN1U6+21P1IG g5acOTkJ8IVYZj7JMYQEb0o7p9J4kvZgVrnwuLBSf/4kPqqrCy4CapZKVqGrQHGiRGLgGNSxer VJEMqj+F1aN8bJk2WzP8DlgS68QC7FqYYSfD+PVZk2ZMBlQhJMKpBPEA3aNCSEAnv1Cq8eqHWr XcnL7P8GrTEkB5hsEBudy0R18+sjv2RQNenp11+P0qIYU+RjKn6E2hyx3sAJEK0HcKFmFCCrWl wB8= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Oct 2022 00:53:39 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4MpdtW0k0bz1RvTp for ; Fri, 14 Oct 2022 00:53:38 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1665734017; x=1668326018; bh=e43rx5lrlAT5OV5I6ek/4TNY/F1pHFYbWzr hPY/2w98=; b=ZTiK/j8LiDrFrYQOd7HxyM5cMqE5uz+yNC4GEjFhtf2+wCIRQW6 zzNi6YjPUrTmFAoGxHiT4jQbNBKxjDG64kaUU/ksyjSxIO7f4MVMCGO+/WOzsqA6 LFLEBj06NRiV+pG7k5Yckl0OKagqyX/m/6PZ6edAwbZa/CRrNDZC+b6iJ6CW/Abz TZZNzOTY9ONH3vdKHFPSLuu1CwTD5wcLdyS2mGBU+vxjf2DwBRQY7N4vd6FeDHTg GadKmMeCIfeDUs2fV2M4hqvMA3d8M6/iT6Y7UAcmdgSo7lUvu5My/A1bPCjzcSuv IbOMvnoqXn1pXr5US+zL3mNqu5ElzjBTAJQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Kuzxgj7pPxzB for ; Fri, 14 Oct 2022 00:53:37 -0700 (PDT) Received: from [10.225.163.119] (unknown [10.225.163.119]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4MpdtS2PLzz1RvLy; Fri, 14 Oct 2022 00:53:36 -0700 (PDT) Message-ID: <75eaeab3-7781-d60a-ae61-ae837f5dcec9@opensource.wdc.com> Date: Fri, 14 Oct 2022 16:53:34 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: TI: X15 the connected SSD is not detected on Linux next 20221006 tag Content-Language: en-US To: Arnd Bergmann , Anders Roxell , Naresh Kamboju , Sergey.Semin@baikalelectronics.ru Cc: open list , Linux ARM , regressions@lists.linux.dev, "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , lkft-triage@lists.linaro.org, Lukas Bulwahn , Niklas Cassel References: <7ee4a1bd-0674-42d8-8980-8b029ca09e71@app.fastmail.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <7ee4a1bd-0674-42d8-8980-8b029ca09e71@app.fastmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221014_005343_298495_EC1B5358 X-CRM114-Status: GOOD ( 36.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/14/22 16:31, Arnd Bergmann wrote: > On Fri, Oct 14, 2022, at 2:22 AM, Damien Le Moal wrote: >> On 10/14/22 07:07, Anders Roxell wrote: >> [...] >>>> 8) >>>>> If reverting these patches restores the eSATA port on this board, then you need >>>>> to fix the defconfig for that board. >>>> >>>> OTOH, >>>> Anders, enabled the new config CONFIG_AHCI_DWC=y and tried but the >>>> device failed to boot. >>> >>> I thought it would work with enabling CONFIG_AHCI_DWC=y, but it didn't... >> >> As mentioned in my previous reply to Naresh, this is a new driver added in >> 6.1. Your board was working before so this should not be the driver needed >> for it. >> >>> However, reverting patch 33629d35090f ("ata: ahci: Add DWC AHCI SATA >>> controller support") >>> from next-20221013 was a success, kernel booted and the 'mkfs.ext4' cmd was >>> successful. >> >> Which is very strange... There is only one hunk in that commit that could >> be considered suspicious: >> >> diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c >> index 9b56490ecbc3..8f5572a9f8f1 100644 >> --- a/drivers/ata/ahci_platform.c >> +++ b/drivers/ata/ahci_platform.c >> @@ -80,9 +80,7 @@ static SIMPLE_DEV_PM_OPS(ahci_pm_ops, ahci_platform_suspend, >> static const struct of_device_id ahci_of_match[] = { >> { .compatible = "generic-ahci", }, >> /* Keep the following compatibles for device tree compatibility */ >> - { .compatible = "snps,spear-ahci", }, >> { .compatible = "ibm,476gtr-ahci", }, >> - { .compatible = "snps,dwc-ahci", }, >> { .compatible = "hisilicon,hisi-ahci", }, >> { .compatible = "cavium,octeon-7130-ahci", }, >> { /* sentinel */ } >> >> Is your board using one of these compatible string ? > > The x15 uses "snps,dwc-ahci". I would expect it to detect the device > with the new driver if that is loaded, but it's possible that the > driver does not work on all versions of the dwc-ahci hardware. > > Anders, can you provide the boot log from a boot with the new driver > built in? There should be some messages from dwc-ahci about finding > the device, but then not ultimately working. > > Depending on which way it goes wrong, the safest fallback for 6.1 is > probably to move the "snps,spear-ahci" and "snps,dwc-ahci" compatible > strings back into the old driver, and leave the new one only for > the "baikal,bt1-ahci" implementation of it, until it has been > successfully verified on TI am5/dra7, spear13xx and exynos. OK. So a fix patch until further tests/debug is completed would be this: diff --git a/drivers/ata/ahci_dwc.c b/drivers/ata/ahci_dwc.c index 8fb66860db31..7a0cbab00843 100644 --- a/drivers/ata/ahci_dwc.c +++ b/drivers/ata/ahci_dwc.c @@ -469,8 +469,6 @@ static struct ahci_dwc_plat_data ahci_bt1_plat = { }; static const struct of_device_id ahci_dwc_of_match[] = { - { .compatible = "snps,dwc-ahci", &ahci_dwc_plat }, - { .compatible = "snps,spear-ahci", &ahci_dwc_plat }, { .compatible = "baikal,bt1-ahci", &ahci_bt1_plat }, {}, }; diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c index 8f5572a9f8f1..9b56490ecbc3 100644 --- a/drivers/ata/ahci_platform.c +++ b/drivers/ata/ahci_platform.c @@ -80,7 +80,9 @@ static SIMPLE_DEV_PM_OPS(ahci_pm_ops, ahci_platform_suspend, static const struct of_device_id ahci_of_match[] = { { .compatible = "generic-ahci", }, /* Keep the following compatibles for device tree compatibility */ + { .compatible = "snps,spear-ahci", }, { .compatible = "ibm,476gtr-ahci", }, + { .compatible = "snps,dwc-ahci", }, { .compatible = "hisilicon,hisi-ahci", }, { .compatible = "cavium,octeon-7130-ahci", }, { /* sentinel */ } Anders, Naresh, Can you try this ? -- Damien Le Moal Western Digital Research _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel