From: Markus Elfring <Markus.Elfring@web.de>
To: "Hui-Ping Chen" <hpchen0nvt@gmail.com>,
linux-mtd@lists.infradead.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org,
linux-arm-kernel@lists.infradead.org,
"Christian König" <christian.koenig@amd.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Esben Haabendal" <esben@geanix.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Rob Herring" <robh@kernel.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Vignesh Raghavendra" <vigneshr@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC
Date: Thu, 29 Aug 2024 07:10:06 +0200 [thread overview]
Message-ID: <75ffe2db-a5d5-471b-9e8b-53b98e75368e@web.de> (raw)
In-Reply-To: <20240821071132.281018-3-hpchen0nvt@gmail.com>
> Nuvoton MA35 SoCs NAND Flash Interface Controller
> supports 2KB, 4KB and 8KB page size, and up to 8-bit,
> 12-bit, and 24-bit hardware ECC calculation circuit
> to protect data communication.
You may occasionally put more than 53 characters into text lines
of such a change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc5#n45
…
> +++ b/drivers/mtd/nand/raw/nuvoton_ma35d1_nand.c
> @@ -0,0 +1,1068 @@
…
> +static irqreturn_t ma35_nand_irq(int irq, void *id)
> +{
…
> + u32 isr;
> +
> + spin_lock(&nand->dma_lock);
…
> + spin_unlock(&nand->dma_lock);
> +
> + return IRQ_HANDLED;
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(spinlock)(&nand->dma_lock);”?
https://elixir.bootlin.com/linux/v6.11-rc5/source/include/linux/spinlock.h#L559
Regards,
Markus
prev parent reply other threads:[~2024-08-29 5:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 7:11 [PATCH v3 0/2] Add support for nuvoton ma35 nand controller Hui-Ping Chen
2024-08-21 7:11 ` [PATCH v3 1/2] dt-bindings: mtd: nuvoton,ma35d1-nand: add new bindings Hui-Ping Chen
2024-08-23 16:26 ` Miquel Raynal
2024-08-28 2:47 ` Hui-Ping Chen
2024-08-28 7:48 ` Miquel Raynal
2024-08-28 7:57 ` Hui-Ping Chen
2024-08-21 7:11 ` [PATCH v3 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC Hui-Ping Chen
2024-08-23 17:02 ` Miquel Raynal
2024-08-29 2:57 ` Hui-Ping Chen
2024-08-29 5:10 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75ffe2db-a5d5-471b-9e8b-53b98e75368e@web.de \
--to=markus.elfring@web.de \
--cc=christian.koenig@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=esben@geanix.com \
--cc=hpchen0nvt@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).