From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25993CA9EB5 for ; Mon, 4 Nov 2019 14:14:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E520021D7D for ; Mon, 4 Nov 2019 14:14:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="spz2E76e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E520021D7D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Uw6ET2F7VAuZ1g4lhBkkO1hRUrOuklKehbx2Yy5q5jA=; b=spz2E76eEZnkD+ Q8e/RUWBMHAhCihqyxBGYHEiFU+dpGHSRfE+BhkY7AwvyfLWIU6lQTuw44woEgkbyPX4ABoQkR/2d gDPhzhyqlmNImlKBGnoN7aR2iIG8JYC1ZhdhOFVgdGHfmdhFr7aIzD109C00Uxul55laYa+6Rkx1q CS5vU8Ic653B7wUxAylTe1hjqIu3lfbgtdLg/0YchzqRic2N+aZ9//+B+GqesrYSjXOgr1xqJ0dLA Sxr5f6uHpM4WjFBB3/t5Q7PPV83rxnVeAfgRNTkmnfwACDpEjS0sRMgX6zUtl3Nl70HZPJKQ3tDgS 5L8M8a9X5sXOjEFvdvHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRd7v-00031H-KA; Mon, 04 Nov 2019 14:14:39 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRd7s-00030F-Cc; Mon, 04 Nov 2019 14:14:37 +0000 Received: from ip5f5a6266.dynamic.kabel-deutschland.de ([95.90.98.102] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iRd7j-0001gt-I1; Mon, 04 Nov 2019 15:14:27 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Markus Reichl Subject: Re: [PATCH v2] arm64: dts: rockchip: Split rk3399-roc-pc for with and without mezzanine board. Date: Mon, 04 Nov 2019 15:14:26 +0100 Message-ID: <7600269.ktiZa05prH@diego> In-Reply-To: <17c7c736-46a2-fee6-9bf3-f351a7871e20@fivetechno.de> References: <17c7c736-46a2-fee6-9bf3-f351a7871e20@fivetechno.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191104_061436_580625_AA4D1A94 X-CRM114-Status: GOOD ( 14.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Jagan Teki , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Markus, Am Montag, 4. November 2019, 15:08:55 CET schrieb Markus Reichl: > For rk3399-roc-pc is a mezzanine board available that carries M.2 and > POE interfaces. Use it with a separate dts. > > Signed-off-by: Markus Reichl > --- > v2: Add new compatible string for roc-pc with mezzanine board. > --- > .../devicetree/bindings/arm/rockchip.yaml | 7 +- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../boot/dts/rockchip/rk3399-roc-pc-mezz.dts | 72 ++ > .../arm64/boot/dts/rockchip/rk3399-roc-pc.dts | 757 +---------------- > .../boot/dts/rockchip/rk3399-roc-pc.dtsi | 770 ++++++++++++++++++ > 5 files changed, 850 insertions(+), 757 deletions(-) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezz.dts > create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index bf86e8237363..e46af071a5fe 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -87,11 +87,16 @@ properties: > - const: firefly,roc-rk3328-cc > - const: rockchip,rk3328 > > - - description: Firefly ROC-RK3399-PC > + - description: Firefly ROC-RK3399-PC standalone > items: > - const: firefly,roc-rk3399-pc > - const: rockchip,rk3399 > > + - description: Firefly ROC-RK3399-PC with mezzanine > + items: > + - const: firefly,roc-rk3399-pc-mezz > + - const: rockchip,rk3399 > + Please do this similar to like the NanoPC boards, so like - description: Firefly ROC-RK3399-PC items: - enum: - firefly,roc-rk3399-pc - firefly,roc-rk3399-pc-mezzanine - const: rockchip,rk3399 including using the full name (-mezzanine) here and in the actual dts filename+compatible. Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel