From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37361C3DA4A for ; Mon, 29 Jul 2024 16:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WrkxJ/NqKc2VEyAF8b52mcYznuMgiU4byXEXWWcOhOc=; b=aoOT+/mQIeGrI15NfH6ViMeTtR aPY/eEdWLDbLygt8sT+HKlWtqmSQWrRB05lc+wgLVS8Ctpc3JOQzmJHRQVW3M6FZnppAhq16F4Baz E+mNG27/ZF2IVfIwjT1Q1bRxN2AAdcXlk/aaYN+B8XNE05iMRlZZfoifA5p5RiIFBbLZT0hBII86u wcekVRsH3hRje6Bg15VqlUdBoa5Zw21gTjgZFEOYZNIcDCGDPks9kvU44gOW1emlOMDJ7rvH5kTfG wUefiB968Be07M9gYSbk//SIFw9uEiyuIjlKs+7ssUxaHQTMJ+Ijqn86mIZy3GI3XNgeJv/rAvciv PM0mjJOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYTN3-0000000C4Wl-38XB; Mon, 29 Jul 2024 16:37:13 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYTMc-0000000C4SC-2YZB for linux-arm-kernel@lists.infradead.org; Mon, 29 Jul 2024 16:36:47 +0000 Received: from [10.137.186.190] (unknown [131.107.159.62]) by linux.microsoft.com (Postfix) with ESMTPSA id D122D20B7165; Mon, 29 Jul 2024 09:36:44 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D122D20B7165 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1722271005; bh=WrkxJ/NqKc2VEyAF8b52mcYznuMgiU4byXEXWWcOhOc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nsJm1e/KRyqRI4KRwRC5npLsTK5ouUAlmotGladZc0kwCWohhpYjm1mcRiztpLPUr mU2AXMimOqtwKlmDCgp+26OOZ1P2QPH49nn7KtQN7O5sL1aY9I+Kgf1B6IeY+nqKu4 vubO5pHW20Dep6J5qbEzYd8a5s7P4s8U9AM7VjqA= Message-ID: <76099a4c-c276-403b-89d5-fd72516e01d3@linux.microsoft.com> Date: Mon, 29 Jul 2024 09:36:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/7] Drivers: hv: vmbus: Get the IRQ number from DT To: Krzysztof Kozlowski , arnd@arndb.de, bhelgaas@google.com, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, decui@microsoft.com, haiyangz@microsoft.com, hpa@zytor.com, kw@linux.com, kys@microsoft.com, lenb@kernel.org, lpieralisi@kernel.org, mingo@redhat.com, rafael@kernel.org, robh@kernel.org, tglx@linutronix.de, wei.liu@kernel.org, will@kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Cc: apais@microsoft.com, benhill@microsoft.com, ssengar@microsoft.com, sunilmut@microsoft.com, vdso@hexbites.dev References: <20240726225910.1912537-1-romank@linux.microsoft.com> <20240726225910.1912537-7-romank@linux.microsoft.com> <7418bfcd-c572-4574-accc-7f2ae117529f@kernel.org> Content-Language: en-US From: Roman Kisel In-Reply-To: <7418bfcd-c572-4574-accc-7f2ae117529f@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240729_093646_761734_29CDCE41 X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/27/2024 1:56 AM, Krzysztof Kozlowski wrote: > On 27/07/2024 00:59, Roman Kisel wrote: >> @@ -2338,6 +2372,21 @@ static int vmbus_device_add(struct platform_device *pdev) >> cur_res = &res->sibling; >> } >> >> + /* >> + * Hyper-V always assumes DMA cache coherency, and the DMA subsystem >> + * might default to 'not coherent' on some architectures. >> + * Avoid high-cost cache coherency maintenance done by the CPU. >> + */ >> +#if defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_DEVICE) || \ >> + defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU) || \ >> + defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL) >> + >> + if (!of_property_read_bool(np, "dma-coherent")) >> + pr_warn("Assuming cache coherent DMA transactions, no 'dma-coherent' node supplied\n"); > > Why do you need this property at all, if it is allways dma-coherent? Are > you supporting dma-noncoherent somewhere? No support for non-coherent. Wanted to do a sanity check. Had better check for dma-noncoherent and warn about that I believe. > > Best regards, > Krzysztof > -- Thank you, Roman