Re: [PATCH v5 4/4] arm64: dts: rockchip: Enable CAN controller on RK3588-Tiger-Haikou

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Cunhao Lu,

On 7/25/26 9:03 AM, Cunhao Lu wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
> 
> CAN0 is piped through the Q7-connector to the CAN-Header on the Haikou
> base-board, so enable support for it there.
> 
> At least on RK3588-Tiger, the CAN clocks default to 99MHz, limiting
> usable CAN bitrates without skew. Errata documentation mentions
> 300MHz as the default frequency on RK3568, so replicate this here
> to allow more bitrates.
> 

Can you please move the assigned-clocks* properties to rk3588-tiger.dtsi 
instead? RK3588 Tiger is a SOM and Haikou is a carrierboard. The 
carrierboard takes the signal directly from the SoC and route those to a 
transceiver. I'm assuming all carrierboards for Tiger will need those 
two properties, so better have them in the SoM DTSI.

Just apply:

"""
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts 
b/arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts
index 6273e695b0394..6c57c9f54a305 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts
@@ -156,8 +156,6 @@ vddd_audio_1v6: regulator-vddd-audio-1v6 {
  };

  &can0 {
-	assigned-clocks = <&cru CLK_CAN0>;
-	assigned-clock-rates = <300000000>;
  	status = "okay";
  };

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi 
b/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi
index 139f70e7bbd90..161c89c62bcda 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi
@@ -90,6 +90,11 @@ vcc5v0_sys: regulator-vcc5v0-sys {
  	};
  };

+&can0 {
+	assigned-clocks = <&cru CLK_CAN0>;
+	assigned-clock-rates = <300000000>;
+};
+
  &cpu_b0 {
  	cpu-supply = <&vdd_cpu_big0_s0>;
  };
"""

on top of this patch and squash and we'll have what I would like to have.

If there's no need for a v6, I'm assuming Heiko can simply fix that when 
applying and thus there may be no need to send a v6 just for that (but 
if you need to send a v6, please consider doing the suggested changes 
above).

Thanks!
Quentin