From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CE29C54E41 for ; Tue, 5 Mar 2024 14:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gqBC/FnLK/3lsu7kxnnLCEBGWh26gKtCQOND/zVU3jM=; b=Wk5jj1P20/KWEC Gaw5HDrWjrc1RVSDDsz9daMSCsRxLp5w65WhgMQibMmWqBaHhJ44H0zX1Vlf5EMNiNctWUnYFekW3 W77kvgzgGTLL4WYlyw2v75J9BzKmPGhGtRAHo8REkImiqESmHdM0ouTNMS+mK5BGoSG/c4izi8gcv g4EfAHSCt9hbb2nrvI64upmdZXOmSgbjcmFHSZ597/WA9W+Q0R/qa0HKXi3RCpaPkVWrCEsQqfzyy gEx7oPfInkLN47TtqjlJmTBxeJ7qzVxlA8L9lUAFBTh1+CU+LzBaPP/QJJRJAW9sbBb9fDYcUGHRn Zh1j6AkRWBU7laglMsOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhVWB-0000000DxpB-3s5R; Tue, 05 Mar 2024 14:11:43 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhVW9-0000000Dxno-17Da; Tue, 05 Mar 2024 14:11:42 +0000 Received: from i53875a9e.versanet.de ([83.135.90.158] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhVVj-0006jN-HS; Tue, 05 Mar 2024 15:11:15 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, jose.abreu@synopsys.com, nelson.costa@synopsys.com, dmitry.osipenko@collabora.com, sebastian.reichel@collabora.com, shawn.wen@rock-chips.com, nicolas.dufresne@collabora.com, hverkuil@xs4all.nl, hverkuil-cisco@xs4all.nl, Shreeya Patel Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm@lists.infradead.org, Shreeya Patel Subject: Re: [PATCH v2 4/6] arm64: dts: rockchip: Add device tree support for HDMI RX Controller Date: Tue, 05 Mar 2024 15:11:14 +0100 Message-ID: <7657358.31r3eYUQgx@diego> In-Reply-To: <20240305123648.8847-5-shreeya.patel@collabora.com> References: <20240305123648.8847-1-shreeya.patel@collabora.com> <20240305123648.8847-5-shreeya.patel@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240305_061141_334444_9B9F3509 X-CRM114-Status: GOOD ( 19.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Dienstag, 5. M=E4rz 2024, 13:36:46 CET schrieb Shreeya Patel: > Add device tree support for Synopsys DesignWare HDMI RX > Controller. > = > Reviewed-by: Dmitry Osipenko > Tested-by: Dmitry Osipenko > Co-developed-by: Dingxian Wen > Signed-off-by: Dingxian Wen > Signed-off-by: Shreeya Patel > --- > Changes in v2 :- > - Fix some of the checkpatch errors and warnings > - Rename resets, vo1-grf and HPD > - Move hdmirx_cma node to the rk3588.dtsi file > = > .../boot/dts/rockchip/rk3588-pinctrl.dtsi | 41 ++++++++++++++ > arch/arm64/boot/dts/rockchip/rk3588.dtsi | 55 +++++++++++++++++++ > 2 files changed, 96 insertions(+) > diff --git a/arch/arm64/boot/dts/rockchip/rk3588.dtsi b/arch/arm64/boot/d= ts/rockchip/rk3588.dtsi > index 5519c1430cb7..8adb98b99701 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3588.dtsi > @@ -7,6 +7,24 @@ > #include "rk3588-pinctrl.dtsi" > = > / { > + reserved-memory { > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + ranges; add blank line here > + /* > + * The 4k HDMI capture controller works only with 32bit > + * phys addresses and doesn't support IOMMU. HDMI RX CMA > + * must be reserved below 4GB. > + */ > + hdmirx_cma: hdmirx_cma { phandles use "_", but node-names "-" > + compatible =3D "shared-dma-pool"; > + alloc-ranges =3D <0x0 0x0 0x0 0xffffffff>; > + size =3D <0x0 (160 * 0x100000)>; /* 160MiB */ The comment above that node, could elaborate where the value of 160MB originates from. I assume it is to hold n-times of 4K frames or whatever, but it would be helpful for people to be able to read that. > + no-map; > + status =3D "disabled"; > + }; > + }; > + > pcie30_phy_grf: syscon@fd5b8000 { > compatible =3D "rockchip,rk3588-pcie3-phy-grf", "syscon"; > reg =3D <0x0 0xfd5b8000 0x0 0x10000>; > @@ -85,6 +103,38 @@ i2s10_8ch: i2s@fde00000 { > status =3D "disabled"; > }; > = > + hdmi_receiver: hdmi-receiver@fdee0000 { Maybe rename the label to "hdmirx:" ... that way in a board enabling the cma region, both nodes would stay close to each other? > + compatible =3D "rockchip,rk3588-hdmirx-ctrler", "snps,dw-hdmi-rx"; > + reg =3D <0x0 0xfdee0000 0x0 0x6000>; > + power-domains =3D <&power RK3588_PD_VO1>; > + rockchip,grf =3D <&sys_grf>; > + rockchip,vo1-grf =3D <&vo1_grf>; > + interrupts =3D , > + , > + ; > + interrupt-names =3D "cec", "hdmi", "dma"; > + clocks =3D <&cru ACLK_HDMIRX>, > + <&cru CLK_HDMIRX_AUD>, > + <&cru CLK_CR_PARA>, > + <&cru PCLK_HDMIRX>, > + <&cru CLK_HDMIRX_REF>, > + <&cru PCLK_S_HDMIRX>, > + <&cru HCLK_VO1>; > + clock-names =3D "aclk", > + "audio", > + "cr_para", > + "pclk", > + "ref", > + "hclk_s_hdmirx", > + "hclk_vo1"; the driver uses of_reserved_mem_device_init(), so doesn't this node need a "memory-region =3D <&hdmirx_cma>; or similar? > + resets =3D <&cru SRST_A_HDMIRX>, <&cru SRST_P_HDMIRX>, > + <&cru SRST_HDMIRX_REF>, <&cru SRST_A_HDMIRX_BIU>; > + reset-names =3D "axi", "apb", "ref", "biu"; > + pinctrl-0 =3D <&hdmim1_rx>; > + pinctrl-names =3D "default"; > + status =3D "disabled"; > + }; > + > pcie3x4: pcie@fe150000 { > compatible =3D "rockchip,rk3588-pcie", "rockchip,rk3568-pcie"; > #address-cells =3D <3>; > @@ -339,3 +389,8 @@ pcie30phy: phy@fee80000 { > status =3D "disabled"; > }; > }; > + > +&hdmirx_cma { > + status =3D "okay"; > +}; I'd assume a board that enables &hdmi_receiver would also enable hdmirx_cma and not the soc dtsi for _all_ boards? Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel