From: Michal Simek <michal.simek@amd.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
linux-kernel@vger.kernel.org, monstr@monstr.eu,
michal.simek@xilinx.com, git@xilinx.com
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
Srinivas Neeli <srinivas.neeli@amd.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/ZYNQ ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] dt-bindings: gpio: gpio-xilinx: Mark clocks as required property
Date: Mon, 16 Jun 2025 08:51:49 +0200 [thread overview]
Message-ID: <765a606b-3b87-4a08-8630-69a3c52ed138@amd.com> (raw)
In-Reply-To: <1fced39f-1077-4af7-9294-affb99860984@kernel.org>
Hi,
On 6/16/25 08:41, Krzysztof Kozlowski wrote:
> On 13/06/2025 13:26, Michal Simek wrote:
>>>> Based on discussion at
>>>> https://lore.kernel.org/lkml/20241002-revivable-crummy-f780adec538c@spud/
>>>>
>>>> Actually this shouldn't be only targetting GPIO but also for example
>>>> xlnx,xps-timebase-wdt-1.00.a but I would like to check it first on gpio
>>>> before starting to check other bindings.
>>>
>>> IIUC, patch #1 is a prerequisite, so you need to squash them. Otherwise
>>> dt_binding_check is not bisectable and we want it to be bisectable.
>>
>> No issue with squash if necessary. I sent it as series to be applied together
>> which won't break bisectability of tree and no new error is going to be reported.
>
> You did not say anything about dependencies and merging strategy, to
> this would go via different trees. Sending something in one patchset
> does not mean that there is a dependency.
No offense but I don't think I can agree with this. The main purpose of patchset
is to show sequence how things should go one after each other and series should
go via single tree.
Sometimes people are asking for picking up individual patches from series but
this is not a normal way. Also seen a lot of time asking for splitting that
patches and send them individually instead of picking up from the series.
Anyway. If you want to me to squash it together I am fine with it.
If you want to me to create cover letter that's fine for me too.
Thanks,
Michal
next prev parent reply other threads:[~2025-06-16 6:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8407ef56b11632c1a7abfce8a4534ed8a8ed56cc.1749809570.git.michal.simek@amd.com>
2025-06-13 10:12 ` [PATCH v2 2/2] dt-bindings: gpio: gpio-xilinx: Mark clocks as required property Michal Simek
2025-06-13 11:07 ` Krzysztof Kozlowski
2025-06-13 11:26 ` Michal Simek
2025-06-16 6:41 ` Krzysztof Kozlowski
2025-06-16 6:51 ` Michal Simek [this message]
2025-06-16 7:10 ` Krzysztof Kozlowski
2025-06-16 7:13 ` Krzysztof Kozlowski
2025-06-16 7:18 ` Michal Simek
2025-06-16 7:23 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=765a606b-3b87-4a08-8630-69a3c52ed138@amd.com \
--to=michal.simek@amd.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=robh@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.neeli@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox