From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88358EE49A3 for ; Wed, 23 Aug 2023 02:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:CC: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JtE3wLBS6L+Sv55dk53M18dbp4NOzMxqaDQCohjunHo=; b=hboxPWtid6FrwP gVzI+TMOnpbggE+mXFREx8YW6dRiO0FGQYt16i69mmTA6Ii4J+rNC0xZ05DEcRI99PrD8u/o9tpXr ZIphSm+rdAlysw0HqX2Hx1stDWEvTk/2fAcP6cSuIai0reXfCheAv0TStdJgbIcJ5LwnEZd7MiSeH dXqZyspbfpq8bpBZap6FWLP2HMnXC2cxVCo5b29F/MnP09gGEjPhA4ae7WQNYQRO8tzpLco+Wk2+2 Tz6D07Rb1K+VU9Lvt1HUNKvvuvmIIGdkEgA60gjzzNIZyONvzUvUVDomQhrrD68cHmLcJMzA64mxO BUflhpQL2VlTdRGwjTsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qYdlf-00H5gC-1R; Wed, 23 Aug 2023 02:38:47 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qYdlc-00H5f8-0p for linux-arm-kernel@lists.infradead.org; Wed, 23 Aug 2023 02:38:45 +0000 Received: from kwepemm600007.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RVr023tlhztS8Q; Wed, 23 Aug 2023 10:34:42 +0800 (CST) Received: from [10.69.136.139] (10.69.136.139) by kwepemm600007.china.huawei.com (7.193.23.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 23 Aug 2023 10:38:25 +0800 Message-ID: <767363ed-aaae-af58-33de-939dc29ff1e6@huawei.com> Date: Wed, 23 Aug 2023 10:38:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: , , , , , , , , Subject: Re: [PATCH drivers/perf: hisi: 1/2] drivers/perf: hisi: hns3: default use hardware event 0 as group leader event. To: Will Deacon References: <20230816094619.3563784-1-shaojijie@huawei.com> <20230816094619.3563784-2-shaojijie@huawei.com> <20230821115820.GA19617@willie-the-truck> From: Jijie Shao In-Reply-To: <20230821115820.GA19617@willie-the-truck> X-Originating-IP: [10.69.136.139] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600007.china.huawei.com (7.193.23.208) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230822_193844_491320_FFFC4167 X-CRM114-Status: GOOD ( 12.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org on 2023/8/21 19:58, Will Deacon wrote: > On Wed, Aug 16, 2023 at 05:46:18PM +0800, Jijie Shao wrote: >> From: Hao Chen >> >> For hns3 pmu events, we use command as below before: >> perf stat -g -e hns3_pmu_sicl_0/config=0x00105,global=1/ >> -e hns3_pmu_sicl_0/config=0x10105,global=1/ -I 1000 >> >> We want to use -g parameter to make 0x00105 event and 0x10105 event >> share a hardware event, but for kernel 6.2, 'commit 5f8f95673f68 >> ("perf evlist: Remove group option.")' remove -g parameter. >> >> So add this patch to set default related event idx as 0 to share >> the first hardware event. > Hmm, but the change cited above is a userspace change so I don't think > we should be making driver-side changes for that. Furthermore, the commit > message there suggests that you should be using a different syntax, > introduced by 89efb029502d ("perf tools: Add support to parse event > group syntax") (which describes the grammer and has some examples too). > > Will Thanks for your introduction, we are retesting this scenario as 89efb029502d("perf tools: Add support to parse eventgroup syntax") Jijie Shao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel