* [PATCH 1/2] clk: imx8mp: fix sai4 clock
@ 2022-12-19 17:10 Marco Felsch
2022-12-19 17:10 ` [PATCH 2/2] dt-bindings: clocks: imx8mp: make sai4 a dummy clock Marco Felsch
2023-01-12 23:55 ` [PATCH 1/2] clk: imx8mp: fix sai4 clock Stephen Boyd
0 siblings, 2 replies; 8+ messages in thread
From: Marco Felsch @ 2022-12-19 17:10 UTC (permalink / raw)
To: abelvesa, mturquette, sboyd, shawnguo, festevam, robh+dt,
krzysztof.kozlowski+dt, Anson.Huang
Cc: linux-clk, linux-arm-kernel, devicetree, kernel
The reference manual don't mention a SAI4 hardware block. This would be
clock slice 78 which is skipped (TRM, page 237). Remove any reference to
this clock to align the driver with the reality.
Fixes: 9c140d992676 ("clk: imx: Add support for i.MX8MP clock driver")
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
drivers/clk/imx/clk-imx8mp.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c
index 652ae58c2735..c161a18a8130 100644
--- a/drivers/clk/imx/clk-imx8mp.c
+++ b/drivers/clk/imx/clk-imx8mp.c
@@ -176,10 +176,6 @@ static const char * const imx8mp_sai3_sels[] = {"osc_24m", "audio_pll1_out", "au
"video_pll1_out", "sys_pll1_133m", "osc_hdmi",
"clk_ext3", "clk_ext4", };
-static const char * const imx8mp_sai4_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out",
- "video_pll1_out", "sys_pll1_133m", "osc_hdmi",
- "clk_ext1", "clk_ext2", };
-
static const char * const imx8mp_sai5_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out",
"video_pll1_out", "sys_pll1_133m", "osc_hdmi",
"clk_ext2", "clk_ext3", };
@@ -568,7 +564,6 @@ static int imx8mp_clocks_probe(struct platform_device *pdev)
hws[IMX8MP_CLK_SAI1] = imx8m_clk_hw_composite("sai1", imx8mp_sai1_sels, ccm_base + 0xa580);
hws[IMX8MP_CLK_SAI2] = imx8m_clk_hw_composite("sai2", imx8mp_sai2_sels, ccm_base + 0xa600);
hws[IMX8MP_CLK_SAI3] = imx8m_clk_hw_composite("sai3", imx8mp_sai3_sels, ccm_base + 0xa680);
- hws[IMX8MP_CLK_SAI4] = imx8m_clk_hw_composite("sai4", imx8mp_sai4_sels, ccm_base + 0xa700);
hws[IMX8MP_CLK_SAI5] = imx8m_clk_hw_composite("sai5", imx8mp_sai5_sels, ccm_base + 0xa780);
hws[IMX8MP_CLK_SAI6] = imx8m_clk_hw_composite("sai6", imx8mp_sai6_sels, ccm_base + 0xa800);
hws[IMX8MP_CLK_ENET_QOS] = imx8m_clk_hw_composite("enet_qos", imx8mp_enet_qos_sels, ccm_base + 0xa880);
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/2] dt-bindings: clocks: imx8mp: make sai4 a dummy clock
2022-12-19 17:10 [PATCH 1/2] clk: imx8mp: fix sai4 clock Marco Felsch
@ 2022-12-19 17:10 ` Marco Felsch
2022-12-20 20:01 ` Rob Herring
2023-01-12 23:55 ` Stephen Boyd
2023-01-12 23:55 ` [PATCH 1/2] clk: imx8mp: fix sai4 clock Stephen Boyd
1 sibling, 2 replies; 8+ messages in thread
From: Marco Felsch @ 2022-12-19 17:10 UTC (permalink / raw)
To: abelvesa, mturquette, sboyd, shawnguo, festevam, robh+dt,
krzysztof.kozlowski+dt, Anson.Huang
Cc: linux-clk, linux-arm-kernel, devicetree, kernel
The hardware don't have a SAI4 instance so remove the define. Use a
comment to keep it as reference and to avoid confusion.
Fixes: 108869144739 ("dt-bindings: imx: Add clock binding doc for i.MX8MP")
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
include/dt-bindings/clock/imx8mp-clock.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h
index 9d5cc2ddde89..61418ae4bcfa 100644
--- a/include/dt-bindings/clock/imx8mp-clock.h
+++ b/include/dt-bindings/clock/imx8mp-clock.h
@@ -130,7 +130,7 @@
#define IMX8MP_CLK_SAI1 123
#define IMX8MP_CLK_SAI2 124
#define IMX8MP_CLK_SAI3 125
-#define IMX8MP_CLK_SAI4 126
+/* #define IMX8MP_CLK_SAI4 126 */
#define IMX8MP_CLK_SAI5 127
#define IMX8MP_CLK_SAI6 128
#define IMX8MP_CLK_ENET_QOS 129
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] dt-bindings: clocks: imx8mp: make sai4 a dummy clock
2022-12-19 17:10 ` [PATCH 2/2] dt-bindings: clocks: imx8mp: make sai4 a dummy clock Marco Felsch
@ 2022-12-20 20:01 ` Rob Herring
2023-01-12 23:55 ` Stephen Boyd
1 sibling, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-12-20 20:01 UTC (permalink / raw)
To: Marco Felsch
Cc: krzysztof.kozlowski+dt, devicetree, festevam, sboyd, abelvesa,
Anson.Huang, kernel, mturquette, linux-arm-kernel, shawnguo,
robh+dt, linux-clk
On Mon, 19 Dec 2022 18:10:58 +0100, Marco Felsch wrote:
> The hardware don't have a SAI4 instance so remove the define. Use a
> comment to keep it as reference and to avoid confusion.
>
> Fixes: 108869144739 ("dt-bindings: imx: Add clock binding doc for i.MX8MP")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> include/dt-bindings/clock/imx8mp-clock.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] dt-bindings: clocks: imx8mp: make sai4 a dummy clock
2022-12-19 17:10 ` [PATCH 2/2] dt-bindings: clocks: imx8mp: make sai4 a dummy clock Marco Felsch
2022-12-20 20:01 ` Rob Herring
@ 2023-01-12 23:55 ` Stephen Boyd
1 sibling, 0 replies; 8+ messages in thread
From: Stephen Boyd @ 2023-01-12 23:55 UTC (permalink / raw)
To: Anson.Huang, Marco Felsch, abelvesa, festevam,
krzysztof.kozlowski+dt, mturquette, robh+dt, shawnguo
Cc: linux-clk, linux-arm-kernel, devicetree, kernel
Quoting Marco Felsch (2022-12-19 09:10:58)
> The hardware don't have a SAI4 instance so remove the define. Use a
> comment to keep it as reference and to avoid confusion.
>
> Fixes: 108869144739 ("dt-bindings: imx: Add clock binding doc for i.MX8MP")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] clk: imx8mp: fix sai4 clock
2022-12-19 17:10 [PATCH 1/2] clk: imx8mp: fix sai4 clock Marco Felsch
2022-12-19 17:10 ` [PATCH 2/2] dt-bindings: clocks: imx8mp: make sai4 a dummy clock Marco Felsch
@ 2023-01-12 23:55 ` Stephen Boyd
2023-04-21 9:16 ` Marco Felsch
1 sibling, 1 reply; 8+ messages in thread
From: Stephen Boyd @ 2023-01-12 23:55 UTC (permalink / raw)
To: Anson.Huang, Marco Felsch, abelvesa, festevam,
krzysztof.kozlowski+dt, mturquette, robh+dt, shawnguo
Cc: linux-clk, linux-arm-kernel, devicetree, kernel
Quoting Marco Felsch (2022-12-19 09:10:57)
> The reference manual don't mention a SAI4 hardware block. This would be
> clock slice 78 which is skipped (TRM, page 237). Remove any reference to
> this clock to align the driver with the reality.
>
> Fixes: 9c140d992676 ("clk: imx: Add support for i.MX8MP clock driver")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] clk: imx8mp: fix sai4 clock
2023-01-12 23:55 ` [PATCH 1/2] clk: imx8mp: fix sai4 clock Stephen Boyd
@ 2023-04-21 9:16 ` Marco Felsch
2023-06-12 19:29 ` Stephen Boyd
0 siblings, 1 reply; 8+ messages in thread
From: Marco Felsch @ 2023-04-21 9:16 UTC (permalink / raw)
To: Stephen Boyd
Cc: Anson.Huang, abelvesa, festevam, krzysztof.kozlowski+dt,
mturquette, robh+dt, shawnguo, linux-clk, linux-arm-kernel,
devicetree, kernel
Hi,
On 23-01-12, Stephen Boyd wrote:
> Quoting Marco Felsch (2022-12-19 09:10:57)
> > The reference manual don't mention a SAI4 hardware block. This would be
> > clock slice 78 which is skipped (TRM, page 237). Remove any reference to
> > this clock to align the driver with the reality.
> >
> > Fixes: 9c140d992676 ("clk: imx: Add support for i.MX8MP clock driver")
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
I noticed that this isn't part of v6.3. @Abel can you add your rb or
comments please?
Regards,
Marco
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] clk: imx8mp: fix sai4 clock
2023-04-21 9:16 ` Marco Felsch
@ 2023-06-12 19:29 ` Stephen Boyd
2023-07-31 14:24 ` Marco Felsch
0 siblings, 1 reply; 8+ messages in thread
From: Stephen Boyd @ 2023-06-12 19:29 UTC (permalink / raw)
To: Marco Felsch
Cc: Anson.Huang, abelvesa, festevam, krzysztof.kozlowski+dt,
mturquette, robh+dt, shawnguo, linux-clk, linux-arm-kernel,
devicetree, kernel
Quoting Marco Felsch (2023-04-21 02:16:49)
> Hi,
>
> On 23-01-12, Stephen Boyd wrote:
> > Quoting Marco Felsch (2022-12-19 09:10:57)
> > > The reference manual don't mention a SAI4 hardware block. This would be
> > > clock slice 78 which is skipped (TRM, page 237). Remove any reference to
> > > this clock to align the driver with the reality.
> > >
> > > Fixes: 9c140d992676 ("clk: imx: Add support for i.MX8MP clock driver")
> > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > ---
> >
> > Acked-by: Stephen Boyd <sboyd@kernel.org>
>
> I noticed that this isn't part of v6.3. @Abel can you add your rb or
> comments please?
>
Please resend and Cc linux-imx@nxp.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] clk: imx8mp: fix sai4 clock
2023-06-12 19:29 ` Stephen Boyd
@ 2023-07-31 14:24 ` Marco Felsch
0 siblings, 0 replies; 8+ messages in thread
From: Marco Felsch @ 2023-07-31 14:24 UTC (permalink / raw)
To: Stephen Boyd
Cc: Anson.Huang, abelvesa, festevam, krzysztof.kozlowski+dt,
mturquette, robh+dt, shawnguo, linux-clk, linux-arm-kernel,
devicetree, kernel
On 23-06-12, Stephen Boyd wrote:
> Quoting Marco Felsch (2023-04-21 02:16:49)
> > Hi,
> >
> > On 23-01-12, Stephen Boyd wrote:
> > > Quoting Marco Felsch (2022-12-19 09:10:57)
> > > > The reference manual don't mention a SAI4 hardware block. This would be
> > > > clock slice 78 which is skipped (TRM, page 237). Remove any reference to
> > > > this clock to align the driver with the reality.
> > > >
> > > > Fixes: 9c140d992676 ("clk: imx: Add support for i.MX8MP clock driver")
> > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > > ---
> > >
> > > Acked-by: Stephen Boyd <sboyd@kernel.org>
> >
> > I noticed that this isn't part of v6.3. @Abel can you add your rb or
> > comments please?
> >
>
> Please resend and Cc linux-imx@nxp.com
Done
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-07-31 14:24 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-19 17:10 [PATCH 1/2] clk: imx8mp: fix sai4 clock Marco Felsch
2022-12-19 17:10 ` [PATCH 2/2] dt-bindings: clocks: imx8mp: make sai4 a dummy clock Marco Felsch
2022-12-20 20:01 ` Rob Herring
2023-01-12 23:55 ` Stephen Boyd
2023-01-12 23:55 ` [PATCH 1/2] clk: imx8mp: fix sai4 clock Stephen Boyd
2023-04-21 9:16 ` Marco Felsch
2023-06-12 19:29 ` Stephen Boyd
2023-07-31 14:24 ` Marco Felsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).