From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64F1FC433E0 for ; Mon, 29 Jun 2020 16:56:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31F962559F for ; Mon, 29 Jun 2020 16:56:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uuJsPLKg"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="UZ6FVKc7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31F962559F Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/vjY2lvzRrmzm49JrCY6XwdXtp/a84qVh5slOdmYac8=; b=uuJsPLKgQvUolpcmjziyU+VSE gYsIN4pGOyH2EaHXsShqAGaga08DFKgx3DHso/7qaTb5USKU9dZM17ki2gW/Ev/xGex/Kxyyy4615 C4q0oREUo/sci30cEQ32c/Gyrly8hiKjGvIDjFwFEGqsAFdlPMcZjLMdlbaaSsVtv8o5DKyD3FvaD BA+ijKKkMCtM4Khb2vO0xa/vMeK/jw9kV/PixpL7rdmDfg8yIUVsY3CyWIny0MLzRZxakdT3eNiK9 et96k9zooavxX+WMSJthmnKOGnafBjqg6Sj07XOgdaHz0BOWvsew/kMVZzQEAGGnduYrtU/U6qMlN vlsA4Z7fA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpx38-0007gl-My; Mon, 29 Jun 2020 16:54:30 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpx36-0007gW-0i for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 16:54:29 +0000 Received: by mail-wm1-x342.google.com with SMTP id q15so16049976wmj.2 for ; Mon, 29 Jun 2020 09:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=X9rfAlOxfe38VMX/oL2KWbXJmMAccAeFpKeQ6kbgS5I=; b=UZ6FVKc7frhOr+27BqHpUSAAlW/b6bGMLjuQl7IYNjpAn9UP9nwBkgtlMucNWw5P0M YTRq3+LIylKWY1EpNL4FD5Vuwel8piO0VIk6nUxpzG9Ls450pSl99qLEi2KfmUEV4fC3 Q0HMPnnWRd7jZFkfC02SLQXuTxIeg1aAPTOqI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=X9rfAlOxfe38VMX/oL2KWbXJmMAccAeFpKeQ6kbgS5I=; b=btvFpkarhXPKQu5t//0WQnQazVonk/T+AM1Tsw/RfoxFrujBFeQS622kBvgV3OVjzg mLaDegtu6VzpYlWu5VzTxnVm12cH8mOXBsm+AoK3huWzwbUD+09Jyvu6ORUlwLi0896w JRvru9YY3bSdhsEAyPpgh9pXJ5TOYifd5mPhrxChB3CI/mByisMREyPAqWnBo8+xLI14 r9iyy5hyGUrr/8ZiUHjyy0c1fgApyVW/VQRI4Y8l7xbwLUIHwoKgrUK0/dvv4p6KR9aS eDIv5qO6l607qwUCrIcor5SvWLM8XCBaPHHbmy+D2LwyqySZhDBnB82Yu7uXbToMgOaX 5H3A== X-Gm-Message-State: AOAM532N2oOk6zQPYMzK+EazCtFmW/+K3/h9/R9ThXzER7Es0qRPdWAe L1grV4YzhDLoAWj7NPv88VZJAw== X-Google-Smtp-Source: ABdhPJzEBOnJbI3F9fbCTkykHuYski3xJ+b+DkSQKsgVaDyTwA3/2FplB6F5M/HjmK7MhPF+FIuGjw== X-Received: by 2002:a05:600c:c1:: with SMTP id u1mr17895281wmm.48.1593449664783; Mon, 29 Jun 2020 09:54:24 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id e8sm396022wrp.26.2020.06.29.09.54.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2020 09:54:24 -0700 (PDT) Subject: Re: [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle To: Florian Fainelli , Lee Jones , thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org References: <20200629124752.1018358-1-lee.jones@linaro.org> <20200629124752.1018358-2-lee.jones@linaro.org> <3470e941-aa86-11a8-674b-5258a08fedb1@gmail.com> From: Scott Branden Message-ID: <76a657ca-d30e-c5f2-f057-1c1bb7c8e1bf@broadcom.com> Date: Mon, 29 Jun 2020 09:54:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <3470e941-aa86-11a8-674b-5258a08fedb1@gmail.com> Content-Language: en-US X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, Yendapally Reddy Dhananjaya Reddy , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-06-29 9:45 a.m., Florian Fainelli wrote: > > On 6/29/2020 5:47 AM, Lee Jones wrote: >> 'duty' here is an unsigned int, thus checking for <0 will always >> evaluate to false. >> >> Fixes the following W=1 warning: >> >> drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] >> >> Cc: Ray Jui >> Cc: Scott Branden >> Cc: Yendapally Reddy Dhananjaya Reddy >> Cc: bcm-kernel-feedback-list@broadcom.com >> Cc: linux-pwm@vger.kernel.org >> Signed-off-by: Lee Jones > And IPROC_PWM_DUTY_CYCLE_MIN is unused after remove this single use of > the define, if you also remove it you can add: > > Reviewed-by: Florian Fainelli We actually made this same change internally recently but hadn't upstreamed it yet. Tested-by: Scott Branden _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel