From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31DB3D10BE4 for ; Sat, 26 Oct 2024 03:50:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6QsftRtGDzmoJq4o3UAdGB6dmDX3MTYPtWoEsqFu+Us=; b=GSElO3pglVCsxKuCi0KntWr2CR Dycxz5W9H2mAPAmQazfT5FWvAs/5gjZ6q2FsYeNIkqEfRF+emV7Mefh8PuuahjoEc9zEUqGd6PD8v JnFhZGJLLmI0DuZgw4ou3C8Si/RqPipe+Os+vsr/ghkqAsXs63r9uBHCZcdbQTVXvCe+eIrG8uO9q fKeHhX7QR6hboQ+OUzRGu1EwIspuPI6csn3rssRP1+Jv5l4cOW6S1kG0hR2afZDOBgJ90Eh9rkqiE xaCJedercejET7ZJ43K1oWkst2Hm2nCwfkY+PlK60IhOB8Xavi+ieFpKc8dQ9ZgVj1B2haOvkdeHh 5wLM9Jwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t4Xov-00000005rIB-0KPR; Sat, 26 Oct 2024 03:50:33 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t4Xn4-00000005r4b-05Hs for linux-arm-kernel@lists.infradead.org; Sat, 26 Oct 2024 03:48:39 +0000 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49Q2B2CX024778; Sat, 26 Oct 2024 03:48:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6QsftRtGDzmoJq4o3UAdGB6dmDX3MTYPtWoEsqFu+Us=; b=ZulFvfGkPHOn2dP/ N8cZxdukk+ASo/wwihUPnMlVdKmmkOXaNZU/3Zu21gWGo1PS8QDrdrbpkOVqlU5Z MO3pubSW3pCH+/3Eo6vFNaX4fda0HBIZ9xjSy/Vj3q/+rXgTrukohXTznWgXE4Bk G2zUKnmQt99DblHCOUuYT49U/QGU/o4zNSnkrKZF7Iu9kcK3S0npURh/kcvSKdCF 9GJJZp95wOAsqJxP4dM9jCcSnmtrvaiBxR/VUzZo4ir8WYFoTeea4MdaoJnwkBkf 5CwEFAMEcxAtUb7yYlO64N7gmU6YHcTLu2pZG3BoOvrANP89HZz3thx3x43bJ0sZ 3BBWVw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42gqcqg3sr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 26 Oct 2024 03:48:27 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 49Q3mQ5Y024830 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 26 Oct 2024 03:48:26 GMT Received: from [10.253.35.162] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 25 Oct 2024 20:48:23 -0700 Message-ID: <76ce5d6d-a468-4f49-bc56-da6db2a4c9ba@quicinc.com> Date: Sat, 26 Oct 2024 11:48:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/4] dt-bindings: arm: qcom,coresight-static-replicator: Add property for source filtering To: Suzuki K Poulose , Mike Leach , James Clark , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mathieu Poirier , Leo Yan , Alexander Shishkin CC: , , , , References: <20241024065306.14647-1-quic_taozha@quicinc.com> <20241024065306.14647-2-quic_taozha@quicinc.com> <30301f0b-5b04-4150-8159-5b8721486d6c@arm.com> Content-Language: en-US From: Tao Zhang In-Reply-To: <30301f0b-5b04-4150-8159-5b8721486d6c@arm.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: vJdy44AY_x8dID1qu4iAge19vJWyB4Ai X-Proofpoint-GUID: vJdy44AY_x8dID1qu4iAge19vJWyB4Ai X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0 phishscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410260030 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241025_204838_086514_08F6374E X-CRM114-Status: GOOD ( 17.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/24/2024 6:36 PM, Suzuki K Poulose wrote: > On 24/10/2024 10:14, Suzuki K Poulose wrote: >> On 24/10/2024 07:53, Tao Zhang wrote: >>> The is some "magic" hard coded filtering in the replicators, >>> which only passes through trace from a particular "source". Add >>> a new property "filter-src" to label a phandle to the coresight >>> trace source device matching the hard coded filtering for the port. >> >> As mentioned in here in v3 review : >> >> https://lkml.org/lkml/2024/8/21/597 >> >> Please do not use "src", expand it to "source" > > Just to confirm, this is only for the "bindings" string, not for the > variables used in the patches. Yes, it is only used as the "bindings" string. Best, Tao > > Suzuki > > >> >> Rest looks fine. >> >> Suzuki >> >>> >>> Signed-off-by: Tao Zhang >>> --- >>>   .../arm/arm,coresight-static-replicator.yaml  | 19 >>> ++++++++++++++++++- >>>   1 file changed, 18 insertions(+), 1 deletion(-) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml >>> b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml >>> >>> index 1892a091ac35..0d258c79eb94 100644 >>> --- >>> a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml >>> +++ >>> b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml >>> @@ -45,7 +45,22 @@ properties: >>>       patternProperties: >>>         '^port@[01]$': >>>           description: Output connections to CoreSight Trace bus >>> -        $ref: /schemas/graph.yaml#/properties/port >>> +        $ref: /schemas/graph.yaml#/$defs/port-base >>> +        unevaluatedProperties: false >>> + >>> +        properties: >>> +          endpoint: >>> +            $ref: /schemas/graph.yaml#/$defs/endpoint-base >>> +            unevaluatedProperties: false >>> + >>> +            properties: >>> +              filter-src: >>> +                $ref: /schemas/types.yaml#/definitions/phandle >>> +                description: >>> +                  phandle to the coresight trace source device >>> matching the >>> +                  hard coded filtering for this port >>> + >>> +              remote-endpoint: true >>>   required: >>>     - compatible >>> @@ -72,6 +87,7 @@ examples: >>>                   reg = <0>; >>>                   replicator_out_port0: endpoint { >>>                       remote-endpoint = <&etb_in_port>; >>> +                    filter-src = <&tpdm_video>; >>>                   }; >>>               }; >>> @@ -79,6 +95,7 @@ examples: >>>                   reg = <1>; >>>                   replicator_out_port1: endpoint { >>>                       remote-endpoint = <&tpiu_in_port>; >>> +                    filter-src = <&tpdm_mdss>; >>>                   }; >>>               }; >>>           }; >> >