From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 959C4CD1283 for ; Thu, 28 Mar 2024 19:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g2MEGZVUUac85JIlDfCeifhkKj0/zbZBJY5P3oh8yOs=; b=hm2tRaS+MZct1o Ng3WcR8wZvJK4z4V4GC5/Pz8cOn5qDn3L0+MEWCmwCt3F4O9oO3p9aOqD8AGoo4Z4U7kc/akJ4ZVV xyObi5ooIVO9nI5bEHzihzDe82TNZopaahFmn67mrTleIzcyWH4+Kyt+nJIzsQM7GxtMYzZS7M9qO QF9GZo721EU6ydFdo0vIjatLUmgmKMk9KtLlNt4hnzX+CRKgA7mw/ltzGq4EEzJdX1h6csvsFDcBd 9w6cDOerCvQpMJfGKoBzb/2sfzcnSdKxmceO/bxIZWT+NwTDTeXskdNQrTIg1TSUZpeHnEA7K5O8e pEbL0oKNJ6hSAwyKcXjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpvJn-0000000FM8J-18gO; Thu, 28 Mar 2024 19:21:43 +0000 Received: from mail-108-mta175.mxroute.com ([136.175.108.175]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpvJk-0000000FM7V-0UGY for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2024 19:21:41 +0000 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta175.mxroute.com (ZoneMTA) with ESMTPSA id 18e867e00920003bea.009 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 28 Mar 2024 19:16:28 +0000 X-Zone-Loop: e81182695bb5b57311dfc3b4900ec38c97ca4d06957a X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tQJb1jl0+k5VWPtDnFdvdOzbEiK5LWRoPsu+EFTE44M=; b=qwCXm9BF5B/BKG1LMbYhN94yUV rAc3/t4oTkVHcORDV9B8HrlemSm+v5kD/t39rjI6ws/L1XXVKQc+i7KbjwCBB3NAAxMyt6oXQ1EfD IlhlxeC1iAParASXRSIBb+oE/zna2MuWrkPKPO3l9gROf39Fs21jOlpBJqFu10PqisHRKMl6kjNEs Jahj+QjNfU9EwqGze4OsIvNSOts0YMcTLDSyvubePtWWK2F9R9GVJI0nuN0jtfVHViTaIo6lOu3qn aRtavdTKoklJWGZYZx6JUB9w2wB3k9wPEXoOAViWsskP1Jok9Yibg6Z30Qwhewbeb2ybGBRRe9khs pEyvc0EQ==; Message-ID: <76f999a7-55e0-4676-aa75-8fcd466e046b@luigi311.com> Date: Thu, 28 Mar 2024 13:16:22 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 18/23] dt-bindings: media: imx258: Add alternate compatible strings Content-Language: en-US To: Rob Herring Cc: linux-media@vger.kernel.org, dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240327231710.53188-1-git@luigi311.com> <20240327231710.53188-19-git@luigi311.com> <20240328185526.GA88354-robh@kernel.org> From: Luigi311 In-Reply-To: <20240328185526.GA88354-robh@kernel.org> X-Authenticated-Id: git@luigi311.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_122140_297484_A0114FFA X-CRM114-Status: GOOD ( 19.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/28/24 12:55, Rob Herring wrote: > On Wed, Mar 27, 2024 at 05:17:04PM -0600, git@luigi311.com wrote: >> From: Dave Stevenson >> >> There are a number of variants of the imx258 modules that can not >> be differentiated at runtime, so add compatible strings for them. >> But you are only adding 1 variant. I can not speak for Dave but as to why this was added here but looking at the imx296 yaml that has something similar where there are multiple variants that may not be detectable at run time but does not include similar verbiage in the main description. Should I drop this from the description so it matches the imx296? > >> >> Signed-off-by: Dave Stevenson >> Signed-off-by: Luigi311 >> --- >> .../devicetree/bindings/media/i2c/sony,imx258.yaml | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> index bee61a443b23..c7856de15ba3 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> @@ -14,10 +14,14 @@ description: |- >> type stacked image sensor with a square pixel array of size 4208 x 3120. It >> is programmable through I2C interface. Image data is sent through MIPI >> CSI-2. >> + There are a number of variants of the sensor which cannot be detected at >> + runtime, so multiple compatible strings are required to differentiate these. > > That's more reasoning/why for the patch than description of the h/w. > >> properties: >> compatible: >> - const: sony,imx258 >> + - enum: >> + - sony,imx258 >> + - sony,imx258-pdaf > > How do I know which one to use? Please define what PDAF means somewhere > as well as perhaps what the original/default variant is or isn't. Would it make sense to change the properties to include a description like so properties: compatible: enum: - sony,imx258 - sony,imx258-pdaf description: The IMX258 sensor exists in two different models, a standard variant (IMX258) and a variant with phase detection autofocus (IMX258-PDAF). The camera module does not expose the model through registers, so the exact model needs to be specified. > >> >> assigned-clocks: true >> assigned-clock-parents: true >> -- >> 2.42.0 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel