From mboxrd@z Thu Jan 1 00:00:00 1970 From: haojian.zhuang@gmail.com (Haojian Zhuang) Date: Wed, 9 Dec 2009 22:44:15 -0500 Subject: [PATCH v2 09/09] regulator: refresh 88pm8607 driver with updated api In-Reply-To: <20091209152026.GD32223@rakim.wolfsonmicro.main> References: <771cded00912090518s29c295a9v7f555a543f3bc4e6@mail.gmail.com> <20091209152026.GD32223@rakim.wolfsonmicro.main> Message-ID: <771cded00912091944q14be2f94gc7343f232abdbd0f@mail.gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Dec 9, 2009 at 10:20 AM, Mark Brown wrote: > On Wed, Dec 09, 2009 at 08:18:18AM -0500, Haojian Zhuang wrote: > >> Since i2c API of mfd 88pm860x driver is changed, refresh 88pm8607 driver. >> Remove the support of 88PM8607 A0/A1 stepping. > >> Signed-off-by: Haojian Zhuang > > Might be nice to split the removal of the old devices into a separate > patch but that is definitely a win. ?One blocker below, though. > >> + ? ? ? ? ? ? ret = (index < 3) ? (index * 50000 + 1800000) : >> + ? ? ? ? ? ? ? ? ? ? ((index < 7) ? (index * 50000 + 2550000) : >> + ? ? ? ? ? ? ? ? ? ? 3300000); > > I know the previous code did this but I'm really not loving the multiple > ternery operators here for legibility. > >> ? ? ? return 0; >> ?} >> -subsys_initcall(pm8607_regulator_init); >> +module_init(pm8607_regulator_init); > > This should be left at subsys_initcall() to try to ensure that the > regulators are initialsied before the things that use them, otherwise > the handling of init sequencing gets too complex. > Now split this patch into two. Thanks :) Best Regards Haojian -------------- next part -------------- A non-text attachment was scrubbed... Name: 0009-regulator-refresh-88pm8607-driver-with-updated-api.patch Type: text/x-patch Size: 5509 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: 0010-regulator-unsupport-88pm8607-A0-and-A1.patch Type: text/x-patch Size: 9843 bytes Desc: not available URL: