From: haojian.zhuang@gmail.com (Haojian Zhuang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] mfd: enable max8925
Date: Fri, 8 Jan 2010 05:34:45 -0500 [thread overview]
Message-ID: <771cded01001080234h735d2e7dxafeb5c5a952dc218@mail.gmail.com> (raw)
In-Reply-To: <20100108000126.GE11239@sortiz.org>
On Thu, Jan 7, 2010 at 7:01 PM, Samuel Ortiz <sameo@linux.intel.com> wrote:
> Hi Haojian,
>
> On Mon, Dec 21, 2009 at 07:45:27AM -0500, Haojian Zhuang wrote:
>> From 567add422a0d2214e037c3ed1b424b21776dfe34 Mon Sep 17 00:00:00 2001
>> From: Haojian Zhuang <haojian.zhuang@marvell.com>
>> Date: Thu, 17 Dec 2009 12:30:16 -0500
>> Subject: [PATCH] mfd: enable max8925
>>
>> Max8925 is a Power Management IC from Maxim Semiconductor.
>>
>> Do basic support on accessing MAX8925.
> The patch looks quite good to me. I have some minor comments/suggestions
> though:
>
>> ?obj-$(CONFIG_PMIC_DA903X) ? ?+= da903x.o
>> +max8925-objs ? ? ? ? ? ? ? ? := max8925-core.o max8925-i2c.o
>> +obj-$(CONFIG_MFD_MAX8925) ? ?+= max8925.o
> No big deal, but it could just be:
> obj-$(CONFIG_MFD_MAX8925) ? ?+= max8925-core.o max8925-i2c.o
>
I prefer to still use this way. If I write it as your way, it will be
built to max8925-core.ko and max8925-i2c.ko when built as module. I
just want to make it built as max8925.ko.
Others are updated. Since it impacts the second one, I upload both #1
and #2 patches.
Thanks
Haojian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mfd-enable-max8925.patch
Type: text/x-patch
Size: 17867 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100108/25c2178f/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-mfd-add-subdevs-in-max8925.patch
Type: text/x-patch
Size: 9291 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100108/25c2178f/attachment-0003.bin>
next prev parent reply other threads:[~2010-01-08 10:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 12:45 [PATCH 1/4] mfd: enable max8925 Haojian Zhuang
2009-12-22 4:35 ` Simon Horman
2009-12-23 9:41 ` Haojian Zhuang
2009-12-23 10:45 ` Simon Horman
2010-01-08 0:01 ` Samuel Ortiz
2010-01-08 10:34 ` Haojian Zhuang [this message]
2010-01-08 11:45 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=771cded01001080234h735d2e7dxafeb5c5a952dc218@mail.gmail.com \
--to=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).