From: haojian.zhuang@gmail.com (Haojian Zhuang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/01] regulator: support max8649
Date: Tue, 26 Jan 2010 06:54:48 -0500 [thread overview]
Message-ID: <771cded01001260354y7c7db25bqa8bbfe000e0c0380@mail.gmail.com> (raw)
In-Reply-To: <20100126110420.GI15759@rakim.wolfsonmicro.main>
On Tue, Jan 26, 2010 at 6:04 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Jan 26, 2010 at 01:26:08AM -0500, Haojian Zhuang wrote:
>
> This all looks good except...
>
>> +static int max8649_enable_time(struct regulator_dev *rdev)
>> +{
>
> ...
>
>> + ? ? return (voltage / step);
>
> I'd expect the time taken to enable to be the voltage multipled by the
> step size rather than divided by the step size?
>
I don't agree at this point. The unit of step is uV/uSec. The function
should return uSec. So voltage divided by the step is more reasonable.
Others are updated.
Thanks
Haojian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-regulator-enable-max8649-regulator-driver.patch
Type: text/x-patch
Size: 13589 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100126/a97b8c41/attachment.bin>
next prev parent reply other threads:[~2010-01-26 11:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 8:41 [PATCH 01/01] regulator: support max8649 Haojian Zhuang
2010-01-12 8:51 ` Haojian Zhuang
2010-01-12 11:51 ` Mark Brown
2010-01-25 11:01 ` Haojian Zhuang
2010-01-25 13:56 ` Mark Brown
2010-01-26 6:26 ` Haojian Zhuang
2010-01-26 11:01 ` Liam Girdwood
2010-01-26 11:51 ` Haojian Zhuang
2010-01-26 11:04 ` Mark Brown
2010-01-26 11:54 ` Haojian Zhuang [this message]
2010-01-26 12:00 ` Mark Brown
2010-01-26 12:14 ` Haojian Zhuang
2010-01-26 12:41 ` Mark Brown
2010-01-26 16:10 ` Liam Girdwood
2010-03-08 6:28 ` Haojian Zhuang
2010-03-08 8:18 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=771cded01001260354y7c7db25bqa8bbfe000e0c0380@mail.gmail.com \
--to=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).