linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: haojian.zhuang@gmail.com (Haojian Zhuang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] mmp2: add handling on PMIC IRQ
Date: Wed, 3 Feb 2010 02:21:43 -0500	[thread overview]
Message-ID: <771cded01002022321k2897ca97j85701e39f8f5fac9@mail.gmail.com> (raw)
In-Reply-To: <771cded01002022231k5c02110ak75aee6a96d8746ac@mail.gmail.com>

On Wed, Feb 3, 2010 at 1:31 AM, Haojian Zhuang <haojian.zhuang@gmail.com> wrote:
> On Tue, Feb 2, 2010 at 7:14 PM, Eric Miao <eric.y.miao@gmail.com> wrote:
>> I don't think this is probably the right way to go. There could be two
>> improvements:
>>
>> 1. move mfpr register manipulation into a dedicated function, e.g.
>> ? ?mmp2_clear_pmic_int() within mmp2.c
>>
>> 2. invent a pmic_mask_ack_irq() to replace the default one at
>> ? run-time, so to save the time that every 2nd level interrupt
>> ? handling has to go through the if (.... == IRQ_MMP2_PMIC) thing,
>> ? provided it does look like an ack operation to me.
>>
>
> Update this patch. The fix is in below.
> 1. add mmp2_clear_pmic_int()
> 2. append pmic_irq_demux2() for handling PMIC irq.
>
> Thanks
> Haojian
>

Update the patch. The fix is in below.
1. add pmic_irq_ack().
2. remove mask_ack() in irq_chip. Since we have some special ack() to do.

Thanks
Haojian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mmp2-add-handling-on-PMIC-IRQ.patch
Type: text/x-patch
Size: 3012 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100203/ea681240/attachment.bin>

  reply	other threads:[~2010-02-03  7:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27  6:08 [PATCH 1/1] mmp2: add handling on PMIC IRQ Haojian Zhuang
2010-02-03  0:14 ` Eric Miao
2010-02-03  6:31   ` Haojian Zhuang
2010-02-03  7:21     ` Haojian Zhuang [this message]
2010-02-03  7:42       ` Eric Miao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=771cded01002022321k2897ca97j85701e39f8f5fac9@mail.gmail.com \
    --to=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).