From: "André Almeida" <andrealmeid@igalia.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Christian Brauner <brauner@kernel.org>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
kernel-dev@igalia.com,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-alpha@vger.kernel.org, linux-s390@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-arm-kernel@lists.infradead.org, soc@lists.linux.dev,
linux-mips@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v7 03/13] scripts/syscall.tbl: Use the common table
Date: Fri, 18 Sep 2026 16:58:50 -0300 [thread overview]
Message-ID: <77321b17-c533-4287-9b05-98003959da70@igalia.com> (raw)
In-Reply-To: <6cd76fb4-0834-457c-8188-c68a507b6a6f@app.fastmail.com>
Em 18/09/2026 03:34, Arnd Bergmann escreveu:
> On Fri, Sep 18, 2026, at 01:46, André Almeida wrote:
>> Remove some of the duplicated code by using the common syscall number
>> table.
>>
>> Signed-off-by: André Almeida <andrealmeid@igalia.com>
>> ---
>> arch/arm64/tools/syscall_32.tbl | 69 -----------------------------------------
>> scripts/Makefile.asm-headers | 15 ++++-----
>> scripts/syscall.tbl | 69 -----------------------------------------
>> 3 files changed, 8 insertions(+), 145 deletions(-)
>
> This somewhat desyncs the two copies of the arm32 table, which
> isn't great.
>
>> diff --git a/scripts/Makefile.asm-headers b/scripts/Makefile.asm-headers
>> index f1c3d287c14b..b09dbc8992c3 100644
>> --- a/scripts/Makefile.asm-headers
>> +++ b/scripts/Makefile.asm-headers
>> @@ -15,9 +15,10 @@ all:
>>
>> src := $(srctree)/$(subst /generated,,$(obj))
>>
>> -syscall_abis_32 += common,32
>> -syscall_abis_64 += common,64
>> +syscall_abis_32 += clone3,common,32
>> +syscall_abis_64 += clone3,common,64
>
> The clone3 variant is wrong on nios2 and openrisc, as they need the
> __clone3 version. These currently redirect it using a macro from
> syscall_table.c doing
>
> #define sys_clone3 __sys_clone3
>
> which will continue to work here, but I don't like how this is
> inconsistent between the architectures. Let's use either
> syscall_abis_* or a macro to pick the clone3 variant on
> all architectures, but not both.
>
Ok, I have dropped the sys_clone3 macro and added clone3/__clone3 for
the all archs that uses scripts/syscall.tbl for the next patch revision.
next prev parent reply other threads:[~2026-09-18 19:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 23:46 [PATCH v7 00/13] syscalls: Add a shared table for all archs André Almeida
2026-09-17 23:46 ` [PATCH v7 01/13] syscalls: Make --abis parsing more robust André Almeida
2026-09-17 23:46 ` [PATCH v7 02/13] syscalls: Create unified partial table for all archs André Almeida
2026-09-17 23:46 ` [PATCH v7 03/13] scripts/syscall.tbl: Use the common table André Almeida
2026-09-18 6:34 ` Arnd Bergmann
2026-09-18 19:58 ` André Almeida [this message]
2026-09-17 23:46 ` [PATCH v7 04/13] arm: Use the common syscall table André Almeida
2026-09-18 6:22 ` Arnd Bergmann
2026-09-18 20:10 ` André Almeida
2026-09-17 23:46 ` [PATCH v7 05/13] s390: " André Almeida
2026-09-17 23:46 ` [PATCH v7 06/13] sparc: " André Almeida
2026-09-17 23:46 ` [PATCH v7 07/13] mips: Remove duplicated syscallnr.sh André Almeida
2026-09-17 23:46 ` [PATCH v7 08/13] mips: Get rid of custom mips ABIs for syscall tables André Almeida
2026-09-17 23:46 ` [PATCH v7 09/13] mips: Use the common syscall table André Almeida
2026-09-18 6:56 ` Arnd Bergmann
2026-09-17 23:46 ` [PATCH v7 10/13] syscalls: Add an option for offsetting the common table André Almeida
2026-09-17 23:46 ` [PATCH v7 11/13] alpha: Define entry point for set_mempolicy_home_node syscall André Almeida
2026-09-18 11:36 ` Magnus Lindholm
2026-09-17 23:46 ` [PATCH v7 12/13] alpha: Remove alpha_ prefix from custom syscall entries André Almeida
2026-09-18 10:54 ` Magnus Lindholm
2026-09-18 20:11 ` André Almeida
2026-09-17 23:46 ` [PATCH v7 13/13] alpha: Use the common syscall table André Almeida
2026-09-18 10:57 ` Magnus Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77321b17-c533-4287-9b05-98003959da70@igalia.com \
--to=andrealmeid@igalia.com \
--cc=arnd@arndb.de \
--cc=brauner@kernel.org \
--cc=kernel-dev@igalia.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=soc@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox