From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: keystone: add bus notifier to set dma_pfn_offset for pci devices
Date: Fri, 10 Oct 2014 20:22:07 +0200 [thread overview]
Message-ID: <7733803.LRHUrkheId@wuerfel> (raw)
In-Reply-To: <1412954137-4567-1-git-send-email-m-karicheri2@ti.com>
On Friday 10 October 2014 11:15:37 Murali Karicheri wrote:
> @@ -54,6 +55,8 @@ static void __init keystone_init(void)
> keystone_pm_runtime_init();
> if (platform_nb.notifier_call)
> bus_register_notifier(&platform_bus_type, &platform_nb);
> + if (platform_nb.notifier_call)
> + bus_register_notifier(&pci_bus_type, &platform_nb);
> of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
>
No, this looks very wrong. Santosh spent an enormous effort on obsoleting
the platform notifier block by adding the range parser to the platform
device probe path.
You should really remove platform_nb and all associated code rather than
adding more code to it.
NAK
Arnd
next prev parent reply other threads:[~2014-10-10 18:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 15:15 [PATCH] ARM: keystone: add bus notifier to set dma_pfn_offset for pci devices Murali Karicheri
2014-10-10 15:29 ` Santosh Shilimkar
2014-10-10 15:42 ` Russell King - ARM Linux
2014-10-10 15:46 ` Santosh Shilimkar
2014-10-10 15:53 ` Murali Karicheri
2014-10-10 18:22 ` Arnd Bergmann [this message]
2014-10-10 21:37 ` Murali Karicheri
2014-10-11 0:04 ` Santosh Shilimkar
2014-10-11 20:37 ` Arnd Bergmann
2014-10-13 14:13 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7733803.LRHUrkheId@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox