From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E319C197BF for ; Thu, 27 Feb 2025 23:05:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:Cc:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QxAcpt0+lW01/ig2J6vWiepSryvmGyljQIhYNOU2c/8=; b=kOfLeMj+pxMJqn8VtcacBas/5L 10DHSbBV/NJXC/vh7brfem4pfylSqqdMfz14aB4GrvsWTN7ld/iY39Xu5NmH+sjb83qIcAh1IJqZz zAefWI1gDtfwI7owC6tDda12HIw2mree3KppOii1/bXTRDpWRUbAKWQkwWaVVojVppMHLqIMfHyXD nLHl7QYokYj+RPWjoIF1nPK5K/xrGZNDUKiZN5eAUQuVwH3eHsaKqoBOTAwVBHxiX6e3kR3ZzyPpS TEPtphlFfYIZ/Jg89FuUL4btb+t2nUkh/tDQi2FEAEEJfzbTlvfamvCZqhdGSXy4hhHtO5HHo2Mmi +PVz20zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnmwB-000000096zJ-2epP; Thu, 27 Feb 2025 23:05:03 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnmuc-000000096iP-3dLi for linux-arm-kernel@lists.infradead.org; Thu, 27 Feb 2025 23:03:28 +0000 Received: from [192.168.35.166] (c-24-22-154-137.hsd1.wa.comcast.net [24.22.154.137]) by linux.microsoft.com (Postfix) with ESMTPSA id B7CFE210EAC1; Thu, 27 Feb 2025 15:03:23 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B7CFE210EAC1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1740697404; bh=QxAcpt0+lW01/ig2J6vWiepSryvmGyljQIhYNOU2c/8=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=bxzf0KSsUaGf0Nytx/thMSUWtHwHn5I/IWuc30R4oUpVESsi59QYzve8DdAojqVeS wh7oR5+oq6vJ3pbCm3dM9Bi11DroQv/1tvRSdzmVSbBJ8Q4ubfxZcaWgDCwnVAWAyB SVRIH/V8d2vZzi2MEtzdxJG4TulbapRL5gkG36N8= Message-ID: <7749367d-d87d-43f0-8c24-cd08bb4ce1a8@linux.microsoft.com> Date: Thu, 27 Feb 2025 15:03:22 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: linux-hyperv@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-acpi@vger.kernel.org, eahariha@linux.microsoft.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, mhklinux@outlook.com, decui@microsoft.com, catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, daniel.lezcano@linaro.org, joro@8bytes.org, robin.murphy@arm.com, arnd@arndb.de, jinankjain@linux.microsoft.com, muminulrussell@gmail.com, skinsburskii@linux.microsoft.com, mrathor@linux.microsoft.com, ssengar@linux.microsoft.com, apais@linux.microsoft.com, Tianyu.Lan@microsoft.com, stanislav.kinsburskiy@gmail.com, gregkh@linuxfoundation.org, vkuznets@redhat.com, prapal@linux.microsoft.com, muislam@microsoft.com, anrayabh@linux.microsoft.com, rafael@kernel.org, lenb@kernel.org, corbet@lwn.net Subject: Re: [PATCH v5 04/10] hyperv: Introduce hv_recommend_using_aeoi() To: Nuno Das Neves References: <1740611284-27506-1-git-send-email-nunodasneves@linux.microsoft.com> <1740611284-27506-5-git-send-email-nunodasneves@linux.microsoft.com> From: Easwar Hariharan Content-Language: en-US In-Reply-To: <1740611284-27506-5-git-send-email-nunodasneves@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250227_150326_930956_6E407D89 X-CRM114-Status: GOOD ( 14.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/26/2025 3:07 PM, Nuno Das Neves wrote: > Factor out the check for enabling auto eoi, to be reused in root > partition code. > > Signed-off-by: Nuno Das Neves > --- > drivers/hv/hv.c | 12 +----------- > include/asm-generic/mshyperv.h | 13 +++++++++++++ > 2 files changed, 14 insertions(+), 11 deletions(-) > > diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyperv.h > index 258034dfd829..1f46d19a16aa 100644 > --- a/include/asm-generic/mshyperv.h > +++ b/include/asm-generic/mshyperv.h > @@ -77,6 +77,19 @@ extern u64 hv_do_fast_hypercall16(u16 control, u64 input1, u64 input2); > bool hv_isolation_type_snp(void); > bool hv_isolation_type_tdx(void); > > +/* > + * On architectures where Hyper-V doesn't support AEOI (e.g., ARM64), > + * it doesn't provide a recommendation flag and AEOI must be disabled. > + */ > +static inline bool hv_recommend_using_aeoi(void) > +{ > +#ifdef HV_DEPRECATING_AEOI_RECOMMENDED > + return !(ms_hyperv.hints & HV_DEPRECATING_AEOI_RECOMMENDED); > +#else > + return false; > +#endif > +} > + I must be missing something very basic here, and if so, I apologize, and please enlighten me. HV_DEPRECATING_AEOI_RECOMMENDED is defined as BIT(9) in include/hyperv/hvgdk_mini.h, and asm-generic/mshyperv.h includes that via include/hyperv/hvhdk.h. If this is the case, when would HV_DEPRECATING_AEOI_RECOMMENDED ever be not defined? If it's always defined, do we need the #ifdef? Thanks, Easwar (he/him)