From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/9] dmaengine: edma: Use enum for eDMA binding type (legacy vs TPCC)
Date: Wed, 21 Sep 2016 12:31:52 +0200 [thread overview]
Message-ID: <7753810.Z3F41qkFaI@wuerfel> (raw)
In-Reply-To: <20160921102637.24845-3-peter.ujfalusi@ti.com>
On Wednesday, September 21, 2016 1:26:30 PM CEST Peter Ujfalusi wrote:
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index c2098a4b4dcf..4c8818278fcc 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -261,8 +261,11 @@ static const struct edmacc_param dummy_paramset = {
> .ccnt = 1,
> };
>
> -#define EDMA_BINDING_LEGACY 0
> -#define EDMA_BINDING_TPCC 1
> +enum edma_binding_type {
> + EDMA_BINDING_LEGACY = 0,
> + EDMA_BINDING_TPCC,
> +};
> +
> static const struct of_device_id edma_of_ids[] = {
> {
> .compatible = "ti,edma3",
> @@ -2184,7 +2187,8 @@ static int edma_probe(struct platform_device *pdev)
> const struct of_device_id *match;
>
> match = of_match_node(edma_of_ids, node);
> - if (match && (u32)match->data == EDMA_BINDING_TPCC)
> + if (match &&
> + (enum edma_binding_type)match->data == EDMA_BINDING_TPCC)
> legacy_mode = false;
>
> info = edma_setup_info_from_dt(dev, legacy_mode);
> --
> 2.10.0
>
Are you sure this works on all architectures? IIRC the size of an enum
is implementation defined, so this could still fail sometimes.
I tend to use 'uintptr_t' for the cast instead.
Arnd
next prev parent reply other threads:[~2016-09-21 10:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 10:26 [PATCH v2 0/9] dmaengine: ti drivers: enable COMPILE_TESTing Peter Ujfalusi
2016-09-21 10:26 ` [PATCH v2 1/9] dmaengine: edma: Add missing MODULE_DEVICE_TABLE() for of_device_id structs Peter Ujfalusi
2016-09-21 10:26 ` [PATCH v2 2/9] dmaengine: edma: Use enum for eDMA binding type (legacy vs TPCC) Peter Ujfalusi
2016-09-21 10:31 ` Arnd Bergmann [this message]
2016-09-21 11:07 ` Peter Ujfalusi
2016-09-21 11:38 ` Arnd Bergmann
2016-09-21 10:26 ` [PATCH v2 3/9] dmaengine: edma: Use correct type for of_find_property() third parameter Peter Ujfalusi
2016-09-21 10:26 ` [PATCH v2 4/9] dmaengine/ARM: omap-dma: Fix the DMAengine compile test on non OMAP configs Peter Ujfalusi
2016-09-21 10:26 ` [PATCH v2 5/9] dmaengine: ti-dma-crossbar: Correct type for of_find_property() third parameter Peter Ujfalusi
2016-09-21 10:26 ` [PATCH v2 6/9] dmaengine: ti-dma-crossbar: Use enum for crossbar type Peter Ujfalusi
2016-09-21 10:26 ` [PATCH v2 7/9] dmaengine: edma: enable COMPILE_TEST Peter Ujfalusi
2016-09-21 10:26 ` [PATCH v2 8/9] dmaengine: omap-dma: " Peter Ujfalusi
2016-09-21 10:26 ` [PATCH v2 9/9] dmaengine: ti-dma-crossbar: " Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7753810.Z3F41qkFaI@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox