Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: defconfig: qcom: add APQ8060 DragonBoard devices
Date: Wed, 11 Jan 2017 15:08:08 +0100	[thread overview]
Message-ID: <7762461.Mcpxx0AiPM@wuerfel> (raw)
In-Reply-To: <CACRpkdb+bH1bj14d-2rBMadJQLCdVgdeuc07ESkuQpWt9UQ6rg@mail.gmail.com>

On Wednesday, January 11, 2017 2:19:55 PM CET Linus Walleij wrote:
> On Tue, Jan 10, 2017 at 3:53 PM, Andy Gross <andy.gross@linaro.org> wrote:
> > On Tue, Jan 10, 2017 at 10:55:21AM +0100, Linus Walleij wrote:
> >> This default-enables the devices found on the APQ8060 DragonBoard
> >> in the qcom_defconfig:
> >>
> >> - EBI2 bus
> >> - SMSC911x ethernet
> >> - LEDs class and PM8058 LEDs driver, trigger and heartbeat
> >>   trigger (so we get heartbeat on the board by default)
> >> - IIO framework, including the HRTimer trigger, KXSD9
> >>   accelerometer, MPU3050 gyroscope, AK8975 magnetometer and
> >>   BMP085 pressure sensor
> >>
> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > This brings up a point of discussion.  Do we even need the qcom_defconfig any
> > more?  Is everyone comfortable with using the multi_v7_defconfig?

I think having one specialized defconfig for the platform is helpful for
the build/boot testing, e.g. it can show whether a boot failure with
multi_v7_defconfig is the result of a qcom-specific change, or a side-effect
of something that was done on another platform.

> > Aside from size of the image, i can't think of any other reason to keep around
> > the separate qcom file.
> 
> Actually a bit of Arnd/Olof question.
> 
> Bystander opinion below:
> 
> That is pretty much up to the maintainer (you) I guess.
> Reasons would be:
> 
> - Lower footprint (because you may not need all stuff selected
>   as 'y' compiled-in in multi_v7) on some platforms this is even
>   necessary to get a bootable image or one that will load in
>   reasonable time.
> 
> - Enable a few things by default (both compiled-in and modules)
>   that multi_v7 would consider to be littering
> 
> - For "my" systems I usually like them because these defconfigs
>   have vastly shorter compile time (because so much stuff that
>   idon't concern me is left out).
> 
> On the other hand: some ARMv7 system maintainers have x86
> ambitions: compile once, run everywhere, and certainly that is
> the ambition with multi_v7, and if that overshadows all the above,
> just kill off qcom_defconfig and be happy :)

We recently killed of the Broadcom defconfig file that actually
contained some very different platforms that had not much in common
besides the company name.

I think my preference is to keep it, but if Andy wants it removed
and nobody complains, that's fine too.

	Arnd

  reply	other threads:[~2017-01-11 14:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10  9:55 [PATCH] ARM: defconfig: qcom: add APQ8060 DragonBoard devices Linus Walleij
2017-01-10 14:53 ` Andy Gross
2017-01-11 13:19   ` Linus Walleij
2017-01-11 14:08     ` Arnd Bergmann [this message]
2017-01-11 14:11       ` Neil Armstrong
2017-01-11 16:03         ` Andy Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7762461.Mcpxx0AiPM@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox