[PATCH v5 00/14] ARM: samsung-time: Prepare for multiplatform support

Heiko Stübner
2013-04-12T22:39:24Z

Am Samstag, 13. April 2013, 00:26:43 schrieb Arnd Bergmann:
> On Saturday 13 April 2013 00:22:48 Heiko St?bner wrote:
> > Without dt support, you get this:
> > CC drivers/clocksource/samsung_pwm.o
> >
> > drivers/clocksource/samsung_pwm.c:620: warning:
> > ?samsung_pwm_clocksource_init_of? defined but not used
> >
> > So, something like the following might be necessary
>
> That patch should not be required any more with the definition
>
> #ifdef CONFIG_CLKSRC_OF
> extern void clocksource_of_init(void);
>
> #define CLOCKSOURCE_OF_DECLARE(name, compat, fn) \
> static const struct of_device_id __clksrc_of_table_##name \
> __used __section(__clksrc_of_table) \
> = { .compatible = compat, \
> .data = (fn == (clocksource_of_init_fn)NULL) ? fn : fn
> } #else
> static inline void clocksource_of_init(void) {}
> #define CLOCKSOURCE_OF_DECLARE(name, compat, fn) \
> static const struct of_device_id __clksrc_of_table_##name \
> __attribute__((unused)) \
> = { .compatible = compat, \
> .data = (fn == (clocksource_of_init_fn)NULL) ? fn : fn
> } #endif
>
> which turns the ?samsung_pwm_clocksource_init_of? function into an unused
> symbol that gets silently dropped by gcc, at least in theory. Are you
> using the latest clksrc/cleanup branch as a base?

Nope, I just put the stuff on top of all the other changes. So it seems
everything is fine and working ... very nice :-)

Heiko