From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C584C3F6B0 for ; Wed, 24 Aug 2022 20:37:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WTS1HS6jgT8DjP8uakhmnbgiHkEl+IP3FslKQ29Gqc8=; b=14G7wChHXYN3g3 lEYXMtTmNxAMyv1+odd/ak6igx/qqfzePq/0KTfybqs1TYsdZdQcST8TCGYhkgCOpdi0TABXnCtQA zq3oZlc20w7+6RfWX3p/Nqke57onU7yjXwy18et2x5BVD60DzBV3wPT3jVmveLOUt7IqqNfHeli3L j330iYFbX15l+O+0YUdfIGer8GpOSGBpLacENRmmyvW25/394WSGKu6GiIez5nEcn6sgJ51hTgBLw c5B27ONhTy9ib0P4h66I/uzMRhshFqjiBPPBwVzRyyzwSmllW7JZDyJrqKiQ7EKJNEClL8pPksAWX BqjWycr1FKL4rNNOJ+IA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQx7B-00GfCR-61; Wed, 24 Aug 2022 20:36:41 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQx75-00Gf8n-Q3 for linux-arm-kernel@lists.infradead.org; Wed, 24 Aug 2022 20:36:37 +0000 Received: by mail-wm1-x32c.google.com with SMTP id h1so9282429wmd.3 for ; Wed, 24 Aug 2022 13:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=PHwTuCnEL7EtB2rU0ZKm2AoGKO0cbH9wf0XuAB8In50=; b=jS0OlYQI0Zplep4Ed4lMnqtdkDh40PLTcf6EeIDIlwiNXwTOKErL+p8HbdM2fk5Ckn l5eZIkjVtiWgcadwvtz/U6auUIRNobBA97as2BuE8E0gG3ojYAXRpd3o3lx5cqJssTfs spVaPDijVyq6UD2hvgGdM3DE7RKbZjoWn04mzcKt/V5qVyFgBdJxwn4XRlKCa98OHIDO FMdRHHVnlNdO/fUO/r84C++gHF1WwO4J4tTiaOUbAzSsqRkU6nq6RRK450r6vNgEGR3J 3smItmJjxekSn/7b+Nf1JAGA5h5jxbLZqk36Wo4QEX3OL2EPFHtBANMtpMVXUuPyheuw VR1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=PHwTuCnEL7EtB2rU0ZKm2AoGKO0cbH9wf0XuAB8In50=; b=H1NiTIFBU6aOlPBI7lqVp8zjfrPkW4Z0Tv4fs66bNntz8UvqGbdi6tQgdnf0HGQhlc o3eLU82vxau5+XoL6wLhx1PWQ03i9dg9TnNXGo/5R77ApGpvIMt7AOq9ql5LjLardgHw arfdmc6JfJd+W1PeNN9ljK5fW2DVrH7J46mHTnVPNuEigjzRVDhGliZSD8fVdWqbSXic uIRXUm5mAuXrYvAwAHgYI2pqhERQRnbX4hoOtTsFlmsKnXlLJFSIIQFFqHQE0fLQY+LF Kx1jTkqNPttKwzXidBXVY4Wpoh2nSbwdMvyIxZyPKzz8swb40VOis7q5ot9XGy6rOMlb JIMA== X-Gm-Message-State: ACgBeo1CFRLFD3XnI4VOfjO7lFHOH23r0knm/U47L5xE+b53PUqBRyvH cYXyI8duskSzMdyNlW/8nZE= X-Google-Smtp-Source: AA6agR7iDVcDClHA4R60UnKf6VHm8MI5AZ7TR4qlLMkKRcInxtkl24wT3rFQ9Rjrr/7DSPqxBkZPew== X-Received: by 2002:a05:600c:3b92:b0:3a6:8d6:9a2f with SMTP id n18-20020a05600c3b9200b003a608d69a2fmr6342451wms.159.1661373393818; Wed, 24 Aug 2022 13:36:33 -0700 (PDT) Received: from ?IPV6:2a01:c22:7aa2:100:8857:e17a:56:c2b2? (dynamic-2a01-0c22-7aa2-0100-8857-e17a-0056-c2b2.c22.pool.telefonica.de. [2a01:c22:7aa2:100:8857:e17a:56:c2b2]) by smtp.googlemail.com with ESMTPSA id bh19-20020a05600c3d1300b003a54d610e5fsm3168381wmb.26.2022.08.24.13.36.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Aug 2022 13:36:33 -0700 (PDT) Message-ID: <776ece87-e24c-bb19-e472-8a04d1cbbaa3@gmail.com> Date: Wed, 24 Aug 2022 22:36:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH net] net: stmmac: work around sporadic tx issue on link-up Content-Language: en-US To: Jakub Kicinski Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , "netdev@vger.kernel.org" , "moderated list:ARM/STM32 ARCHITECTURE" , "linux-arm-kernel@lists.infradead.org" , Qi Duan , Da Xue , Jerome Brunet References: <72755b6b-f071-1c54-c2fd-5ea0376effe1@gmail.com> <20220823162259.36401af0@kernel.org> From: Heiner Kallweit In-Reply-To: <20220823162259.36401af0@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220824_133636_536939_20FFE625 X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24.08.2022 01:22, Jakub Kicinski wrote: > On Sat, 20 Aug 2022 17:20:37 +0200 Heiner Kallweit wrote: >> This is a follow-up to the discussion in [0]. It seems to me that >> at least the IP version used on Amlogic SoC's sometimes has a problem >> if register MAC_CTRL_REG is written whilst the chip is still processing >> a previous write. But that's just a guess. >> Adding a delay between two writes to this register helps, but we can >> also simply omit the offending second write. This patch uses the second >> approach and is based on a suggestion from Qi Duan. >> Benefit of this approach is that we can save few register writes, also >> on not affected chip versions. >> >> This patch doesn't apply cleanly before the commit marked as fixed. >> There's nothing wrong with this commit. > > I don't think this is right, please do your best to identify where > the bug was actually introduced and put that in the Fixes tag. > > IIRC this is not the first time you've made this choice so let's > sort this out, we can bring it up with Greg if you would like, > I don't see it clarified in the docs. > > My understanding and experience doing backports for my employer is > that cutting off the Fixes tag at the place patch application fails > is very counter productive. Better to go too far back and let > the person maintaining the tree decide if the backport is needed. > OK, I changed the Fixes tag accordingly and submitted a v2. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel