From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 01/10] arm: mvebu: fix vendor prefix typo in kirkwood-synology.dtsi
Date: Thu, 20 Nov 2014 08:35:43 +0100 [thread overview]
Message-ID: <7770322.bXz9M2IL1d@wuerfel> (raw)
In-Reply-To: <20141120050213.GB2596@lunn.ch>
On Thursday 20 November 2014 06:02:13 Andrew Lunn wrote:
> On Wed, Nov 19, 2014 at 08:55:19PM -0500, Jason Cooper wrote:
> > Andrew,
> >
> > On Wed, Nov 19, 2014 at 12:01:36AM +0100, Arnaud Ebalard wrote:
> > >
> > > As reported by Andrew, the vendor prefix for Seiko Instruments, Inc.
> > > S-35390A I2C RTC chip in kirkwood-synology.dtsi has a typo (ssi
> > > instead of sii). This patches fixes it.
> > >
> > > Reported-by: Andrew Lunn <andrew@lunn.ch>
> > > Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
> > > ---
> > > arch/arm/boot/dts/kirkwood-synology.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/kirkwood-synology.dtsi b/arch/arm/boot/dts/kirkwood-synology.dtsi
> > > index 811e0971fc58..8be5b2e4626e 100644
> > > --- a/arch/arm/boot/dts/kirkwood-synology.dtsi
> > > +++ b/arch/arm/boot/dts/kirkwood-synology.dtsi
> > > @@ -266,7 +266,7 @@
> > >
> > > s35390a: s35390a at 30 {
> > > status = "disabled";
> > > - compatible = "ssi,s35390a";
> > > + compatible = "sii,s35390a";
> >
> > Should the driver now support both variants for backward compatibility?
>
> Hi Jason
>
> This is an i2c device. i2c totally ignores the vendor. It is optional.
> So there is no backward compatibility issues.
>
This question keeps coming up, so I'd suggest explaining it in the
patch changelog.
Arnd
next prev parent reply other threads:[~2014-11-20 7:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 23:01 [PATCHv4 00/10] arm: mvebu: add Synology DS213j and DS414 .dts files Arnaud Ebalard
2014-11-18 23:01 ` [PATCHv4 01/10] arm: mvebu: fix vendor prefix typo in kirkwood-synology.dtsi Arnaud Ebalard
2014-11-20 1:55 ` Jason Cooper
2014-11-20 5:02 ` Andrew Lunn
2014-11-20 7:35 ` Arnd Bergmann [this message]
2014-11-20 8:28 ` Arnaud Ebalard
2014-11-21 20:24 ` Jason Cooper
2014-11-18 23:01 ` [PATCHv4 02/10] arm: mvebu: add uartX labels for Armada SoC serial nodes Arnaud Ebalard
2014-11-19 12:16 ` Thomas Petazzoni
2014-11-18 23:01 ` [PATCHv4 03/10] arm: mvebu: use recently introduced uart label for stdout-path Arnaud Ebalard
2014-11-19 12:16 ` Thomas Petazzoni
2014-11-18 23:02 ` [PATCHv4 04/10] arm: mvebu: move Armada 370/XP pinctrl node definition armada-370-xp.dtsi Arnaud Ebalard
2014-11-19 8:03 ` Uwe Kleine-König
2014-11-19 8:35 ` Arnaud Ebalard
2014-11-18 23:02 ` [PATCHv4 05/10] arm: mvebu: define and use common Armada 370 SPI pinctrl settings Arnaud Ebalard
2014-11-18 23:02 ` [PATCHv4 06/10] arm: mvebu: define and use common Armada 370 UART " Arnaud Ebalard
2014-11-18 23:02 ` [PATCHv4 07/10] arm: mvebu: define and use common Armada XP UART2/3 " Arnaud Ebalard
2014-11-18 23:02 ` [PATCHv4 08/10] arm: mvebu: define and use common Armada XP SPI pinctrl setting Arnaud Ebalard
2014-11-18 23:02 ` [PATCHv4 09/10] arm: mvebu: add .dts file for Synology DS213j Arnaud Ebalard
2014-11-18 23:03 ` [PATCHv4 10/10] arm: mvebu: add .dts file for Synology DS414 Arnaud Ebalard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7770322.bXz9M2IL1d@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox