Re: [PATCH v7 00/27] drm: sun4i: add Display Engine 3.3 (DE33) support

Ryan Walklin
2025-02-22T23:28:39Z

On Sat, 22 Feb 2025, at 10:28 PM, Jernej Škrabec wrote:
> Sorry, completely forgot. YUV420 HDMI code relies on my previous work,
> with which
> Maxime wasn't happy with:
>
> https://lore.kernel.org/linux-sunxi/20230924192604.3262187-1-jernej.skrabec@gmail.com/
>
> So unless switching HDMI to bridge ops is implemented, which also
> brings format,
> YUV formatter and some other patches just add unused code, which isn't
> ideal,
> especially if we decide to rework driver before that code can be put in
> acceptable
> state for all involved.
>
> From quick look, patches 5-13, 26 should be dropped for now. Not sure about 1-4.
>
> I'm fine with AFBC support going in, it's just one patch.

Makes sense, ok I will prepare a pure DE33 patch with AFBC and RGB support, removing the YUV code. I think the CSC changes (1-4) are good to stay as it is a change that makes sense regardless and makes the YUV work a bit easier.

Thanks for the other clarifications and vendor code links, will do a bit of reading.

Regards,

Ryan