From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF8C4606A321 for ; Mon, 9 Nov 2026 12:52:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=m0c3Jr0D; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=s1/8ZF+r DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=+tF8l8wiFwVnoygmXpYnREIWubWMOLu/o49/XwgRJmA=; b=m0c3Jr0DQXHzdD 8qGPLrEk35vTYMWOikD+Q5BuDKQh4rvwdl1haU9zcBLTNL8b/ptfKdWTlfmf3Xkc9/oxdIdBYd6GV 8Ti/BKDGIlqbSwski/DBzWCNkDBH0/HlP26YxG79xufTnx/jfmAzgXsPSQ7NsYEzSU6My2ZiaqJ1+ BsQR//mktPXGT1zIgemKjK6LlRmyRerwqqXIz1EGiOaSOQTa+6ub2UxBQmEBgxdDotVCcOHf5cneR 4WkkJK7vLGiHmeHJ/sjmSQa6aSS9wu8rB3KiWW4PPHqZ2uCahfkwHD2V2CSPkaQ1HRzKQKMpSumsB mmGjveb2W4kDeOYaR4VQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQOPR-00000000ekH-3eGq; Mon, 09 Nov 2026 12:23:37 +0000 Received: from mail-pj2-x0a.google.com ([2607:f8b0:4864:39::a]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQOPO-00000000eiN-3kGQ for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2026 12:23:36 +0000 Received: by mail-pj2-x0a.google.com with SMTP id d9443c01a7336-2eb0c699769so3223195ad.1 for ; Mon, 09 Nov 2026 04:23:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794227013; x=1794831813; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=+tF8l8wiFwVnoygmXpYnREIWubWMOLu/o49/XwgRJmA=; b=s1/8ZF+rku/nbUQA4Vtv3yXg3ca1JWEjXuAyei1ZINXXpj5p100JciKUXSZo2cven0 GJrvDgzxa4BJn0FtwnE7wyJzGtu/kafusHDpx7dTt2mTzMI2AT6W4U58qKUhIPjS0tYP /GWBGTXXlnn7SEzoBFZRPSgRfH3dvNX0NfIna1hFS7T3sMxm80yoTwSsUiJLJ9ghD27l oEGXqI/Z4dP3yd+Ki1FSRsCsGk7R7/d5V3/O/RWwRCkDMwditUxM2HRoK+K+39b3ktCl OtwZwXm2jSHI9iaK+P4L3HMqq7D2wcQ/IvtN98ZLYYdZ5axySlTznzfYg5E6GAmUhA+L pEPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794227013; x=1794831813; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+tF8l8wiFwVnoygmXpYnREIWubWMOLu/o49/XwgRJmA=; b=q3Wc0rQi3Av4z7MbtVgRmn2O5LgRRGniA8jylBWXpaRUTMeo4fGjY7TkyeX2zxmzdu 7xZgTexj6osnYuTsHHKFIl8tH3dcCKpOoy0dudvwGeePpFDT0AO4NlFiU/O2alVWWtML yOWp+B1gpu48MajzElGF/Spwwbm9ZGUtyXH+YCP05biAWPFBSvsDBwGZsn9ezun/sxe+ 4cBnH/a4eAUysPLw6Y+LeJBUxAqXZN8IbUh1plXhiFGIrzP0EMGrYEtoB4YbKtNwjWTC qulpW8qxBi5tJtMGJT6YFY6UvhrYKM2/gIwbYZgokKz9fpf4vtakI44Uk6n0zqym5dGj b3kQ== X-Forwarded-Encrypted: i=1; AL+hErFutycvzXwYxyIEFZgb1WztXIida+hpYK4JsBH5hKXmWApe14NHmHUg1YHBcShUVUvKPPBYhnEzTYgLinLvZN0X@lists.infradead.org X-Gm-Message-State: APuU4Z9QIKuc2d+atvZDNzYK+M0WdP8L7o+5AMTOWQNsQmpDN6gW8W/K wkfeP1AVitEKPjev4E1JiGW1xRsdEdx3sd8z/Xy2l2qFGell8jb0+UeV X-Gm-Gg: AYBFou2EINj9CbQMaloapKME8cE52WyFlcRPhE2cGWB2CyE367huGgYqbQKcGr8Le8R oVDQ7TS7j1kn51dzZMwcBqBDZCKSOPfn3pEFmGWmdYrov+zZcYFhZRKBUDguIutxQHJ2A6s0q03 Mt1fjimkbA+kBOAuxU6lw+Ut5A2gs6SoJwm37LJdc3VPk4RzJGwX5n/pJXwDSpXZd2Y5FzPBRLU ZRHdPdfoGFxr8dUw2cmEn0PxGBrzizGEY5Qjh69D3U1Tc5ZCONmJQZST4UK3w8z/uSK8e7dI3id N/2Mtp464qOWPmQZ2kaQItNtz6mnOs9n64b41IhEObjriN+HIUjt8hWAkdumUPmjdSancRZ8tF6 E+hyfAR7J9aUiW0Fa4zYtSXAT98E3jEFdgDWSdJFp//y+eIpo/+Yby7/lj2h5RJLCLkBfZ21CpC MwVHE0jFAXlepARPe4dRGBF3VnOSZsgoXtTuT2XZSrvNqlRVL5qkw3ONvHEoUtZ9axD49c81A8u TvzXYzpwoY5d60HUqkzOACIruAf4mWAG26Lj/f/P20jfN+x3bqTDITpC5FOT2uqvbBxBtAatxsQ 8iXdEBm/GkOuuFjv5ANLoDy4q/8uJkWKjGU= X-Received: by 2002:a05:6a20:7f89:b0:3eb:afe0:20aa with SMTP id adf61e73a8af0-3eed2e06bb1mr3837559637.20.1794227012895; Mon, 09 Nov 2026 04:23:32 -0800 (PST) Received: from [10.125.112.22] ([122.11.210.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cdb96816fc6sm1622392a12.5.2026.11.09.04.23.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Nov 2026 04:23:31 -0800 (PST) Message-ID: <7773d026-4aef-4169-866a-71ec9a91da21@gmail.com> Date: Mon, 9 Nov 2026 20:23:16 +0800 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 0/8] kdump: reduce vmcore size and capture time From: Wandun To: robh@kernel.org, baoquan.he@linux.dev, rppt@kernel.org, m.szyprowski@samsung.com Cc: catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, chenhuacai@kernel.org, kernel@xen0n.name, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, saravanak@kernel.org, akpm@linux-foundation.org, pasha.tatashin@soleen.com, pratyush@kernel.org, ruirui.yang@linux.dev, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org, iommu@lists.linux.dev References: <20261021083011.2170525-1-chenwandun1@gmail.com> Content-Language: en-US In-Reply-To: <20261021083011.2170525-1-chenwandun1@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261109_042334_941741_D9E153C7 X-CRM114-Status: GOOD ( 32.25 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 10/21/26 16:30, Wandun Chen wrote: > From: Wandun Chen > > On SoCs that carve out large firmware-owned reserved memory (GPU, > camera ISP, ...), kdump currently dumps those carveouts as part of > system RAM even though their contents are firmware state that is not > useful for kernel crash analysis. > > ACPI systems already filter reserved memory out of the vmcore through > their existing path: firmware reports those carveouts as unusable in > the EFI memory map, they get MEMBLOCK_NOMAP set in memblock.memory > (is_usable_memory(), efi-init.c), and the ELF header builder has > always skipped nomap regions; only DT-based systems currently fail > to filter these regions, which is what this series addresses. > > This series introduces a MEMBLOCK_NODUMP flag (suggested by Rob) in > memblock to filter reserved memory on DT-based architectures. A new > flag is needed because MEMBLOCK_NOMAP can only express regions without > a linear mapping, while MEMBLOCK_NODUMP can filter regions that are > linearly mapped. Reserved regions are marked MEMBLOCK_NODUMP by default > so kdump omits them; reusable CMA regions are different because their > pages are handed back to the buddy allocator and may carry crash-relevant > data. > > Since the reserved memory regions are filtered out, the vmcore is > smaller in size and faster to produce. > > The series is based on linux-next and is organized as follows: > > Patches 1-3: Preparation and bugfixes: switch riscv crash_mem to > memblock, fold the duplicated per-arch memblock walks > into the weak defaults, and serialize crash header > preparation against memory hotplug. > Patches 4-7: NODUMP infrastructure: switch crash_core to > for_each_mem_region(), introduce the MEMBLOCK_NODUMP > flag, add a dumpable flag to struct reserved_mem, and > mark /reserved-memory entries with MEMBLOCK_NODUMP. > Patch 8: Skip MEMBLOCK_NODUMP regions when building the vmcore > ELF header. Hi all, A gentle ping on this series. I'd appreciate any further feedback, particularly on the MEMBLOCK_NODUMP discussion and the issues raised in the Sashiko review. Please let me know if there are any other concerns or suggestions before I prepare the next revision. Thanks, Wandun > > v8 --> v9: > 1. Patch 7: Avoid a potential boot panic on SH when NODUMP marking requires > memblock resizing before it is allowed, found by Sashiko in [1]. SH supports > neither CONFIG_KEXEC_FILE nor CONFIG_CRASH_HOTPLUG, so skip marking when > both are disabled. > > v6 --> v8 (v7 mainly tried to fix the initrd issue on release in v6, > that approach is superseded here): > 1. Stop marking /memreserve/ regions with NODUMP. v6 marked > /memreserve/ regions with NODUMP. But a bootloader may specify > a /memreserve/ entry for memory that the kernel later frees > (e.g. the initrd), and those pages would then be wrongly > filtered out of the vmcore after being reused as normal memory. > The v7 fix (clearing the flag in free_reserved_area()) caused > a lockless runtime mutation of memblock.memory [2]. Better solutions > exist but need extra preparation, so temporarily dropped the patch > that introduced the problem to keep this series simple in v8. > 2. Fix a build failure in patch 2 with both ARCH_KEEP_MEMBLOCK and > MEMORY_HOTPLUG are unset. There the memblock arrays live in > .init.data, and the weak defaults referencing them create section > mismatches, which turn into build errors when SECTION_MISMATCH_WARN_ONLY > is also unset. > 3. RISCV recently gained crash hotplug support, so adapt its handler > like x86 in patch 3: use __crash_prepare_headers() instead of > crash_prepare_headers() to avoid self-deadlock. > 4. Update the cover letter per review feedback: describe how ACPI > systems filter reserved memory and why a new flag is needed > instead of reusing NOMAP. > > v6 --> v7: > 1. Fix a stale MEMBLOCK_NODUMP flag issue [3]. Memory reserved and > marked as NODUMP may later be freed (the initrd, for example), > so the NODUMP flag must be cleared accordingly. Since the fix is > part of the NODUMP infrastructure introduced by patch 5, it has > been folded into that patch. > 2. Drop the "generic" related description in the cover letter. > 3. Collect the Acked-by and Reviewed-by tags received during the v6 > review (thanks to Baoquan, Mike, Rob and Marek). Patch 5 is the > only one without a tag, as its Reviewed-by was dropped when the > fix was folded in. > 4. Drop patch 1 of v6, which has been merged separately. > > > v5 --> v6: > 1. Serialize crash header preparation against memory hotplug to avoid > out-of-bounds or use-after-free issues. > 2. MEMBLOCK_NODUMP marking is now done after memblock allows resizing, > avoiding a panic from too few regions before resize is permitted. > 3. Reordered the patches, put pre-existing bugfixes earlier in the series. > > [1] https://sashiko.dev/#/patchset/20261016061549.4181390-1-chenwandun1@gmail.com?part=7 > [2] https://lore.kernel.org/lkml/20260922090252.B01541F000FF@smtp.kernel.org/ > [3] https://sashiko.dev/#/message/20260917220750.GA4013814-robh%40kernel.org > > v5: https://lore.kernel.org/lkml/20260806093519.2907771-1-chenwandun1@gmail.com/ > v4: https://lore.kernel.org/lkml/20260630074715.4126796-1-chenwandun1@gmail.com/ > > Wandun Chen (8): > riscv: build crash_mem ranges from memblock instead of resource tree > crash_core: fold duplicated memblock arch hooks into the weak default > crash_core: serialize crash header preparation against hotplug > crash_core: replace for_each_mem_range() with for_each_mem_region() > memblock: introduce MEMBLOCK_NODUMP flag > of: reserved_mem: add dumpable flag to opt-in vmcore > of: reserved_mem: mark /reserved-memory entries with MEMBLOCK_NODUMP > crash_core: skip MEMBLOCK_NODUMP regions when building vmcore ELF > header > > arch/arm64/kernel/machine_kexec_file.c | 29 ------------ > arch/loongarch/kernel/machine_kexec_file.c | 27 ----------- > arch/riscv/Kconfig | 2 +- > arch/riscv/kernel/crash.c | 2 +- > arch/riscv/kernel/machine_kexec_file.c | 33 -------------- > arch/x86/kernel/crash.c | 2 +- > drivers/of/fdt.c | 1 + > drivers/of/of_private.h | 1 + > drivers/of/of_reserved_mem.c | 18 ++++++++ > include/linux/crash_core.h | 2 + > include/linux/memblock.h | 9 ++++ > include/linux/of_reserved_mem.h | 1 + > kernel/crash_core.c | 53 +++++++++++++++++++++- > kernel/dma/contiguous.c | 1 + > mm/memblock.c | 16 +++++++ > 15 files changed, 103 insertions(+), 94 deletions(-) >