From: david.lanzendoerfer@o2s.ch (David Lanzendörfer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/7] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs
Date: Mon, 10 Feb 2014 12:35:13 +0100 [thread overview]
Message-ID: <7779575.QASLIT4FqB@dizzy-6.o2s.ch> (raw)
In-Reply-To: <dac5ec28-3a6d-428f-8ab6-c8f2bb53168f@googlegroups.com>
Hi
> > + (cmd->opcode == 5 || cmd->opcode == 52))
> Aren't these the ones defined in linux/mmc/sdio.h:
> 5 - SD_IO_SEND_OP_COND
> 52 - SD_IO_RW_DIRECT
Yes. They are...
Changed that.
Also I removed the camel cases and the defines within the struct definition.
> > +struct sunxi_mmc_clk_dly {
> > + u32 mode;
> > + u32 oclk_dly;
> > + u32 sclk_dly;
> Do these members have to be u32? They all seem to be smaller than 10.
Yes. Because of situations where it gets used in bit operations, and shorter
types mess things up and prevent the driver from working ;-)
cheer
david
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140210/8a8707bf/attachment.sig>
next prev parent reply other threads:[~2014-02-10 11:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 21:32 [PATCH v4 0/7] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs David Lanzendörfer
2014-02-07 21:32 ` [PATCH v4 1/7] clk: sunxi: factors: automatic reparenting support David Lanzendörfer
2014-02-07 21:32 ` [PATCH v4 2/7] clk: sunxi: Implement MMC phase control David Lanzendörfer
2014-02-07 21:33 ` [PATCH v4 3/7] ARM: sunxi: clk: export clk_sunxi_mmc_phase_control David Lanzendörfer
2014-02-07 21:33 ` [PATCH v4 4/7] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs David Lanzendörfer
[not found] ` <dac5ec28-3a6d-428f-8ab6-c8f2bb53168f@googlegroups.com>
2014-02-10 11:35 ` David Lanzendörfer [this message]
2014-02-07 21:33 ` [PATCH v4 5/7] ARM: dts: sun7i: Add support for mmc David Lanzendörfer
2014-02-07 21:33 ` [PATCH v4 6/7] ARM: dts: sun4i: " David Lanzendörfer
2014-02-07 21:33 ` [PATCH v4 7/7] ARM: dts: sun5i: " David Lanzendörfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7779575.QASLIT4FqB@dizzy-6.o2s.ch \
--to=david.lanzendoerfer@o2s.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).