public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: Add max77686 RTC interrupt to cros5250-common
Date: Wed, 23 Oct 2013 14:31:24 +0100	[thread overview]
Message-ID: <777cfa1b95066d03b19252ac1b6eac2d@www.loen.fr> (raw)
In-Reply-To: <1382533861-12688-1-git-send-email-dianders@chromium.org>

On 2013-10-23 14:11, Doug Anderson wrote:
> Without the interrupt you'll get problems if you enable
> CONFIG_RTC_DRV_MAX77686.  Setup the interrupt properly in the device
> tree.

Awesome! Thanks for fixing this, Doug. My Chromebook is much happier 
now!

> Signed-off-by: Doug Anderson <dianders@chromium.org>

Tested-by: Marc Zyngier <marc.zyngier@arm.com>

         M.

> ---
>  arch/arm/boot/dts/cros5250-common.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/cros5250-common.dtsi
> b/arch/arm/boot/dts/cros5250-common.dtsi
> index dc259e8b..9b186ac 100644
> --- a/arch/arm/boot/dts/cros5250-common.dtsi
> +++ b/arch/arm/boot/dts/cros5250-common.dtsi
> @@ -27,6 +27,13 @@
>  		i2c2_bus: i2c2-bus {
>  			samsung,pin-pud = <0>;
>  		};
> +
> +		max77686_irq: max77686-irq {
> +			samsung,pins = "gpx3-2";
> +			samsung,pin-function = <0>;
> +			samsung,pin-pud = <0>;
> +			samsung,pin-drv = <0>;
> +		};
>  	};
>
>  	i2c at 12C60000 {
> @@ -35,6 +42,11 @@
>
>  		max77686 at 09 {
>  			compatible = "maxim,max77686";
> +			interrupt-parent = <&gpx3>;
> +			interrupts = <2 0>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&max77686_irq>;
> +			wakeup-source;
>  			reg = <0x09>;
>
>  			voltage-regulators {

-- 
Fast, cheap, reliable. Pick two.

  reply	other threads:[~2013-10-23 13:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-23 13:11 [PATCH] ARM: dts: Add max77686 RTC interrupt to cros5250-common Doug Anderson
2013-10-23 13:31 ` Marc Zyngier [this message]
2013-11-25 23:11 ` Doug Anderson
2013-11-25 23:16   ` Olof Johansson
2013-11-25 23:26     ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=777cfa1b95066d03b19252ac1b6eac2d@www.loen.fr \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox