From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCF32CD1288 for ; Thu, 4 Apr 2024 01:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fDLIfSG2fo7UGQRvwNUpTSRexXnK4/15THUeNDqfug0=; b=lqUpZoHx/Rzy/J BUsww0/ZO8/DfP0A9zb+KG9TWviVVNXkdEGdGGqmvln5q/2jE2m7puNjOnBpnXF0/KOZVlsztSLrL E3QrjGeC2Ownuha33YUUFV6P7tuCDoBAqm6CJu9ugH7pZRWmn+g6ewuS1qOS9MLoZJf0ai3dxxeDS V2ct3y00wDcJtNoUsSUVj6uJQ+8RHBMsvEfzxyK2hV/uAyIGKRA8jKxGIhM993FD/5XhCBCe1vY/v 0reiYEXI+7ms9NtnNcmKLMsD4gN8b3nB5ikb7o1ehvUASBxIUniz0bueebvdpZ5xcVZsDwvo4H7hk XgSy/vLFRBO7Lln1kPow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsBjm-00000000rr7-3qKF; Thu, 04 Apr 2024 01:17:54 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsBjk-00000000rqS-2Jd3 for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2024 01:17:54 +0000 Received: from [192.168.68.112] (ppp118-210-182-70.adl-adc-lon-bras34.tpg.internode.on.net [118.210.182.70]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id CB38C20172; Thu, 4 Apr 2024 09:17:39 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1712193470; bh=AnZy1ul9z22wLV53sWsuV/QLH4baWunjG6AMLZ7wkaE=; h=Subject:From:To:Date:In-Reply-To:References; b=C7w/5INMzf9doVl0bXoxlonTUfuLxaoa0qEhYhcoJ7nRVWjtwpusMfDVmGMFfl+sZ Gn2mVUSGFpGWgHBi/s8l0kMXpL0k+aFdGA25ZQ0K4HrvwaFqlUj5dhIO6f4+l24LQi mdQkJ18moNCE/X6VGdnL2UgMSMS/J1hPM8Vhg1ofpiRLjnxxbjUmmZpzexQbdn4zm2 rg3LUl2DyrcFfBg+pmVamLUY44RgJuxvCvGZ3TKUQm9fsqTNLPOmWbGSZXHN40jwDc 2rE6kcULCi3NSPh6vAajadYiY73FuQI+vyAk0mhb1ij16iOes/VtcCcLZyE/k8APSI AF07bWtSMGCsw== Message-ID: <77829355a18f2afd64343e7e19498473d9263ef6.camel@codeconstruct.com.au> Subject: Re: [PATCH v2 1/3] ARM: dts: Modify GPIO table for Asrock X570D4U BMC From: Andrew Jeffery To: Renze Nicolai , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au, andrew@aj.id.au Date: Thu, 04 Apr 2024 11:47:38 +1030 In-Reply-To: <20240403133037.37782-2-renze@rnplus.nl> References: <20240403133037.37782-1-renze@rnplus.nl> <20240403133037.37782-2-renze@rnplus.nl> User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_181752_802311_0F43DAC1 X-CRM114-Status: GOOD ( 13.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Renze, In the future, the start of the subject should also include 'aspeed: ', so: ARM: dts: aspeed: Modify GPIO table for Asrock X570D4U BMC On Wed, 2024-04-03 at 15:28 +0200, Renze Nicolai wrote: > Restructure GPIO table to fit maximum line length. > > Fix mistakes found while working on OpenBMC > userland configuration and based on probing > the board. > > Schematic for this board is not available. > Because of this the choice was made to > use a descriptive method for naming the > GPIOs. > > - Push-pull outputs start with output-* > - Open-drain outputs start with control-* > - LED outputs start with led-* > - Inputs start with input-* > - Button inputs start with button-* > - Active low signals end with *-n This seems to be a bit of a mix of following conventions in [1] and not. It might be helpful to weigh in on that document with your ideas. [1]: https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md I'll put this series in a tree for Joel for now though, with the subject fix mentioned above. I've also re-wrapped the commit messages as it seems you stopped a bit short of the allowable line length. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel