From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: rockchip: convert smp bringup to CPU_METHOD_OF_DECLARE
Date: Mon, 26 May 2014 21:20:15 +0200 [thread overview]
Message-ID: <77845932.xlUTKoJDWT@phil> (raw)
In-Reply-To: <20140526181315.GA27093@quad.lixom.net>
Am Montag, 26. Mai 2014, 11:13:15 schrieb Olof Johansson:
> On Thu, Mar 27, 2014 at 01:06:32AM +0100, Heiko St?bner wrote:
> > With the newly introduced CPU_METHOD_OF_DECLARE is not necessary anymore
> > to reference the relevant smp_ops in the board file, but instead it can
> > simply be set by the enable-method property of the cpu nodes.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>
> Applied, however:
> > ---
> >
> > changes since v1:
> > - add a short description to the enable-method binding
> >
> > Documentation/devicetree/bindings/arm/cpus.txt | 2 ++
> > arch/arm/boot/dts/rk3066a.dtsi | 1 +
> > arch/arm/boot/dts/rk3188.dtsi | 1 +
> > arch/arm/mach-rockchip/core.h | 2 --
> > arch/arm/mach-rockchip/platsmp.c | 3 ++-
> > arch/arm/mach-rockchip/rockchip.c | 1 -
> > 6 files changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/cpus.txt
> > b/Documentation/devicetree/bindings/arm/cpus.txt index 333f4ae..f52a9ac
> > 100644
> > --- a/Documentation/devicetree/bindings/arm/cpus.txt
> > +++ b/Documentation/devicetree/bindings/arm/cpus.txt
> > @@ -185,6 +185,8 @@ nodes to be present and contain the properties
> > described below.>
> > "qcom,gcc-msm8660"
> > "qcom,kpss-acc-v1"
> > "qcom,kpss-acc-v2"
> >
> > + "rockchip,rk3066-smp" - cpu-core handling of Socs
> > + from Rockchip starting with rk3066
>
> Nobody else has a comment here, so I removed this one.
>
> I noticed that the list is unsorted, in particular the new marvell entries
> were appended instead of inserted at the right location, which caused a
> merge conflict. Sigh. I'll do a separate commit on top to sort the list,
> since we seem to have the new out-of-order additions in our tree.
I added the comment after Mark Rutland noted:
"We should document what what these actually mean, so as to be a hardware
description and not a Linux internals description."
But I'm fine with it either way :-)
Heiko
next prev parent reply other threads:[~2014-05-26 19:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 10:27 [PATCH] ARM: rockchip: convert smp bringup to CPU_METHOD_OF_DECLARE Heiko Stübner
2014-03-26 11:00 ` Mark Rutland
2014-03-26 12:03 ` Heiko Stübner
2014-03-27 0:06 ` [PATCH v2] " Heiko Stübner
2014-05-12 17:17 ` Heiko Stübner
2014-05-16 22:54 ` Olof Johansson
2014-05-17 0:16 ` Heiko Stübner
2014-05-26 18:13 ` Olof Johansson
2014-05-26 19:20 ` Heiko Stübner [this message]
2014-05-26 19:21 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77845932.xlUTKoJDWT@phil \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).