From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A95EAC10F13 for ; Thu, 11 Apr 2019 13:21:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78676206DF for ; Thu, 11 Apr 2019 13:21:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BTJMwLhE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78676206DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mRN0O081l8vIFSqh8lFEhmTsFo+3vk687xHsd3iSvGQ=; b=BTJMwLhEUz3CCE Aov4hJ01RdKiVBUi5pe5e/MVpmAQgcpV/EpZoxvfkjS3GSxYw+wmUc03BZrzFftxf7wA9RdtdyVX/ flwGatVGLw/9L5KI0//5GrdfZrSe5AJbrYdpGmXLl8pidK4ihAztAJ2cXc/3eqf/M2JeLdbD+zkQ5 9mWSqKVrcghy+ZpaTznqUrsgN2fIk+puLAvz13Wt9wFSI4dG0qG2aKKPfLn5JFuK0IBBdlRwhAYYj TAiAmBAaRoFelo+8EvYV39SlEhfypUOhKK71+mwR3YOKxwKDpPUk/LeT3dmYeR6EOrqysKjo00HaB IEiZMOd7fbzbuejLEBkw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEZdi-00031F-0h; Thu, 11 Apr 2019 13:21:14 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEZdf-00030o-1M; Thu, 11 Apr 2019 13:21:12 +0000 Received: from wf0380.dip.tu-dresden.de ([141.76.181.124] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hEZdO-00086a-Hc; Thu, 11 Apr 2019 15:20:54 +0200 From: Heiko Stuebner To: =?ISO-8859-1?Q?Ga=EBl?= PORTAY Subject: Re: [PATCH v3 4/5] arm64: dts: rk3399: Add dfi and dmc nodes. Date: Thu, 11 Apr 2019 15:20:53 +0200 Message-ID: <7786013.gjegOBUKu0@phil> In-Reply-To: <20190321231440.19031-5-gael.portay@collabora.com> References: <20190321231440.19031-1-gael.portay@collabora.com> <20190321231440.19031-5-gael.portay@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_062111_226191_FB06BBBF X-CRM114-Status: UNSURE ( 9.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Derek Basehore , Lin Huang , linux-pm@vger.kernel.org, Brian Norris , Douglas Anderson , Rob Herring , linux-kernel@vger.kernel.org, Chanwoo Choi , Kyungmin Park , MyungJoo Ham , Klaus Goger , Enric Balletbo i Serra , linux-rockchip@lists.infradead.org, Randy Li , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ga=EBl, Am Freitag, 22. M=E4rz 2019, 00:14:39 CEST schrieb Ga=EBl PORTAY: > From: Lin Huang > = > These are required to support DDR DVFS on rk3399 platform. The patch also > introduces a new file with default DRAM settings. > = > Signed-off-by: Lin Huang > Signed-off-by: Enric Balletbo i Serra > Signed-off-by: Ga=EBl PORTAY > + dmc: dmc { > + compatible =3D "rockchip,rk3399-dmc"; > + rockchip,pmu =3D <&pmugrf>; > + devfreq-events =3D <&dfi>; > + clocks =3D <&cru SCLK_DDRC>; > + clock-names =3D "dmc_clk"; > + status =3D "disabled"; > + rockchip,ddr3_speed_bin =3D <21>; > + rockchip,pd_idle =3D <0x40>; > + rockchip,sr_idle =3D <0x2>; > + rockchip,sr_mc_gate_idle =3D <0x3>; > + rockchip,srpd_lite_idle =3D <0x4>; > + rockchip,standby_idle =3D <0x2000>; > + rockchip,dram_dll_dis_freq =3D <300000000>; > + rockchip,phy_dll_dis_freq =3D <125000000>; > + rockchip,auto_pd_dis_freq =3D <666000000>; > + rockchip,ddr3_odt_dis_freq =3D <333000000>; > + rockchip,ddr3_drv =3D ; > + rockchip,ddr3_odt =3D ; > + rockchip,phy_ddr3_ca_drv =3D ; > + rockchip,phy_ddr3_dq_drv =3D ; > + rockchip,phy_ddr3_odt =3D ; > + rockchip,lpddr3_odt_dis_freq =3D <333000000>; > + rockchip,lpddr3_drv =3D ; > + rockchip,lpddr3_odt =3D ; > + rockchip,phy_lpddr3_ca_drv =3D ; > + rockchip,phy_lpddr3_dq_drv =3D ; > + rockchip,phy_lpddr3_odt =3D ; > + rockchip,lpddr4_odt_dis_freq =3D <333000000>; > + rockchip,lpddr4_drv =3D ; > + rockchip,lpddr4_dq_odt =3D ; > + rockchip,lpddr4_ca_odt =3D ; > + rockchip,phy_lpddr4_ca_drv =3D ; > + rockchip,phy_lpddr4_ck_cs_drv =3D ; > + rockchip,phy_lpddr4_dq_drv =3D ; > + rockchip,phy_lpddr4_odt =3D ; as Rob mentioned in his review, these values look board-specific, so should probably move over to the specific board you're using them on? Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel