From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED2ECC43334 for ; Fri, 17 Jun 2022 10:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Sl5pgvdVi0QuzR7QY/lac4BKgi3oJ/rkNaoC0eeMST4=; b=dVJkiiF2hozeIFZ1Ra72lsjnyS +3n1g/NhQfklaYaDlUAf+VqR3XtKbRa6J58PcolVp42qYA4iwdDI3FTGEzM6MZxdYPYLs4DWS9OIJ +PFpZdY/yDjjhY+nKRAGpy+pRxXKPLbzYFBx9QXGJPfVs4n04PifL9VE61tYdG1EaM9kZGLWXI8W7 rL8aScscCg2rKYHsQzTaCr8PWFoWbvAWoLSnEg9dJGx+7w5FzdXQMOhm787OXEME2nCpFtbfVuoSR Q8cTvV0yY8kT0kNlfsltPhT8Zyjz+eTaifwZ5oq/tHb8tRjj8Wyb7prEqs0pIWhU7uFT3kCv+5HvS 5h179Ffw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o29S6-0070q9-2N; Fri, 17 Jun 2022 10:43:46 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o29S1-0070oG-Js; Fri, 17 Jun 2022 10:43:43 +0000 Received: by mail-ed1-x530.google.com with SMTP id 25so5645032edw.8; Fri, 17 Jun 2022 03:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=v5ecjoqfrtonTaDC6C0FL6A10bdamLrdFYiT8G5VOw4=; b=i9vP6RSHB3vHCWE4RcV+HJ7iNa3yq76y+QY1jM2hM3XW30wf/IpH2PYhW7PjjWYdPl FnqF4MY1FWpWmG/tInRWbGGRUlq5fOUBIRpqGOUPd00Y0fJI+wBSk0Sk/D/TyosFFW5R eDf3zmrZD/g1r7hS3VyzLNDAbbkl16Bhal3vADJhDYj3ELdqcONpuYcNn0AfBNvr6vGi VBSww3vMhxoeLHx3ZWL2K7B9n0zo1x4SBXkekziqpWI5BcKNBpIH12C66NB/XTdHMMl8 k4KSyVmEIab/YXL6INbKpXWiiTJuNemZKohU4Afojnen0VzWidI7IsWlIxHRLKMHeyz7 BIPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=v5ecjoqfrtonTaDC6C0FL6A10bdamLrdFYiT8G5VOw4=; b=XkoqkRLxV+Vr/QQRFH0VBfdTrzDdLFhpBmq69Ci4Aa/uIto+M0YVey6Ct0EHt+WWMq snI320gNrmedt86moJxmBdJK7vy7aKXl9TFxToiyHr7+6hgXaxs/g/MjjVeVUot8sTLn lMhRYLibvXlX3MDqYQ4kLzXx0PTA0baj2dA8m31VZFPCuq3MOw0FFJo1fwEkxUl7Oepb ZVObvj3i9Z+ZzD6XQFKU6V7ye/7lKGuY6oX+ry7PDNw/vOxsNf/FKixTTJR96E6xiJPA b0cIDGc3gwxvXYvgs5lim1R2M9wC24ExY0zswwp7dSJGqeRuevZpS5fJbfddbPWBSb6k e9/Q== X-Gm-Message-State: AJIora/tH8y2yiGNVFHMi9YGgMKbY2Nf3ntTqQRGRoPGSi1RRezsuq6o fGao1jyovwWtF32dtBaMl+Q= X-Google-Smtp-Source: AGRyM1vGje4sUJAcYpjSJzolDvmR/43gla1gcSQu/6kGI0U0BANsb2e78Xdl4mzbofJwfzp3bj4U5w== X-Received: by 2002:a05:6402:334:b0:435:584e:514c with SMTP id q20-20020a056402033400b00435584e514cmr6465853edw.410.1655462620199; Fri, 17 Jun 2022 03:43:40 -0700 (PDT) Received: from [192.168.0.24] (80.174.78.229.dyn.user.ono.com. [80.174.78.229]) by smtp.gmail.com with ESMTPSA id x16-20020aa7cd90000000b0042fb3badd48sm3464631edv.9.2022.06.17.03.43.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jun 2022 03:43:39 -0700 (PDT) Message-ID: <7788acc5-a9b9-1be7-0e6f-217e9b54b28f@gmail.com> Date: Fri, 17 Jun 2022 12:43:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 15/40] arm64: dts: mediatek: align gpio-key node names with dtschema Content-Language: en-US To: Krzysztof Kozlowski , arm@kernel.org, soc@kernel.org, Arnd Bergmann , Olof Johansson , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220616005224.18391-1-krzysztof.kozlowski@linaro.org> <20220616005333.18491-15-krzysztof.kozlowski@linaro.org> From: Matthias Brugger In-Reply-To: <20220616005333.18491-15-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220617_034341_705540_2D52CB2E X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/06/2022 02:53, Krzysztof Kozlowski wrote: > The node names should be generic and DT schema expects certain pattern > (e.g. with key/button/switch). > > Signed-off-by: Krzysztof Kozlowski Applied, thanks > --- > .../boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 4 ++-- > arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 4 ++-- > arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dts | 6 +++--- > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 10 +++++----- > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 4 ++-- > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 2 +- > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 2 +- > arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi | 4 ++-- > 8 files changed, 18 insertions(+), 18 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts > index 2b9bf8dd14ec..c2311733d2de 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts > +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts > @@ -40,13 +40,13 @@ cpu@1 { > gpio-keys { > compatible = "gpio-keys"; > > - factory { > + factory-key { > label = "factory"; > linux,code = ; > gpios = <&pio 0 GPIO_ACTIVE_HIGH>; > }; > > - wps { > + wps-key { > label = "wps"; > linux,code = ; > gpios = <&pio 102 GPIO_ACTIVE_HIGH>; > diff --git a/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts b/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts > index 596c073d8b05..c28da9323a9c 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts > +++ b/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts > @@ -42,13 +42,13 @@ gpio-keys { > compatible = "gpio-keys"; > poll-interval = <100>; > > - factory { > + key-factory { > label = "factory"; > linux,code = ; > gpios = <&pio 0 0>; > }; > > - wps { > + key-wps { > label = "wps"; > linux,code = ; > gpios = <&pio 102 0>; > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dts b/arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dts > index 44f6149c1307..28433b94f7c7 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dts > @@ -21,7 +21,7 @@ cpu_crit: cpu_crit0 { > }; > > &gpio_keys { > - /delete-node/tablet_mode; > - /delete-node/volume_down; > - /delete-node/volume_up; > + /delete-node/switch-tablet-mode; > + /delete-node/switch-volume-down; > + /delete-node/switch-volume-up; > }; > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > index 9c75fbb31f98..d20378758213 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > @@ -53,7 +53,7 @@ gpio_keys: gpio-keys { > pinctrl-names = "default"; > pinctrl-0 = <&gpio_keys_pins>; > > - lid { > + switch-lid { > label = "Lid"; > gpios = <&pio 69 GPIO_ACTIVE_LOW>; > linux,code = ; > @@ -61,7 +61,7 @@ lid { > gpio-key,wakeup; > }; > > - power { > + switch-power { > label = "Power"; > gpios = <&pio 14 GPIO_ACTIVE_HIGH>; > linux,code = ; > @@ -69,7 +69,7 @@ power { > gpio-key,wakeup; > }; > > - tablet_mode { > + switch-tablet-mode { > label = "Tablet_mode"; > gpios = <&pio 121 GPIO_ACTIVE_HIGH>; > linux,code = ; > @@ -77,13 +77,13 @@ tablet_mode { > gpio-key,wakeup; > }; > > - volume_down { > + switch-volume-down { > label = "Volume_down"; > gpios = <&pio 123 GPIO_ACTIVE_LOW>; > linux,code = ; > }; > > - volume_up { > + switch-volume-up { > label = "Volume_up"; > gpios = <&pio 124 GPIO_ACTIVE_LOW>; > linux,code = ; > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > index 2d7a193272ae..3ac83be53627 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > @@ -73,7 +73,7 @@ volume_buttons: volume-buttons { > pinctrl-names = "default"; > pinctrl-0 = <&volume_button_pins>; > > - volume_down { > + button-volume-down { > label = "Volume Down"; > linux,code = ; > debounce-interval = <100>; > @@ -81,7 +81,7 @@ volume_down { > gpios = <&pio 6 GPIO_ACTIVE_LOW>; > }; > > - volume_up { > + button-volume-up { > label = "Volume Up"; > linux,code = ; > debounce-interval = <100>; > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi > index 28966a65391b..50a0dd36b5fb 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi > @@ -45,7 +45,7 @@ gpio-keys { > pinctrl-names = "default"; > pinctrl-0 = <&pen_eject>; > > - pen-insert { > + switch-pen-insert { > label = "Pen Insert"; > /* Insert = low, eject = high */ > gpios = <&pio 6 GPIO_ACTIVE_LOW>; > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > index b035e06840e6..b50261e8b9ed 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > @@ -144,7 +144,7 @@ wifi_wakeup: wifi-wakeup { > pinctrl-names = "default"; > pinctrl-0 = <&wifi_pins_wakeup>; > > - wowlan { > + button-wowlan { > label = "Wake on WiFi"; > gpios = <&pio 113 GPIO_ACTIVE_HIGH>; > linux,code = ; > diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi > index 7a717f926929..8ee1529683a3 100644 > --- a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi > +++ b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi > @@ -28,7 +28,7 @@ gpio-keys { > pinctrl-names = "default"; > pinctrl-0 = <&gpio_keys_default>; > > - volume-up { > + key-volume-up { > gpios = <&pio 42 GPIO_ACTIVE_LOW>; > label = "volume_up"; > linux,code = <115>; > @@ -36,7 +36,7 @@ volume-up { > debounce-interval = <15>; > }; > > - volume-down { > + key-volume-down { > gpios = <&pio 43 GPIO_ACTIVE_LOW>; > label = "volume_down"; > linux,code = <114>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel