From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91174D0E6DF for ; Mon, 21 Oct 2024 10:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8lwgscnGMKin0UOPQKLlrFdjR81oCq1342yPI69TJk8=; b=NeQKrFsx8UoTrDJF/8N4jhYtSU V7YoEyW21ellLwdEwT+NqWYwE8b+gotV8rixEC939cdBmrScwvqWwszZdV5IQ7ot07nRNducBWwMr Yodeg6fWD3SBHPU9yAgmUQomzVHqjXtNDbbDVrnOVw84mmqrAgPuxCk04raqoMEFiSFLs57QAjWI5 5pKUKdUS6vv0QoDwPPHGDQjJLvkQDvHFK1bcL9icRPczDlnbu/AoJOwOPDtuCXzky5RAX0pyHi6n9 hdnkjp65oAS2Pl6noFusc18gDnLYDMUfXxUE6id0EdK1TsdYIi0cSyyfCeKvYRcdplQDDa/JUbYxG veLdACNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t2pR8-00000006qyY-2V1J; Mon, 21 Oct 2024 10:14:54 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t2pIC-00000006p8q-41CT for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2024 10:05:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 80F68DA7; Mon, 21 Oct 2024 03:06:07 -0700 (PDT) Received: from [10.57.65.82] (unknown [10.57.65.82]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EA64D3F73B; Mon, 21 Oct 2024 03:05:33 -0700 (PDT) Message-ID: <7793ba63-1d3c-44b0-8daf-10c4a7b79bc9@arm.com> Date: Mon, 21 Oct 2024 12:05:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] arm64: signal: Remove unused macro To: Dave Martin Cc: linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, anshuman.khandual@arm.com, aruna.ramakrishna@oracle.com, broonie@kernel.org, catalin.marinas@arm.com, dave.hansen@linux.intel.com, jeffxu@chromium.org, joey.gouly@arm.com, shuah@kernel.org, will@kernel.org, linux-kselftest@vger.kernel.org, x86@kernel.org References: <20241017133909.3837547-1-kevin.brodsky@arm.com> <20241017133909.3837547-2-kevin.brodsky@arm.com> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241021_030541_196726_BCE54E41 X-CRM114-Status: GOOD ( 11.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/10/2024 17:49, Dave Martin wrote: > On Thu, Oct 17, 2024 at 02:39:05PM +0100, Kevin Brodsky wrote: >> Commit 33f082614c34 ("arm64: signal: Allow expansion of the signal >> frame") introduced the BASE_SIGFRAME_SIZE macro but it has >> apparently never been used. > Nit: Should there be a statement of what the patch does? > > Same throughout the series. > > (Yes, I know it's in the subject line, but Mutt doesn't think that's > part of the message body, so I can't see it now that I'm replying... > and submitting-patches.rst and e.g., maintainer-tip.rst seem to take > the same policy, albeit without quite stating it explicitly.) Ah good point, I didn't consider that. Will make it explicit in patch 1 and 2. Kevin