From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A408C982E1 for ; Mon, 21 Sep 2026 06:40:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A+8OPNDTMUtNRwvm6okuvzvDQl5XdfF+zgDgtOpY5Lw=; b=r7yKHuEbZPD0D15qpSWcUrm7Nh GWS5F8IKx6raQiP1aqwcoSj1mRgzXuMV+DDxx15MRS7Z2EkrDGdA7arBqDTzkgjDGS3WlqNPE0CL1 KmyUx81oVgWSPUDyfQgU1plxyo9m8s1KXhq+iGoU9VAap9flIxuH41qro5RPXJrQCtzxa8jKqvcy7 2YBlocJSPM5HcMppGd7lHWBguX+mdx42C1P5cDoBNz2LCCLgtjZ7kZ8xPh8lRGnuaZlhav1SjE+ja qhCwGi05FUGqnvHsZMTc9HX0GBqUKtU4mFmfobYgASwkeoEVnXRjZKXCoafn7djuJfdWF26V8WtG8 IvAu28pw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8Xhi-000000014R7-0AXq; Mon, 21 Sep 2026 06:40:42 +0000 Received: from mx0b-0002e601.pphosted.com ([148.163.154.28]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8Xhf-000000014QV-0nhO for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2026 06:40:41 +0000 Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68L5GJwA2770128; Mon, 21 Sep 2026 01:40:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=A+8OPNDTMUtNRwvm6okuvzvDQl5XdfF+zgDgtOpY5 Lw=; b=WNgyu8eWsRw88PFdqyws7yhvmAG0v97/oi6GmYUK5h+rgCy8Me8gvUGAM 1plfNIjjayVOvSPD2DXV9I8xoiuXNnM4EnxH6u7V6BTBVqLVMzynt8YHMoc0L8H2 wUSBi1PMfRv0EVKxk9o8lxuPlSjKiqHYuSplTnkQIQ/z9sWDcmzo28rmB7nU3V+f 5QObPIo4WZda3S0bXmc3u/OVRlx4odGpQbTEAbRZPLycX7vP4e3vrmDczevggPw7 xGqQRY2LGwiVElXS4y9Sx92pIVXfbjyz0uKxW9nc75tahWTVcF6KrfgDCXn+aAgi Qt9KD7b9xXRbfRJgJqAZi/yvphLMw== Received: from ch4pr04cu002.outbound.protection.outlook.com (mail-northcentralusazon11013066.outbound.protection.outlook.com [40.107.201.66]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gtx9f8ewy-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 21 Sep 2026 01:40:30 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mMcvarQQjw+1r9b/yofoswsnztCfO0BpJoKPr27DJBh3nS80ZK6+TO2bOATXhm842OwqB+rl4BwWj10BdOBooXkg8qnV1KdOgb1lmNaqrkakIUSp9ZcPoxOqXf4hR5N0vv57w7QfNfElzgcPZICyZ3kp0e7GorQt3mVYR5aU+hMSm5VU3ZNJFmtxP/XD1xXbsLUieUd4pdIok5t+HlmaDAe2tiQdPIM2/AYsrXskRzvqm8q/ypJQy/bymPIQtuZ0kXRbE+hFlUSfCjV1p1dVAdzub0zSEyMTzszINRzWmv/PdHj20F0kQNYlPcfzaVv+/+PI6PKMkYr5Zrj1eHJitg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A+8OPNDTMUtNRwvm6okuvzvDQl5XdfF+zgDgtOpY5Lw=; b=ScrcY8nsZqwKSaPAtVb5Xr/j0fauOvGPUf67CVBPykZY+tvQomcIy6cyY6pnzmKEu963o9XCwTS76OgcUG7WRyexIw5idxBp/0BNqdG3UUcxC8PzE0VsmZOX1dZZwwvEYiqgRMa4UhfNvRnb9sYL4xGi4jd+G2sFoYCp9EiLwnuWKAyEERX3M4azHGMn2BxAZIIXgN+pzj1xRpqoInN7HCMiegA7sgWj3Nb5Xy80AYfhnzTXyp4YDur8mYCMk+NTGRJOMXN2dFvspMRlgQS/LCEWP5m8dZVN3Dct1sodWzLYKEAxAQoWlsgib97S7tX6WponyyikuGpOdjYI4YJSRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A+8OPNDTMUtNRwvm6okuvzvDQl5XdfF+zgDgtOpY5Lw=; b=vURB5nqGjrhY5RW/D+F6UGS31gIOGB64ix3e19dwSmZ24TiIv3B3OliPX5kUb6cyAwh0Tdhd63Y8PiZWObpS/KZWFmUgua0K/nj/O99dwn25OF8CYB3MoJXpOzqaW+JGlqd/q4ss1qpz/eiLIpDuWe0u9SB2OqGsNsCEk+7OWkk= Received: from BYAPR21CA0029.namprd21.prod.outlook.com (2603:10b6:a03:114::39) by MW4PR10MB5882.namprd10.prod.outlook.com (2603:10b6:303:18f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.13; Mon, 21 Sep 2026 06:40:27 +0000 Received: from SJ5PEPF00000207.namprd05.prod.outlook.com (2603:10b6:a03:114:cafe::7) by BYAPR21CA0029.outlook.office365.com (2603:10b6:a03:114::39) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.451.13 via Frontend Transport; Mon, 21 Sep 2026 06:40:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by SJ5PEPF00000207.mail.protection.outlook.com (10.167.244.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Mon, 21 Sep 2026 06:40:27 +0000 Received: from DLEE201.ent.ti.com (157.170.170.76) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 21 Sep 2026 01:40:12 -0500 Received: from DLEE200.ent.ti.com (157.170.170.75) by DLEE201.ent.ti.com (157.170.170.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 21 Sep 2026 01:40:12 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE200.ent.ti.com (157.170.170.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Mon, 21 Sep 2026 01:40:12 -0500 Received: from [10.24.53.39] (akashdeep-hp-z2-tower-g5-workstation.dhcp.ti.com [10.24.53.39]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68L6e8SR1519418; Mon, 21 Sep 2026 01:40:09 -0500 Message-ID: <7795b166-b0fc-4bc0-9dd3-f0fa8251de6d@ti.com> Date: Mon, 21 Sep 2026 12:10:08 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: ti: k3-pinctrl: Add virtual GPIO select mux macros To: Vignesh Raghavendra , , , , , , , , CC: , Kendall Willis References: <20260917111539.3844577-1-a-kaur@ti.com> <39d5525a-1276-47af-8659-70a86cda8a1b@ti.com> Content-Language: en-US From: Akashdeep Kaur In-Reply-To: <39d5525a-1276-47af-8659-70a86cda8a1b@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000207:EE_|MW4PR10MB5882:EE_ X-MS-Office365-Filtering-Correlation-Id: d97f44b6-73e8-4bcb-eef8-08df17ab390a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|82310400026|23010399003|36860700016|6133799003|10067099003|56012099006|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: v1Q23LxZsdJJ14Ar1rAT3uhQ9vYSnpdPcC+X+1Bd+SwAcqEp+EhVqMfs70PStJaNjQTEUGk6k26r8w/1WIyZsSC5AgdaU/JKoRVRT4R0v2QKLAmJ34+Nn4M+iu18i1E1nFtHpnrARK5IOaukQTZMc6FCIb5zSflftVdbMsx/p6SwLt+9X8Fsw7+7zQTY2GXLplOMVIqKmjtCTl1DNbUlV30b/svuC0Fx5ASidoc1qPQLLo87OPDxCCSxL+QezCUgt6vM4xJxnj6WKjvao/oTPRSWEkVLQYob/pvWA7CEPih+MPSYX3wedkRJntfC/4m580MksL0Wt0h5L7gbhchRXmJup4GBTlGW84XfoS5Ic6IfFBA6azJM9ow6rGJ+fIPw1lq1L7CZJ7cYAvLsZoapP+TyFtw2npyBTbCQQK/HMIRbvbx0W7RiAoCjWXc2bE6ukNinpDqfgpk+9dC317JaIJFxioKyiQhwpzxpBk8Zl6fTUZH35/If8SobHSfAhAuG4SI1O+g6uYPUYGRc9n3L39J0I4xyJ4yhhQc8qiDQ5kn32bfJi3s4NQK57vwsjRPObN3kvPzcLi8lFgc+f0xNeQrDtVzEZ8YmijAVv0D18kfNqii1j+g60rrMNCCm59mFRUtHPLMw2M8WZS/YVJBWgQzsxVcv+jZ44HEWSsALM8be9NpLf4TVws9wr8MCKtWq X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(82310400026)(23010399003)(36860700016)(6133799003)(10067099003)(56012099006)(4143699003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bWTfmCy4HGzTGNSpr+7xTvAQWA1sjmOO4+DwUX4CJK6blYaRClh+khHK3trSyT+tD607WNhQ3Ztxd1CkWkRHkj33fS2kOylebgRzDiA+T0emjpaRQ6VsSn8VKCuQYkFmM9bvKA4eVGO5Wi4zE55/Q9OEihxQvHQVa3677Y5uesS/N2LgcGQHdlOGdzcQGfs9Zrq35W/qFnQSGuQngTlz6SRaQSz3eLri8GSIFxT/A7bBFNUb7OgjE0z6d2cQ59Vj4h+SnukfpPL2JOO6X1aZT1x11fyiIFcFOGkZPqUEAGPnqP01MY/o4joggRI11NRSbwkuDjJ8fl5gTi9I4rjv5ZO+GkDZ70+g6yfWE7Um81+9nNm7SlRJWBsl94a1u/p3E86WV/lw7d/k2tHDwPCwqlO+wR1/30wgZ9n/W3LnRGtsA6ok5FhOJwPUTWIh3bdc X-Exchange-RoutingPolicyChecked: IPiI7983pJkPwoBHHftOByGJ7hsu7VsVb1timyPhPI+svNnphXIY4TS9gQe3/KKVbctTFAL5ND0fe6kUHzAJfjN+JGuvmajb7APvK+khX8GJ1rzsm2W8MDTYCXYb4ps3bq3vpjMr5vY8Pm1X9XmBNAl0QOkBm/8ACAmVDO0bqMB6cr9BahZvhlCEkDDV2F4fc9cZv/7bhbV9yDqqNfLb212sdQfHOqiiyNboWgQNm8KgFu7zR3MGUra3tF0moAHA112y8UDh8D8j7hGYYv1TDrRyQk+iFg7XQJ9EmHKnTB6UdbGZ4QsawIRZOI/OQZG0eS6+zQdvobbeOZftWUpChA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2026 06:40:27.2869 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d97f44b6-73e8-4bcb-eef8-08df17ab390a X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF00000207.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5882 X-Authority-Analysis: v=2.4 cv=Vou2kO2n c=1 sm=1 tr=0 ts=6ab0d15e cx=c_pps a=2KosHvP3s5kmPOqSYQ0Nog==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=We7qAqze--YcBpNh1UUA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIxMDA5NCBTYWx0ZWRfX70dlFnqx/5in RpbZfW2Ed8xe2aqqzMxQaaWPHtQg/Mrgigr00PvjT1VzmZ1UEGqcYZaAURCKnvinrqCFP/TxkRO eprTvULtl0Dm6jlSiwhx58fmoFEvZUYuglCf6oqtcPNgGZpGKgM5hmS2jcTES9W4WEerkAlCHbi Ophz4OuyR8CRAnvLgVWM5p8h1P+dKA0cCjHahxdKVSVYLhrLPQZJDgLmaq5Q9rXxGsV0X7MwJ5e WO+HYstWCkr4Ys1pN/Zp0iQjQ3JeB+Jxu4+owlqgNIdoXo+d220u/2CIo8QK4OCq36dBzIoIj6z nirMCXYJn8R1xDuuh6KXurtobZzGsEAAmcBOjkG1vWF3guiYSvUyz4XVq/ZfC5ez0c8izc4ja6d u5Me2Bm4LCgzbNQxiv++n4/fNrAJl7PnTRwqe5NSDTCH3qKxcErIwuV9L4Uqh8KriLjUhY8p3U/ Na0mZ5EEIwLe7kfZM7g== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIxMDA5NCBTYWx0ZWRfX9+M5YRfdthqH y7CQyj8kB642RPhFjHjJipOrSRoBNmGE2wlRafmwnEMqL6gZN/DirmSOyf3N3e3aZEa50Kdkbts ohDoe5SDkozNhMg5A0bdkDu1uhx2OhM= X-Proofpoint-ORIG-GUID: 0FfUB4e2-ygbEbMT7VsE3mQUOq1C7Oow X-Proofpoint-GUID: 0FfUB4e2-ygbEbMT7VsE3mQUOq1C7Oow X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-21_02,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 adultscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609210094 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260920_234039_346978_93244E72 X-CRM114-Status: GOOD ( 15.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vignesh, On 18/09/26 13:57, Vignesh Raghavendra wrote: > > > On 17/09/26 16:45, Akashdeep Kaur wrote: >> Add virtual GPIO select mux macros to allow users to select GPIO >> controller bank for pins. The two GPIO controller instances in the >> MAIN domain share physical pins, and the vgpio_sel field routes each ... >> >> +#define VGPIO_SEL_SHIFT (4) >> #define WKUP_LVL_EN_SHIFT (7) >> #define WKUP_LVL_POL_SHIFT (8) >> #define DEBOUNCE_SHIFT (11) >> @@ -111,6 +112,9 @@ >> #define PIN_WKUP_EN_LEVEL_HIGH (WKUP_ENABLE | WKUP_ON_LEVEL | WKUP_LEVEL_HIGH) >> #define PIN_WKUP_EN (WKUP_ENABLE | WKUP_ON_EDGE) >> >> +#define PIN_VGPIO_SEL0 (0 << VGPIO_SEL_SHIFT) >> +#define PIN_VGPIO_SEL2 (1 << VGPIO_SEL_SHIFT) >> + > > Unfortunately, this field has different meaning in different SoCs. Here > is the definition from J784s4: > > Note this field is irrelevant when Muxmode is not 7. > for MAIN GPIO > 00 = GPIO0 or 1 depending on the specific pin (meaning if mode 7 has > GPIO0.x then it is GPIO0 and if GPIO1.x then GPIO1) > 01 - GPIO2 or 3 depending on the specific pin (meaning if mode 7 has > GPIO0.x then it is GPIO2 and if GPIO1.x then GPIO3) > 10 - GPIO4 or 5 depending on the specific pin (meaning if mode 7 has > GPIO0.x then it is GPIO4 and if GPIO1.x then GPIO5) > 11 - GPIO6 or 7 depending on the specific pin (meaning if mode 7 has > GPIO0.x then it is GPIO6 and if GPIO1.x then GPIO7) > Note this field is irrelevant when Muxmode is not 7. > > Thus, macros need to be generic or it should just open code the constant. Thank you for the feedback and the detailed J784S4 example. You're absolutely right that the naming was too AM62L-specific. I've addressed this in v2 by using generic value-based naming (PIN_VGPIO_SEL0/1/2/3) and adding all four values. The commit message now clarifies that the meaning is SoC-specific. Thanks and Regards, Akashdeep Kaur > >> /* Default mux configuration for gpio-ranges to use with pinctrl */ >> #define PIN_GPIO_RANGE_IOPAD (PIN_INPUT | 7) >> >