public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Wolfram Sang <wsa@kernel.org>,
	Robert Hancock <robert.hancock@calian.com>,
	 <linux-i2c@vger.kernel.org>, <michal.simek@xilinx.com>,
	<ben-linux@fluff.org>, <richard.rojfors@pelagicore.com>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] i2c: xiic: Make bus names unique
Date: Wed, 2 Mar 2022 16:29:24 +0100	[thread overview]
Message-ID: <77a3ee4d-8452-26b5-d9d3-9376f17e558d@xilinx.com> (raw)
In-Reply-To: <Yh6TjgPxGUG6U3dg@ninjato>



On 3/1/22 22:43, Wolfram Sang wrote:
> On Thu, Jan 27, 2022 at 11:50:13AM -0600, Robert Hancock wrote:
>> This driver is for an FPGA logic core, so there can be arbitrarily many
>> instances of the bus on a given system. Previously all of the I2C bus
>> names were "xiic-i2c" which caused issues with lm_sensors when trying to
>> map human-readable names to sensor inputs because it could not properly
>> distinguish the busses, for example. Append the platform device name to
>> the I2C bus name so it is unique between different instances.
>>
>> Fixes: e1d5b6598cdc ("i2c: Add support for Xilinx XPS IIC Bus Interface")
>> Signed-off-by: Robert Hancock <robert.hancock@calian.com>
> 
> Michal, is this okay with you?
> 

Origin state

~# cat /sys/class/i2c-adapter/i2c-0/name
xiic-i2c

new state.

~# cat /sys/class/i2c-adapter/i2c-0/name
xiic-i2c 40800000.i2c

I am fine with it.

Tested-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-03-02 15:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 17:50 [PATCH] i2c: xiic: Make bus names unique Robert Hancock
2022-03-01 21:43 ` Wolfram Sang
2022-03-02 15:29   ` Michal Simek [this message]
2022-03-02 21:26 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77a3ee4d-8452-26b5-d9d3-9376f17e558d@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=ben-linux@fluff.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=richard.rojfors@pelagicore.com \
    --cc=robert.hancock@calian.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox