From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5694AC433DB for ; Fri, 29 Jan 2021 17:45:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E53B64E02 for ; Fri, 29 Jan 2021 17:45:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E53B64E02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NwKB4eJ7XSzVdA0gs+KWNqd2uH8tDCd5buKIjrWDkBg=; b=wFkVXDwyp4K5kyulYDXTHc/g0 yfi4u8kuEtO9cdSYwZHAChJZVGhN0/kP3PT6jNPkjqltpJgPrtEKENZAbTif3dHf+uziSu0jNveK+ 2kz4EU5vXCh8CYkPQNWd7d4ZFJQSrsxYmmGN3NLTX6FQPgvxi7f/IJnxAetyOjGx7HFqJOb+mZlw0 DwUv+k9C7oIrnDt80Y7eEdvOt78eF8tS1MrKm6G1YNE66jdHGLSXVoCxN+r+3RN0dnXdFQvHAkpNz JFfCElc/q1WGg8Lsa73UL50pH8PlpT1AkDEo0oUCLhvv9K1crQ82yeXiExQtvU83k5khWA07nM+SR V20fWayeg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5Xon-0004Ie-5b; Fri, 29 Jan 2021 17:44:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5Xol-0004I7-86 for linux-arm-kernel@lists.infradead.org; Fri, 29 Jan 2021 17:44:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2E54713A1; Fri, 29 Jan 2021 09:44:20 -0800 (PST) Received: from [10.37.12.11] (unknown [10.37.12.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 133EB3F71B; Fri, 29 Jan 2021 09:44:17 -0800 (PST) Subject: Re: [PATCH v9 3/4] kasan: Add report for async mode To: Andrey Konovalov References: <20210126134603.49759-1-vincenzo.frascino@arm.com> <20210126134603.49759-4-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: <77de8e48-6f68-bf27-0bed-02e49b69a12d@arm.com> Date: Fri, 29 Jan 2021 17:48:12 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210129_124423_356693_85DB2793 X-CRM114-Status: GOOD ( 18.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Branislav Rankov , Marco Elver , Catalin Marinas , Evgenii Stepanov , LKML , kasan-dev , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/29/21 5:40 PM, Andrey Konovalov wrote: > On Tue, Jan 26, 2021 at 2:46 PM Vincenzo Frascino > wrote: >> >> KASAN provides an asynchronous mode of execution. >> >> Add reporting functionality for this mode. >> >> Cc: Dmitry Vyukov >> Cc: Andrey Ryabinin >> Cc: Alexander Potapenko >> Cc: Andrey Konovalov >> Reviewed-by: Andrey Konovalov >> Signed-off-by: Vincenzo Frascino >> --- >> include/linux/kasan.h | 6 ++++++ >> mm/kasan/report.c | 13 +++++++++++++ >> 2 files changed, 19 insertions(+) >> >> diff --git a/include/linux/kasan.h b/include/linux/kasan.h >> index bb862d1f0e15..b6c502dad54d 100644 >> --- a/include/linux/kasan.h >> +++ b/include/linux/kasan.h >> @@ -360,6 +360,12 @@ static inline void *kasan_reset_tag(const void *addr) >> >> #endif /* CONFIG_KASAN_SW_TAGS || CONFIG_KASAN_HW_TAGS*/ >> >> +#ifdef CONFIG_KASAN_HW_TAGS >> + >> +void kasan_report_async(void); >> + >> +#endif /* CONFIG_KASAN_HW_TAGS */ >> + >> #ifdef CONFIG_KASAN_SW_TAGS >> void __init kasan_init_sw_tags(void); >> #else >> diff --git a/mm/kasan/report.c b/mm/kasan/report.c >> index 87b271206163..69bad9c01aed 100644 >> --- a/mm/kasan/report.c >> +++ b/mm/kasan/report.c >> @@ -360,6 +360,19 @@ void kasan_report_invalid_free(void *object, unsigned long ip) >> end_report(&flags, (unsigned long)object); >> } >> >> +#ifdef CONFIG_KASAN_HW_TAGS >> +void kasan_report_async(void) >> +{ >> + unsigned long flags; >> + >> + start_report(&flags); >> + pr_err("BUG: KASAN: invalid-access\n"); >> + pr_err("Asynchronous mode enabled: no access details available\n"); >> + dump_stack(); >> + end_report(&flags); > > This conflicts with "kasan: use error_report_end tracepoint" that's in mm. > > I suggest to call end_report(&flags, 0) here and check addr !=0 in > end_report() before calling trace_error_report_end(). > I just noticed and about to post a rebased version with end_report(&flags, 0). >> +} >> +#endif /* CONFIG_KASAN_HW_TAGS */ >> + >> static void __kasan_report(unsigned long addr, size_t size, bool is_write, >> unsigned long ip) >> { >> -- >> 2.30.0 >> -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel