From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3726C4167B for ; Sun, 29 Oct 2023 21:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XjQHP/M9jGaFBZJDeJ27umLBGeNdQMX3h86Pl3UjMVs=; b=MoPCUwJxMX+y2F hGhZSsCDtRis+BZkJOUDnaPru2OF6bM1/aBWsDKxP3duwatbrYEDxpwzL7qMFRn3xFNFH1zI+yJMP SHXyZ/AU9k20sLNWUCj0sbRpmke0+XgZhmeKVLmgMnKXz/OJAs/cI4JBjX6hxKuxtItirBl/G7/A/ TaIDEcFQF5xRIla729v64IlkOEPLEEJJTrZkAMji9UvFhmTcO54J/oSiWZtdjebczG+bGs9WIemww kNZkajM8bIRjUkfBds7oAN6i1oMbcE3osXbGtWd+GB7O0eSNYc06Q6ESBPQ/RRko4QPzywklpmEy2 M0TESgEmhz4SPoXhQgdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qxD1L-0027TY-2F; Sun, 29 Oct 2023 21:08:31 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qxD1H-0027TA-1E; Sun, 29 Oct 2023 21:08:29 +0000 Received: from [192.168.1.90] (unknown [188.24.143.101]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id DF7DD66072BB; Sun, 29 Oct 2023 21:08:20 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698613702; bh=GoWKvXVCI2rJHZaaMlrQGK5PE/qto64zo6wfdhb04jw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dT0wlb9v/BSZdRvWw2CB4dPGTr65xipwdJ1ig9xIKIAkNUTEUjjERuC4H1MnIlY7L YHVqnak1wmwv0EXm0xnTWi6h/oWfJWDY9vPtUIdO/y35OgL539uSZKuLgBtMtu9rTk 4cVIDn1O4skrL+tY/cy51u/S7uRJicQ3YklzkLXhl/E4nYfPvmEK70+ZlVyidteCH2 JVAbU2ipAXoL76QnyMj1A+SF3e/bwJXaouX2NNzCnpSd7zCjZGoNEaJ/T62NU5EvA/ 5WI6l6YnPrfxwo3Y8GIsGmZhcTKDsddwcdCeFdiFLUzhh8y8MSrAunK7jm3x1cVhQU AyaCOohAvr+6A== Message-ID: <77ea127f-1040-489c-8ee3-d27df16fb995@collabora.com> Date: Sun, 29 Oct 2023 23:08:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/12] dt-bindings: net: starfive,jh7110-dwmac: Drop superfluous select Content-Language: en-US To: Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Samin Guo , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Giuseppe Cavallaro Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@collabora.com References: <20231029042712.520010-1-cristian.ciocaltea@collabora.com> <20231029042712.520010-3-cristian.ciocaltea@collabora.com> <9c9120d6-dd28-4b6d-be8d-46c0cab8f26a@linaro.org> From: Cristian Ciocaltea In-Reply-To: <9c9120d6-dd28-4b6d-be8d-46c0cab8f26a@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231029_140827_589910_68433D51 X-CRM114-Status: UNSURE ( 8.26 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/29/23 13:18, Krzysztof Kozlowski wrote: > On 29/10/2023 05:27, Cristian Ciocaltea wrote: >> The usage of 'select' doesn't seem to have any influence on how this >> binding schema is applied to the nodes, hence remove it. >> > > It has. Why do you think it doesn't? You should see new errors from > dwmac schema. This patch came as a result of testing both variants (w/ and w/o 'select') with several different compatible strings and seeing consistent output: - "starfive,jh7110-dwmac", "invalid"; - "starfive,jh7110-dwmac"; - "invalid", "snps,dwmac-5.20"; - "invalid" Did I miss something? Thanks for the review, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel