From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8904C00A89 for ; Mon, 2 Nov 2020 12:13:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F5AB206DD for ; Mon, 2 Nov 2020 12:13:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZjdDxHA2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="AXDN4CBx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="XnWs/LW3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F5AB206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VxozDXFvLxEyaEI5lJqjczwdMcrvKM51UGr7MTJtRuk=; b=ZjdDxHA28ic2Uw68gpoFdA97o Cx/i9EXaF5jB0dH+FTF2CgnQLi1DIk4HLaxEVXRbFBucXXODu26bkXhFMgWU69Z0HNiBohgyl0FHj BvtictzMohKK6El3vl4kwmKzv1Xex9HGKDFvLG7w3fX/EQuCm+CRwTW+Z20tOIDXdhI4oQQG6Ebwf WK0xC9Z0Lzj7ieDIpcLcWqkdzLgfmZSHFYeVmB6EEFG1EHNhlp2VcP0dAqqSCbOmCx/kWb8KC7B/9 CEWHITuxfJ7CpbJEQTCa2JsTVVGLlaUAN2gtmmvaEuRrbApDCBI5pfm2kSjrR7NW5DAJGx2zabxz8 6c8yr3FPA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZYgS-0003qj-Tc; Mon, 02 Nov 2020 12:11:36 +0000 Received: from esa5.microchip.iphmx.com ([216.71.150.166]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZYgQ-0003pI-D1 for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 12:11:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1604319095; x=1635855095; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=QE8UoYhrISwnxCROEqCoTb3UGEtU9w6iHMfqG5Jbz9k=; b=AXDN4CBxnhOaf/fFp9GvEgMInOiAYWBi2RM1hvBi+FlXoMKHZueyXpFG NFbJUx5vFIjvZXE4bdff1v7kI6yfXDDGGPKuhukuNQB1zS/e3et4YyP+Y aJ364XEcWhGIgxg/eSyBbVCAEqPEXh9+NWoc4J7/+Ixw0n3vpMWiiKnEI wyozQTeOUjaPMcxvx22YiD+KzoV9G3/lira8YnGLqWI1e+/pqt6fTZExt x6sf2CnMpmpKK89M3Sypm7a+P4NVuxG+O2i4Mj1Ue+SCVb0MPVDCLaZXO r1LcCgQdgS74lNPVOjmjG0sNTtqzyycmcT2VZx8axmYVu6T3uejbHHijW A==; IronPort-SDR: KpqdWQY1UhczqdC4hkijz1JlzkKzssjox8ot8CydChyg5rcTzBaX+5daBB4RA/Ha+ve0Bwdlbq I+QZ5H3oWBPGCnWk7walCCMmHrnFPmnlq6LLzByigYrVqDGksVQoFAi864CMReAGWH0n/jr86/ GVirS1Fr37FnCJuO70/FT6D6RYY75vFmIPnon6lltj7ylWRev/zk7UlTlAx7JwtRo+Mh7wDwqR FogW7b9eRp2VFJtN66EOOSJmHUCqgsyDPzLXTWhxuS1ovw2Hlo+KNpgITzc2wLO8DrY1GHx18V 684= X-IronPort-AV: E=Sophos;i="5.77,444,1596524400"; d="scan'208";a="96811958" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 02 Nov 2020 05:11:31 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Mon, 2 Nov 2020 05:11:30 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Mon, 2 Nov 2020 05:11:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dnMLBJFVehTGbJBeM4MdPzUWzNYkhYrjs4XYbBhoqLaWNfvtEA0Om/VioSd02/ddY2wLvCflQe+J+PPcICrKZAbjemhsmpDQ2jyuvuvnhmxbuVMvEYiL+WEEO0PhGX1YZnEDdpbbQ1hW8EPnvEX5LA3qAke3AMoYaDTGPlFDxRpnsJ1r1I2CMTWfR16H70cP0CYhDiq0nAdtWL6sJu9u+ZSy5anT1Dp/nenCf+aZKVrFh8DxLQbJQRmcrLjLUq1xrk94BmoRYoPUxuCPwbuMhJH9vCAew6Aaa6DjUTECVPOK1Qq/9+37KVy6o0FIbeCfI3isT6oCnYuVP6kdEbrUsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QE8UoYhrISwnxCROEqCoTb3UGEtU9w6iHMfqG5Jbz9k=; b=lF77DgqxGiuiLC1zsdwtOtTMwRqITgqYEQGNhe1XBbMdh9j3DOy1xojimnwSn4l9SGcy2IfneAWBCQ8s+3PFej7qNbfm6W6tFAKKhr/0D0X7OP3S9AJCf0LzVZNXJv2IwnQBkh4gMsIV+ceu3UHIuqIeK+Nn5LeVyoBVIENVyC6VUALTEaN3BVwqcZq5/DOPSEzSEHv9FZQQ+Y70tx/RWyp+dfzjzTPAtoTiuCD8ARFAbYscLGMjrnmGcaHfUzZlgQtBpcIbTIBIwKpBwbjNSHDHaNKiypnXqPnkeSmJhxjkUbmqnPGVAzKXe7U5AtE2fKG1Fuls6U9ACY2F+zG39Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QE8UoYhrISwnxCROEqCoTb3UGEtU9w6iHMfqG5Jbz9k=; b=XnWs/LW3SRt3pAla0yMPF9lSQb+aK1j/LDvKYIRp6MqxYttSMS0nCuMzjVd5e7vv0Xi/NJE/ZAAK4uCJdVGIfk5u4lXF/HEKIvMk7fLnMqBMUGEImLU3f2vbNvkOA0rVKODN+XvjRd+RhiaxVQnA/n9GNqSdFc6vYoSeL6W0W1E= Received: from CY4PR1101MB2341.namprd11.prod.outlook.com (2603:10b6:903:b1::22) by CY4PR11MB2040.namprd11.prod.outlook.com (2603:10b6:903:29::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Mon, 2 Nov 2020 12:11:28 +0000 Received: from CY4PR1101MB2341.namprd11.prod.outlook.com ([fe80::908:a628:69ca:d62e]) by CY4PR1101MB2341.namprd11.prod.outlook.com ([fe80::908:a628:69ca:d62e%7]) with mapi id 15.20.3499.030; Mon, 2 Nov 2020 12:11:28 +0000 From: To: , Subject: Re: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart Thread-Topic: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart Thread-Index: AQHWrq0BNGYIfVuhjkKKUxhuAsgrHKmwJpcAgARphwCAADUdAA== Date: Mon, 2 Nov 2020 12:11:28 +0000 Message-ID: <780303c7-2c32-f2e1-c9ce-1e2ee6bf0533@microchip.com> References: <20201030110702.886638-1-codrin.ciubotariu@microchip.com> <20201102090122.GF4127@dell> In-Reply-To: <20201102090122.GF4127@dell> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=microchip.com; x-originating-ip: [86.121.145.173] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b1fa053-93a3-47d2-c6ce-08d87f286da7 x-ms-traffictypediagnostic: CY4PR11MB2040: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-bypassexternaltag: True x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6e/Hq5AjdF0RXZTLUjwijvKHnCBAJ1dsGaBzSLAMPXmDn7IX2MIaAQoRh0OoKqUGz123bucUeQXy0uyuxaH9As+8jfelJpEVyYtgvRApRmte0WQvciq1TECC9CE0EMtVSKhGxGYZY/ftwxs+c/CFaX8ObedsvjSGU26UoHed9jiqIznoVd8eJODcE5ovIp3UPM/3aOPXj84qLLx32MpHpoqItrV9R2k7/qSrGBx+K7wzZsOFoE4op1Kt46UkvQIfPcSaX0Lj5+E1j+jOrE8tEcITwFzhqstJM8jvrc99VNPoW2djKAXo0NQzT5Xi+fadoDYtXF7orDeeJrOl3ZnfsgpRCf1XGVJYLgD5b8PxK+2X/7ivSTTPsWACCWMirWCY x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2341.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(136003)(346002)(366004)(396003)(376002)(8936002)(64756008)(6512007)(31696002)(186003)(5660300002)(91956017)(4326008)(6506007)(66476007)(66556008)(6486002)(66946007)(2616005)(36756003)(107886003)(8676002)(316002)(26005)(83380400001)(478600001)(6636002)(54906003)(86362001)(71200400001)(2906002)(76116006)(53546011)(110136005)(31686004)(66446008)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: nI6lNjLFoUqeAQd79GEZNzcPJ+g5cGW/4D20wZ87gwp23ZbAe2R5XuxRW8o4/3MTcdVEHgEU98fMjS0L2bntdrMMRo/0SybmlrRSrLMjhfG4J27Nlg3HkUTug3tdzNMO0IomUsI6k9JRu0+JA9t/JmrF4legB3oDfiHdKHu5pp5yHTBLFVGe08bxO5w9Qo/4Jdx0mILwHpJhRmjZQy53nj1NwSOZk0ZtBgGekI/djI57w4VvhGWep5Bo5m41KcNen7AP/SUwQi3N1/yTMHWVwhCNQ2+im2N0w55k1E4rvH5aFjhkjEplMRF15ZteFIdJ4IQcEkO9b2RDb7ALpyB6BBIoLHJCNPzRvt9Ch9Ntu2qZtE7frQuKFRckMWeBECDniAt72/VvwQ1nUDj0aEtyOA1Bbv6q3evyAopuwtivEMRdJKPWeOG3WBSEeG5uhWqPn7yoNw8w6xNXwkYySvwXGe1ZxIRcn6SGxOjJqXiQ8MyzkbqKiphtG33oW6Cyi+ufsb6pfX0A3rCgWGoME9dI9j8GXI6k8XHPGCEpirugiHUsmmk8+NILeF7Dp7r3MUhITzLnzLNfbv4qHimaRcD31mfbY9h8DgYLAumHSQbmRjiS1YjUUF6x8vLoVHKyLRVi/OCMY/vYfOZIjD4VuGkodg== Content-ID: <3A66CB6DED5B834CADC8D899D9BA0198@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2341.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b1fa053-93a3-47d2-c6ce-08d87f286da7 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2020 12:11:28.7136 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yfYllLi01niDCm86Vaofz7xoXEb0/FUunnUtoxAKVgEu65j25VixwMHIHaU3/l5RKQ7V0tq1Ojf6aIm/hpncKL8/43IJoslyeHRVt8kZ5T8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB2040 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_071134_694198_4ECAA510 X-CRM114-Status: GOOD ( 26.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, richard.genoud@gmail.com, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02.11.2020 11:01, Lee Jones wrote: > On Fri, 30 Oct 2020, Nicolas Ferre wrote: > >> On 30/10/2020 at 12:07, Codrin Ciubotariu wrote: >>> The "atmel,at91sam9260-usart" driver is a MFD driver, so it needs sub-nodes >>> to match the registered platform device. For this reason, we add a serial >>> subnode to all the "atmel,at91sam9260-usart" serial compatible nods. This >>> will also remove the boot warning: >>> "atmel_usart_serial: Failed to locate of_node [id: -2]" >> >> I don't remember this warning was raised previously even if the MFD driver >> was added a while ago (Sept. 2018). >> >> I would say it's due to 466a62d7642f ("mfd: core: Make a best effort attempt >> to match devices with the correct of_nodes") which was added on mid August >> and corrected with 22380b65dc70 ("mfd: mfd-core: Ensure disabled devices are >> ignored without error") but maybe not covering our case. >> >> So, well, I don't know what's the best option to this change. Moreover, I >> would say that all other USART related properties go into the child not if >> there is a need for one. >> >> Lee, I suspect that we're not the only ones experiencing this ugly warning >> during the boot log: can you point us out how to deal with it for our >> existing atmel_serial.c users? > > You should not be instantiating drivers through Device Tree which are > not described there. If the correct representation of the H/W already > exists in Device Tree i.e. no SPI and UART IP really exists, use the > MFD core API to register them utilising the platform API instead. > > This should do it: > > diff --git a/drivers/mfd/at91-usart.c b/drivers/mfd/at91-usart.c > index 6a8351a4588e2..939bd2332a4f6 100644 > --- a/drivers/mfd/at91-usart.c > +++ b/drivers/mfd/at91-usart.c > @@ -17,12 +17,10 @@ > > static const struct mfd_cell at91_usart_spi_subdev = { > .name = "at91_usart_spi", > - .of_compatible = "microchip,at91sam9g45-usart-spi", > }; > > static const struct mfd_cell at91_usart_serial_subdev = { > .name = "atmel_usart_serial", > - .of_compatible = "atmel,at91rm9200-usart-serial", > }; > > static int at91_usart_mode_probe(struct platform_device *pdev) [snip] Hi Lee, thank you for looking through our usart driver and for sharing your thoughts. Removing the usage of compatible string means that for similar serial/SPI IPs we would need to create new platform drivers. This is not ideal, but it's a solution. What I proposed is more flexible, but, as you pointed out, I am not sure it correctly describes the HW, because the decision of whether to use this IP as a serial or a SPI is a configurable one. Thanks and best regards, Codrin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel