public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Alexey Klimov" <alexey.klimov@linaro.org>,
	"Sam Protsenko" <semen.protsenko@linaro.org>,
	linux-samsung-soc@vger.kernel.org,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 1/8] dt-bindings: soc: move and rename google,gs101-pmu-intr-gen schema under soc/samsung/
Date: Mon, 23 Mar 2026 17:03:08 +0100	[thread overview]
Message-ID: <7831dd9f-3e7c-4016-8d84-fe1fa82bdf9d@kernel.org> (raw)
In-Reply-To: <DHA9YL83GF3E.VOMD4KV10NLW@linaro.org>

On 23/03/2026 16:42, Alexey Klimov wrote:
> On Sat Mar 7, 2026 at 5:03 PM GMT, Krzysztof Kozlowski wrote:
>> On 26/02/2026 16:47, Alexey Klimov wrote:
>>> The GS101 PMU interrupts generation block is actually a standard Samsung
>>> Exynos IP block found in older SoCs like the Exynos 850 and others and
>>> not exclusive to Google SoCs. Thus, renaming to
>>> samsung,exynos850-pmu-intr-gen, moving the schema file to soc/samsung
>>> directory to reflect its origin, since Exynos850 predates GS101 SoCs,
>>> and preparing for adding Exynos850 description.
>>>
>>> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
>>> ---
>>>  .../samsung,exynos850-pmu-intr-gen.yaml}                              | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/soc/google/google,gs101-pmu-intr-gen.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos850-pmu-intr-gen.yaml
>>> similarity index 80%
>>> rename from Documentation/devicetree/bindings/soc/google/google,gs101-pmu-intr-gen.yaml
>>> rename to Documentation/devicetree/bindings/soc/samsung/samsung,exynos850-pmu-intr-gen.yaml
>>> index 2be022ca6a7d..f9b40f3fd165 100644
>>> --- a/Documentation/devicetree/bindings/soc/google/google,gs101-pmu-intr-gen.yaml
>>> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos850-pmu-intr-gen.yaml
>>> @@ -1,10 +1,10 @@
>>>  # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>  %YAML 1.2
>>>  ---
>>> -$id: http://devicetree.org/schemas/soc/google/google,gs101-pmu-intr-gen.yaml#
>>> +$id: http://devicetree.org/schemas/soc/samsung/samsung,exynos850-pmu-intr-gen.yaml#
>>>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>>>  
>>> -title: Google Power Management Unit (PMU) Interrupt Generation
>>> +title: Samsung Power Management Unit (PMU) Interrupt Generation
>>
>> Rename is fine if you add here compatible, otherwise the name does not
>> match the compatible.
> 
> Thanks, I'll rearrange commits then to make it sane in the next submission.

If you re-order then the case will be the same. Filename will not match
compatible. IOW, rename is not a logical change on its own.

Best regards,
Krzysztof


  reply	other threads:[~2026-03-23 16:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 15:47 [PATCH RFC 0/8] Exynos850 CPU hotplug support and pmu_intr_gen cleanup Alexey Klimov
2026-02-26 15:47 ` [PATCH RFC 1/8] dt-bindings: soc: move and rename google,gs101-pmu-intr-gen schema under soc/samsung/ Alexey Klimov
2026-03-06 14:22   ` Peter Griffin
2026-03-07 17:03   ` Krzysztof Kozlowski
2026-03-23 15:42     ` Alexey Klimov
2026-03-23 16:03       ` Krzysztof Kozlowski [this message]
2026-03-23 16:33         ` Alexey Klimov
2026-02-26 15:47 ` [PATCH RFC 2/8] dt-bindings: soc: samsung: exynos850-pmu-intr-gen: add Exynos850 compatible Alexey Klimov
2026-02-26 15:47 ` [PATCH RFC 3/8] dt-bindings: soc: samsung: exynos-pmu: add samsung,pmu-intr-gen phandle Alexey Klimov
2026-02-26 15:47 ` [PATCH RFC 4/8] dt-bindings: soc: samsung: exynos-pmu: deprecate google,pmu-intr-gen-syscon Alexey Klimov
2026-02-26 15:47 ` [PATCH RFC 5/8] soc: samsung: exynos-pmu: rename GS101_INTR_* regs to EXYNOS_INTR_* Alexey Klimov
2026-02-26 15:47 ` [PATCH RFC 6/8] soc: samsung: exynos-pmu: generalise GS101 PMU intr gen for Exynos SoCs Alexey Klimov
2026-02-26 15:47 ` [PATCH RFC 7/8] soc: samsung: exynos-pmu: add Exynos850 CPU hotplug support Alexey Klimov
2026-03-06 14:15   ` Peter Griffin
2026-03-17 14:11     ` Alexey Klimov
2026-02-26 15:47 ` [PATCH RFC 8/8] arm64: dts: exynos850: add PMU interrupt generation node Alexey Klimov
2026-03-06 13:44   ` Peter Griffin
2026-03-17 14:07     ` Alexey Klimov
2026-03-07 17:08   ` Krzysztof Kozlowski
2026-03-23 15:37     ` Alexey Klimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7831dd9f-3e7c-4016-8d84-fe1fa82bdf9d@kernel.org \
    --to=krzk@kernel.org \
    --cc=alexey.klimov@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andre.draszik@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=semen.protsenko@linaro.org \
    --cc=tudor.ambarus@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox