From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 17 Nov 2015 15:15:31 +0100 Subject: [PATCH] pinctrl: qcom: qdf2xxx: improve error checking and reporting In-Reply-To: References: <1447171030-15056-1-git-send-email-timur@codeaurora.org> Message-ID: <7846916.TvyJAMuMZQ@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 17 November 2015 14:33:49 Linus Walleij wrote: > On Tue, Nov 10, 2015 at 4:57 PM, Timur Tabi wrote: > > > The driver doesn't report an error message if the ACPI tables are missing > > the num-gpios property (which indicates how many GPIOs there are on this > > SOC), and it didn't check to ensure that the mallocs didn't fail. > > > > Signed-off-by: Timur Tabi > > Waiting for Bj?rn's ACK on this. > > And I suspect Arnd would be interested to know if you are doing > ACPI on something that is certainly not a server-class hardware. > Because you shouldn't. > It's more fun just watching this really. No comment. Arnd