From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/8] usb: xhci: avoid warning for !PM_SLEEP
Date: Tue, 13 May 2014 21:39:37 +0200 [thread overview]
Message-ID: <7882044.S9pqnTAVYy@wuerfel> (raw)
In-Reply-To: <20140513152829.GK1151@saruman.home>
On Tuesday 13 May 2014 10:28:29 Felipe Balbi wrote:
> > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> > index 151901c..3473296 100644
> > --- a/drivers/usb/host/xhci-plat.c
> > +++ b/drivers/usb/host/xhci-plat.c
> > @@ -202,7 +202,7 @@ static int xhci_plat_remove(struct platform_device *dev)
> > return 0;
> > }
> >
> > -#ifdef CONFIG_PM
> > +#ifdef CONFIG_PM_SLEEP
>
> can we just drop the ifdeferry altogether, including from SET_*_OPS
> macros ? This is just ridiculous that every merge window we have tens of
> patches fixing the ifdef in several drivers.
That would work for me. Another suggestion that came up before was
to change the SET_*_OPS so that the compiler silently drops the unused
functions, but unfortunately that would require changing all drivers.
Arnd
next prev parent reply other threads:[~2014-05-13 19:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 13:52 [PATCH 0/8] usb: various fixes for ARM randconfig failures Arnd Bergmann
2014-05-08 13:52 ` [PATCH 1/8] usb/gadget: s3c2410_udc: don't use pr_debug return value Arnd Bergmann
2014-05-08 13:52 ` [PATCH 2/8] usb: musb: tusb-dma can't be built-in if tusb is not Arnd Bergmann
2014-05-08 13:52 ` [PATCH 3/8] usb: musb: omap2plus bus glue needs USB host support Arnd Bergmann
2014-05-08 13:52 ` [PATCH 4/8] usb: phy: fix isp1301-omap dependency on tps65010 Arnd Bergmann
2014-05-13 15:26 ` Felipe Balbi
2014-05-13 19:48 ` Arnd Bergmann
2014-05-13 19:52 ` Felipe Balbi
2014-05-08 13:52 ` [PATCH 5/8] usb: phy: msm: reset controller is mandatory now Arnd Bergmann
2014-05-08 14:21 ` Ivan T. Ivanov
2014-05-08 14:27 ` Arnd Bergmann
2014-05-08 14:58 ` Ivan T. Ivanov
2014-05-13 15:27 ` Felipe Balbi
2014-05-08 13:52 ` [PATCH 6/8] usb: xhci: avoid warning for !PM_SLEEP Arnd Bergmann
2014-05-13 15:28 ` Felipe Balbi
2014-05-13 19:39 ` Arnd Bergmann [this message]
2014-05-13 19:52 ` Felipe Balbi
2014-05-08 13:52 ` [PATCH 7/8] usb: ohci: sort out dependencies for lpc32xx and omap Arnd Bergmann
2014-05-08 15:51 ` Alan Stern
2014-05-08 13:52 ` [PATCH 8/8] usb: ohci-da8xx can only be built-in Arnd Bergmann
2014-05-08 15:47 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7882044.S9pqnTAVYy@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox