From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6295DC4360F for ; Fri, 5 Apr 2019 04:40:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33B7821850 for ; Fri, 5 Apr 2019 04:40:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X2pHAYNk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33B7821850 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Date:Message-ID:Subject: From:To:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=vJP5BXJBUp2uDoea0ge6rVuJ/IkG3Hv02U4yFedXMg0=; b=X2pHAYNkdkgXYw AedzsEx6k8n+x/+o5U/PkvJiZVPb57lyiWXFTAsPA06YXpocGktZFAHoxC9KnzWDj94ZnF8JiOmBf bIL2GTuJ+v3hzMgAWyf3z//Ghl+CegrM7LJwFwjhIa8eZUtVjetd9N2m/AVbh9//sj3v8gG6kY326 6jJwr34oBz8opXIQqNXZmh5aWbYL9iCPCJdD/+hKTkBy+xzcdUPcwuuBACb24uVYBShc+NnR2IN+F w8JqsSeJJWBUVz9Wm7UikoepRAMAvU+SSCcuaM/x7BO8DUEjxGYtKXi7Lm/IUGd6uTQyqW6YEEhfE FyygUashAUHhkCKS2NEg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCGeS-0005Vq-BX; Fri, 05 Apr 2019 04:40:28 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCGeP-0005VU-78 for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2019 04:40:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3CC1315AD; Thu, 4 Apr 2019 21:40:23 -0700 (PDT) Received: from [10.162.40.100] (p8cg001049571a15.blr.arm.com [10.162.40.100]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 30D4E3F59C; Thu, 4 Apr 2019 21:40:20 -0700 (PDT) To: "linux-mm@kvack.org" , Linux ARM , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Dan Williams , Will Deacon , Catalin Marinas From: Anshuman Khandual Subject: struct dev_pagemap corruption Message-ID: <7885dce0-edbe-db04-b5ec-bd271c9a0612@arm.com> Date: Fri, 5 Apr 2019 10:10:22 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190404_214025_270280_52BF4587 X-CRM114-Status: GOOD ( 12.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On arm64 platform "struct dev_pagemap" is getting corrupted during ZONE_DEVICE unmapping path through device_destroy(). Its device memory range end address (pgmap->res.end) which is getting corrupted in this particular case. AFAICS pgmap which gets initialized by the driver and mapped with devm_memremap_pages() should retain it's values during the unmapping path as well. Is this assumption right ? [ 62.779412] Call trace: [ 62.779808] dump_backtrace+0x0/0x118 [ 62.780460] show_stack+0x14/0x20 [ 62.781204] dump_stack+0xa8/0xcc [ 62.781941] devm_memremap_pages_release+0x24/0x1d8 [ 62.783021] devm_action_release+0x10/0x18 [ 62.783911] release_nodes+0x1b0/0x220 [ 62.784732] devres_release_all+0x34/0x50 [ 62.785623] device_release+0x24/0x90 [ 62.786454] kobject_put+0x74/0xe8 [ 62.787214] device_destroy+0x48/0x58 [ 62.788041] zone_device_public_altmap_init+0x404/0x42c [zone_device_public_altmap] [ 62.789675] do_one_initcall+0x74/0x190 [ 62.790528] do_init_module+0x50/0x1c0 [ 62.791346] load_module+0x1be4/0x2140 [ 62.792192] __se_sys_finit_module+0xb8/0xc8 [ 62.793128] __arm64_sys_finit_module+0x18/0x20 [ 62.794128] el0_svc_handler+0x88/0x100 [ 62.794989] el0_svc+0x8/0xc The problem can be traced down here. diff --git a/drivers/base/devres.c b/drivers/base/devres.c index e038e2b3b7ea..2a410c88c596 100644 --- a/drivers/base/devres.c +++ b/drivers/base/devres.c @@ -33,7 +33,7 @@ struct devres { * Thus we use ARCH_KMALLOC_MINALIGN here and get exactly the same * buffer alignment as if it was allocated by plain kmalloc(). */ - u8 __aligned(ARCH_KMALLOC_MINALIGN) data[]; + u8 __aligned(__alignof__(unsigned long long)) data[]; }; On arm64 ARCH_KMALLOC_MINALIGN -> ARCH_DMA_MINALIGN -> 128 dev_pagemap being added: #define ZONE_DEVICE_PHYS_START 0x680000000UL #define ZONE_DEVICE_PHYS_END 0x6BFFFFFFFUL #define ALTMAP_FREE 4096 #define ALTMAP_RESV 1024 pgmap->type = MEMORY_DEVICE_PUBLIC; pgmap->res.start = ZONE_DEVICE_PHYS_START; pgmap->res.end = ZONE_DEVICE_PHYS_END; pgmap->ref = ref; pgmap->kill = zone_device_percpu_kill; pgmap->dev = dev; memset(&pgmap->altmap, 0, sizeof(struct vmem_altmap)); pgmap->altmap.free = ALTMAP_FREE; pgmap->altmap.alloc = 0; pgmap->altmap.align = 0; pgmap->altmap_valid = 1; tmp = (unsigned long *)&pgmap->altmap.base_pfn; tmp1 = (unsigned long *)&pgmap->altmap.reserve; *tmp = pgmap->res.start >> PAGE_SHIFT; *tmp1 = ALTMAP_RESV; With the patch: [ 53.027865] XXX: zone_device_public_altmap_init pgmap ffff8005de634218 resource ffff8005de634250 res->start 680000000 res->end 6bfffffff size 40000000 [ 53.029840] XXX: devm_memremap_pages_release pgmap ffff8005de634218 resource ffff8005de634250 res->start 680000000 res->end 6bfffffff size 40000000 Without the patch: [ 34.326066] XXX: zone_device_public_altmap_init pgmap ffff8005de530a80 resource ffff8005de530ab8 res->start 680000000 res->end 6bfffffff size 40000000 [ 34.328063] XXX: devm_memremap_pages_release pgmap ffff8005de530a80 resource ffff8005de530ab8 res->start 680000000 res->end 0 size fffffff980000001 Though this prevents the above corruption I wonder what was causing it in the first place and how we can address the problem. - Anshuman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel