From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99DE5C2D0A8 for ; Wed, 23 Sep 2020 11:04:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0487D20725 for ; Wed, 23 Sep 2020 11:04:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VboaLIl2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0487D20725 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=660nZdMDor6SGuRhCxizExY8Yc7WL0cRWeevrl9t8II=; b=VboaLIl25yBaT24r6QffBg462 7+z+V3Y3PNOkfnI6vZEwBy47pBUkYAH7qLIX9+d1W6WC+ymXxhca3qXz6DgEovrCPESXDNzvYaeoZ dmSM6QrDygEAjiLdoQRM/vwh5g8x7RwSMjGNMO5YEaenXaTIT+Qk2yrGBB2el6Qj2GCRUB+22BP85 FdDEUpyW9ZtWbPYvfmz1QIF3fJQBNoaBszYL1LQ4MEGGPl3+ds/ZrGY2Rr5FaLJdlR3w8B3xuAQob ZtA1yoxSR7PVNRqpAi1iwqipedexv86keMJv2ATYKKeonin4DoEPS4h95DbGc5V5Fzp86sQf6aFFz hJ4a5Blfg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kL2Xd-0003P0-Sn; Wed, 23 Sep 2020 11:02:29 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kL2Xb-0003Ob-Fm for linux-arm-kernel@lists.infradead.org; Wed, 23 Sep 2020 11:02:28 +0000 Received: from [95.90.166.74] (helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kL2Xa-0006ap-7G; Wed, 23 Sep 2020 13:02:26 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Artem Lapkin Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rk3399-khadas-edge add missed ir-receiver and ir_rx pinctl nodes Date: Wed, 23 Sep 2020 13:02:25 +0200 Message-ID: <7887815.vmt15hixIf@diego> In-Reply-To: <20200923101225.1513392-3-email2tema@gmail.com> References: <20200923101225.1513392-1-email2tema@gmail.com> <20200923101225.1513392-3-email2tema@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200923_070227_532414_9E16CADD X-CRM114-Status: GOOD ( 16.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, nick@khadas.com, jbx6244@gmail.com, art@khadas.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Artem, Am Mittwoch, 23. September 2020, 12:12:25 CEST schrieb Artem Lapkin: > From: Artem Lapkin > > add missed ir receivier to Khadas Edge board > Khadas Edge uses gpio-ir-receiver on RK_PB6 gpio Missing Signed-off-by > --- > .../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi > index 42ebbd6fa46..389ae43d869 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi > @@ -109,6 +109,14 @@ vsys_5v0: vsys-5v0 { > vin-supply = <&vsys>; > }; > > + ir-receiver { please sort alphabetically. Also more importantly, is this really part of all Khadas Edge board variants? [just making sure ;-) ] > + compatible = "gpio-ir-receiver"; > + gpios = <&gpio1 RK_PB6 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&ir_rx>; > + linux,rc-map-name = "rc-khadas"; > + }; > + > adc-keys { > compatible = "adc-keys"; > io-channels = <&saradc 1>; > @@ -682,6 +690,14 @@ &sdmmc { > status = "okay"; > }; > > +&pinctrl { there is already a "&pinctrl" node in the "rk3399-khadas-edge.dtsi" please don't add another one, and make sure things are somewhat sorted alphabetically ;-) . Thanks Heiko > + ir { > + ir_rx: ir-rx { > + rockchip,pins = <1 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > +}; > + > &sdhci { > bus-width = <8>; > mmc-hs400-1_8v; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel