From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5962DCD3420 for ; Tue, 3 Sep 2024 12:43:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KAmTuYuyXHduAW64UkV2JwUoEe69ueUNZdmvsuTuQfI=; b=22CVl8gNbHla+leejyZGH3Noo3 kSIbmrm/LRdggtiFGdAXwHU53mlQosjkkj9oJ8tDNjdR39cyMPphzy00hMafdDhEtYreHv7fwwTPM ZpBXYXTHxjAjUYG+njkojteqSSZELRwc/lCHlvapR8ZYtpvUn5cepY3DWUSEcPOqfVgEbZqmRorhh 4xBHWAemSpQUZhsyyYjqQwyJXEZDohIuUiyBsejiKqLD6DeS5DcmQIFnQOPiWHSGVpJHlMur1qhhK 2uvAkhX3CJSFkRusiHu4CDuxWK97U/IfAE2anOef3lu7cwyKveMkr6CrQOM9xhzPqlmVOTLmaDoE4 uUAiO/7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slSsB-00000000D1Z-02oA; Tue, 03 Sep 2024 12:43:03 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slSrE-00000000ClB-0VOw for linux-arm-kernel@lists.infradead.org; Tue, 03 Sep 2024 12:42:06 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 8776BFF803; Tue, 3 Sep 2024 12:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1725367319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KAmTuYuyXHduAW64UkV2JwUoEe69ueUNZdmvsuTuQfI=; b=JAI1fYGTKKL5l+SCb0pblQoraFWgfaGoP5aGV8o3omBndzVv3jbWnhkQg2MDx8pN2AE4nA H7TJooczOhsB4V2Gv6IXMu5Q+O3hN8jorwDWOYwp++FZyTKUpqbUBcW/mhFmq8LMmJNY7J oH0dLvK0dZbfxhVoHjmk7te/whHswi3b0coVuTZPVGVXVACLPUH6Rxgz61Ce/77fvlmJnN sQSCwGhJ5KmOmafWnCseLz4TXeg85i6zAMeIdqBhqNQfKN9ac7o+MeVyj1xa2y8cB8WESQ qZromrecx3UAesYiYeOqaaBiQSiHw9uik7IbAJ67GeXCc4hftSYMOTOPjIMm5w== Message-ID: <78be1cb2-a6c6-44e3-8974-06731dd055f2@bootlin.com> Date: Tue, 3 Sep 2024 14:41:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 0/7] Add suspend to ram support for PCIe on J7200 To: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Vignesh Raghavendra , Siddharth Vadapalli Cc: gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Francesco Dolcini References: <20240102-j7200-pcie-s2r-v7-0-a2f9156da6c3@bootlin.com> Content-Language: en-US From: Thomas Richard In-Reply-To: <20240102-j7200-pcie-s2r-v7-0-a2f9156da6c3@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: thomas.richard@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240903_054204_484066_83C50F3D X-CRM114-Status: GOOD ( 30.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/19/24 12:15, Thomas Richard wrote: > This adds suspend to ram support for the PCIe (RC mode) on J7200 platform. > > In this 7th iteration, the i2c and mux patches were moved to dedicated > series ([1] and [2]). > The patch for the gpio-pca953x driver was removed. It will be sent > separately for further testing and discussion. > > No merge conflict with 6.10-rc4. > > [1]: https://lore.kernel.org/all/20240613-i2c-omap-wakeup-controller-during-suspend-v1-0-aab001eb1ad1@bootlin.com/ > [2]: https://lore.kernel.org/all/20240613-mux-mmio-resume-support-v1-0-4525bf56024a@bootlin.com/ Hello !! This series has no remaining comment to address. Is there any chance to get this series merged ? Best Regards, Thomas > > Regards, > > Thomas > > Signed-off-by: Thomas Richard > --- > Changes in v7: > - all: series rebased on Linux 6.10-rc4. > - i2c: patches moved to a dedicated series. > - mux: patches moved to a dedicated series. > - gpio-pca953x: patch removed, will be sent separately. > - Link to v6: https://lore.kernel.org/r/20240102-j7200-pcie-s2r-v6-0-4656ef6e6d66@bootlin.com > > Changes in v6: > - i2c-omap: add a patch to remove __maybe_unused attribute of > omap_i2c_runtime_suspend() and omap_i2c_runtime_resume() > - i2c-omap: fix compile issue if CONFIG_PM_SLEEP is not set > - Link to v5: https://lore.kernel.org/r/20240102-j7200-pcie-s2r-v5-0-4b8c46711ded@bootlin.com > > Changes in v5: > - all: series rebased on Linux 6.9-rc1 > - pinctrl-single: patch removed (already applied to the pinctrl tree) > - phy: patches moved to a dedicated series. > - pci: add T_PERST_CLK_US macro. > - pci-j721e: update the comments about T_PERST_CLK_US. > - Link to v4: https://lore.kernel.org/r/20240102-j7200-pcie-s2r-v4-0-6f1f53390c85@bootlin.com > > Changes in v4: > - all: use SoB/Co-developed-by for patches initially developed by Théo > Lebrun. > - pinctrl-single: squash the two commits. > - i2c-omap: fix line lenghts of the comment in omap_i2c_suspend(). > - mux: mux_chip_resume() return 0 or at the first error. > - phy-j721e-wiz: clean code around dev_err_probe(). > - phy-j721e-wiz: use REF_CLK_100MHZ macros. > - pci: fix subject line for all PCI patches. > - pci-cadence: use fsleep() instead of usleep_range(). > - pci-cadence: remove cdns_torrent_clk_cleanup() call in > cdns_torrent_phy_resume_noirq(). > - pci-j721e: add a patch to use dev_err_probe() instead of dev_err() in the probe(). > - pci-j721e: fix unordered header files. > - pci-j721e: remove some log spammers. > - pci-j721e: add a missing clock disable in j721e_pcie_resume_noirq(). > - pci-j721e: simplify the patch "Add reset GPIO to struct j721e_pcie" > - Link to v3: https://lore.kernel.org/r/20240102-j7200-pcie-s2r-v3-0-5c2e4a3fac1f@bootlin.com > > Changes in v3: > - pinctrl-single: split patch in two parts, a first patch to remove the > dead code, a second to move suspend()/resume() callbacks to noirq. > - i2c-omap: add a comments above the suspend_noirq() callback. > - mux: now mux_chip_resume() try to restores all muxes, then return 0 if > all is ok or the first failure. > - mmio: fix commit message. > - phy-j721e-wiz: add a patch to use dev_err_probe() instead of dev_err() in > the wiz_clock_init() function. > - phy-j721e-wiz: remove probe boolean for the wiz_clock_init(), rename the > function to wiz_clock_probe(), extract hardware configuration part in a > new function wiz_clock_init(). > - phy-cadence-torrent: use dev_err_probe() and fix commit messages > - pcie-cadence-host: remove probe boolean for the cdns_pcie_host_setup() > function and extract the link setup part in a new function > cdns_pcie_host_link_setup(). > - pcie-cadence-host: make cdns_pcie_host_init() global. > - pci-j721e: use the cdns_pcie_host_link_setup() cdns_pcie_host_init() > functions in the resume_noirq() callback. > - Link to v2: https://lore.kernel.org/r/20240102-j7200-pcie-s2r-v2-0-8e4f7d228ec2@bootlin.com > > Changes in v2: > - all: fix commits messages. > - all: use DEFINE_NOIRQ_DEV_PM_OPS and pm_sleep_ptr macros. > - all: remove useless #ifdef CONFIG_PM. > - pinctrl-single: drop dead code > - mux: add mux_chip_resume() function in mux core. > - mmio: resume sequence is now a call to mux_chip_resume(). > - phy-cadence-torrent: fix typo in resume sequence (reset_control_assert() > instead of reset_control_put()). > - phy-cadence-torrent: use PHY instead of phy. > - pci-j721e: do not shadow cdns_pcie_host_setup return code in resume > sequence. > - pci-j721e: drop dead code. > - Link to v1: https://lore.kernel.org/r/20240102-j7200-pcie-s2r-v1-0-84e55da52400@bootlin.com > > --- > Thomas Richard (5): > PCI: cadence: Extract link setup sequence from cdns_pcie_host_setup() > PCI: cadence: Set cdns_pcie_host_init() global > PCI: j721e: Use dev_err_probe() in the probe() function > PCI: Add T_PERST_CLK_US macro > PCI: j721e: Use T_PERST_CLK_US macro > > Théo Lebrun (2): > PCI: j721e: Add reset GPIO to struct j721e_pcie > PCI: j721e: Add suspend and resume support > > drivers/pci/controller/cadence/pci-j721e.c | 121 ++++++++++++++++++--- > drivers/pci/controller/cadence/pcie-cadence-host.c | 44 +++++--- > drivers/pci/controller/cadence/pcie-cadence.h | 12 ++ > drivers/pci/pci.h | 3 + > 4 files changed, 146 insertions(+), 34 deletions(-) > --- > base-commit: 7510725e693fb5e4b4cd17086cc5a49a7a065b9c > change-id: 20240102-j7200-pcie-s2r-ecb1a979e357 > > Best regards,