public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected for ARM64
Date: Fri, 16 Oct 2015 21:25:57 +0200	[thread overview]
Message-ID: <7901695.AWo8cP6Hz1@wuerfel> (raw)
In-Reply-To: <20151016165445.GG108923@google.com>

On Friday 16 October 2015 09:54:45 Brian Norris wrote:
> > MTD_NAND_BRCMNAND uses the generic nand functions, but is currently allowed
> > to be built without CONFIG_MTD_NAND, which results in a link error:
> > 
> > drivers/built-in.o: In function `brcmnand_remove':
> > coresight-replicator.c:(.text+0x17ae6c): undefined reference to `nand_release'
> > drivers/built-in.o: In function `brcmnand_probe':
> > coresight-replicator.c:(.text+0x17d4b4): undefined reference to `nand_scan_ident'
> > coresight-replicator.c:(.text+0x17d948): undefined reference to `nand_scan_tail'
> 
> How did you get this? MTD_NAND_BRCMNAND is surrounded in the
> 'if MTD_NAND' block, which implicitly generates a MTD_NAND dependency.
> And I can confirm that in menuconfig, I see this when I disable MTD_NAND
> and search for BRCMNAND:
> 
>    Symbol: MTD_NAND_BRCMNAND [=n]
>    Type  : tristate
>    Prompt: Broadcom STB NAND controller
>      Location:
>        -> Device Drivers
>          -> Memory Technology Device (MTD) support (MTD [=y])
>    (1)     -> NAND Device Support (MTD_NAND [=n])
>      Defined at drivers/mtd/nand/Kconfig:394
>      Depends on: MTD [=y] && MTD_NAND [=n] && (ARM [=y] || ARM64 || MIPS)

Sorry, can't reproduce it any more. My patch is dated June 4, so it was
probably broken then but got fixed since. I normally try to verify that
the patches are still needed before I send them, but this time I only
saw the current discussion and remembered something vague about it
and sent what I had in my backlog of the randconfig-fixes series.

Sorry for the confusion.

	Arnd

  reply	other threads:[~2015-10-16 19:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16  9:08 [PATCH v2 0/4] NAND support for Broadcom NS2 SoC Anup Patel
2015-10-16  9:08 ` [PATCH v2 1/4] mtd: brcmnand: Fix pointer type-cast in brcmnand_write() Anup Patel
2015-10-16 15:36   ` Ray Jui
2015-10-16 16:40     ` Brian Norris
2015-10-17  2:52     ` Anup Patel
2015-10-16  9:08 ` [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected for ARM64 Anup Patel
2015-10-16 15:36   ` Ray Jui
2015-10-16 16:41     ` Brian Norris
2015-10-16 16:24   ` Arnd Bergmann
2015-10-16 16:54     ` Brian Norris
2015-10-16 19:25       ` Arnd Bergmann [this message]
2015-10-16 19:28         ` Florian Fainelli
2015-10-16 19:39           ` Arnd Bergmann
2015-10-16  9:08 ` [PATCH v2 3/4] mtd: brcmnand: Force 8bit mode before doing nand_scan_ident() Anup Patel
2015-10-16  9:08 ` [PATCH v2 4/4] arm64: dts: Add BRCM IPROC NAND DT node for NS2 Anup Patel
2015-10-20  9:05   ` Sudeep Holla
2015-10-20  9:25     ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7901695.AWo8cP6Hz1@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox