From: Matti Vaittinen <mazziesaccount@gmail.com>
To: kernel test robot <lkp@intel.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
kbuild-all@lists.01.org,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Cosmin Tanislav" <cosmin.tanislav@analog.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Miaoqian Lin" <linmq006@gmail.com>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
"Eugen Hristev" <eugen.hristev@microchip.com>,
"Alexandru Ardelean" <alexandru.ardelean@analog.com>,
"Mihail Chindris" <mihail.chindris@analog.com>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Jonathan Cameron" <jic23@kernel.org>
Subject: Re: [PATCH 2/2] iio: Fix unsafe buffer attributes
Date: Fri, 30 Sep 2022 20:30:03 +0300 [thread overview]
Message-ID: <7921d7e8-09c8-dd68-8c0d-aef33e4ecbd1@gmail.com> (raw)
In-Reply-To: <202209302235.hHrSjkSb-lkp@intel.com>
Hi dee Ho peeps,
On 9/30/22 17:17, kernel test robot wrote:
> Hi Matti,
>
> I love your patch! Yet something to improve:
Ouch.
I overlooked the fact that the buffer was also used by iio-dmaengine
(which I had not configured to be compiled). Also the
cros_ec_sensors_core.c evaded my grep.
Changing these to use iio_dev_attrs as well seems trivial - but I am
afraid there may be other culprits if the pointers to those buffer
attributes are memcpy()-ed somewhere else as well... (The attribute wrap
function did this).
I will include cros_ec_sensors_core.c and industrialio-dmaengine.c
changes and re-spin the series - but I guess I need to add [RFT] here...
Best regards
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-09-30 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 10:54 [PATCH 1/2] iio: Add IIO_STATIC_CONST_DEVICE_ATTR Matti Vaittinen
2022-09-30 10:54 ` [PATCH 2/2] iio: Fix unsafe buffer attributes Matti Vaittinen
[not found] ` <202209302235.hHrSjkSb-lkp@intel.com>
2022-09-30 17:30 ` Matti Vaittinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7921d7e8-09c8-dd68-8c0d-aef33e4ecbd1@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandru.ardelean@analog.com \
--cc=claudiu.beznea@microchip.com \
--cc=cosmin.tanislav@analog.com \
--cc=eugen.hristev@microchip.com \
--cc=jic23@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=lars@metafoo.de \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mihail.chindris@analog.com \
--cc=miquel.raynal@bootlin.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).