From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E4EDC433F5 for ; Fri, 30 Sep 2022 17:31:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:Subject:From:References:To:MIME-Version: Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ItsC8YqdEJrheCaa1204f6qMSIcETr2gScV/0dVxhg0=; b=AqL+FAR6y8pM3d0jkOd9YcqiAR RYOWKYSqqxPmGIJfBnr8EuuOEOohaMXsYAW4vOjm6Z1HIJz0wstxl940ZX1RBOtZR9SiGON/vvXnq ZXyn7eDJXhYqKyNLa6taHDngbZIssRyA2xftUFPPsTYJKfnJOCUl7D+jhtUhxljP8Mexg3VQVUG/z 9HG6xFswk8hh3GG5lC85FVEUxFOuwykBmIJTyAv+c3P4E42vLOVQyJZuD0wBEi/DnebSq9UoViAb/ ZCzWJdbzz5b/jpuY9AcFiJ+1E8fM+BxgYBuc7Poml1UvoRQWhqEBv0fUqtUTxOEA/u3/iwzlYWmkc iUc/rt5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeJq6-00Ansn-UX; Fri, 30 Sep 2022 17:30:19 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeJq3-00AnrM-P4 for linux-arm-kernel@lists.infradead.org; Fri, 30 Sep 2022 17:30:17 +0000 Received: by mail-lj1-x22e.google.com with SMTP id q17so5502954lji.11 for ; Fri, 30 Sep 2022 10:30:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:content-language :references:cc:to:user-agent:mime-version:date:message-id:from:to:cc :subject:date; bh=y3ldtOTPE4r5odoH0+tTaflEwixWUb/0F7j9EagJulU=; b=R9XqN/5CgHjv85wlJMJb1mshI6f6474mxDwiMmNEUo2an4lbvQ0zUTEHchwfVW3O38 SfUGECAfFzMeiPePod6xKEF1u8NzrbCSUZI0uA816Vsr+264sfbGxmuacxe7KGLVPgmH mYoiO0mzWFna5SVOOiQHFBu/8tN4Byos61jg9D0eiITmecZ9SZhGzQ/oeihf6UpDhIR6 ooeN/RgP2s6AjN73Qs891g28DFyRgo5Zm1qhVJmt3WYW679SNReFtEGqdVeUE9UVFLQW pvAMtJTt2yXYAezLeHPuU0N1PxWRE7gKJ2hldntTRBoj1RS6zlajfHwK+cU1y84Ye7BF tISQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:content-language :references:cc:to:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=y3ldtOTPE4r5odoH0+tTaflEwixWUb/0F7j9EagJulU=; b=subnMpDD5Ok0GJa/a6hncGMvkArvGUfnADF5aKHi+PADQSMSZ6EzwAZokZdNpIlv30 K/anihs6koyEYm/ipB81JSgM9lPXhYuilQAWIo1rZQQV5Uf/570DPl0P7W89O1UwYVU0 hgmyvSo0hJXBDYMML7J6LWf/0H05XRG581zfn6uPfeUBAseP/lG42CLY3bgd4hv80IdY 4HP5sgJp3TWkYvGhI6X6jBR8FaqwEBZSq2XA7EDxQ8K8INmGtOv3Mmabwy2OXTsDFAcG xrMJJmDGpQwlGhxhA0ifKstIoaV0DURyW8b0nz5mGneel4334jhTZCzRLDE/WXwdpEY8 LrrQ== X-Gm-Message-State: ACrzQf0SX6cr85ed0cTF8T/PTRu+gAHVPw+oFPjwRjKCWFt5JTjenBcw xrq5sOqK7G4J+aP0UVM6MDw= X-Google-Smtp-Source: AMsMyM77+DIeooxXytl4jtyCbXyZIpZrVPy8CSkX0rd5YOYHquHrAwTFR7RRc44FEuPP2DabYn3kPw== X-Received: by 2002:a2e:7e0a:0:b0:26c:5aec:f849 with SMTP id z10-20020a2e7e0a000000b0026c5aecf849mr3429140ljc.296.1664559013131; Fri, 30 Sep 2022 10:30:13 -0700 (PDT) Received: from ?IPV6:2001:14ba:16f3:4a00::1? (dc75zzyyyyyyyyyyyyyyt-3.rev.dnainternet.fi. [2001:14ba:16f3:4a00::1]) by smtp.gmail.com with ESMTPSA id w8-20020a05651204c800b004a03fd4476esm347761lfq.287.2022.09.30.10.30.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 10:30:12 -0700 (PDT) Message-ID: <7921d7e8-09c8-dd68-8c0d-aef33e4ecbd1@gmail.com> Date: Fri, 30 Sep 2022 20:30:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 To: kernel test robot , Matti Vaittinen References: <876c338d0ae33a474a3ff95d4350d45bd4779066.1664534676.git.mazziesaccount@gmail.com> <202209302235.hHrSjkSb-lkp@intel.com> Content-Language: en-US From: Matti Vaittinen Subject: Re: [PATCH 2/2] iio: Fix unsafe buffer attributes In-Reply-To: <202209302235.hHrSjkSb-lkp@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220930_103015_848030_13CDFAED X-CRM114-Status: GOOD ( 10.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Lars-Peter Clausen , kbuild-all@lists.01.org, Michael Hennerich , Cosmin Tanislav , Miquel Raynal , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Miaoqian Lin , Srinivas Pandruvada , Eugen Hristev , Alexandru Ardelean , Mihail Chindris , Claudiu Beznea , Jonathan Cameron Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi dee Ho peeps, On 9/30/22 17:17, kernel test robot wrote: > Hi Matti, > > I love your patch! Yet something to improve: Ouch. I overlooked the fact that the buffer was also used by iio-dmaengine (which I had not configured to be compiled). Also the cros_ec_sensors_core.c evaded my grep. Changing these to use iio_dev_attrs as well seems trivial - but I am afraid there may be other culprits if the pointers to those buffer attributes are memcpy()-ed somewhere else as well... (The attribute wrap function did this). I will include cros_ec_sensors_core.c and industrialio-dmaengine.c changes and re-spin the series - but I guess I need to add [RFT] here... Best regards -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel