From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3924CEBF7C for ; Fri, 27 Sep 2024 07:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V+D9+o7G/ymDOGKu4SCSQIvGmuHtAwpUMqlXkM3YB6M=; b=vOAq1atqbZpKyoQtjWKSYpcWWh ZQxFsCDSxyLBla6CeiD+s2gWuqgpASj/QAJ4RHyXqNYsmYEw28bOWrDHRPvRdvBf15ReB4tNSRm0e ZKDaBY+AYghWgMj3CUOevjX118PT9vU/vsH5mlPrIFXKKlGRKu3SnPmonlyRrk9ucslWskv2bPNoy UrggDF65b6C8pd6dvycGfc5waLR92INwU22m6AIdhffePp0HxCKsg3xQn3q8+HShsowJoiV99mj05 ph9nDzjxY6ciZFU0D+GGUeVkCet4POBuIGyRZ+knlvk6jImhb4WeOdw9Go2F+9a9pBuFjBvE/CdA6 XD/56kUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1su57B-0000000AJ30-0h4V; Fri, 27 Sep 2024 07:10:09 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1su4yq-0000000AHYf-39Us; Fri, 27 Sep 2024 07:01:34 +0000 Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-72703dd2b86so166146a12.1; Fri, 27 Sep 2024 00:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727420491; x=1728025291; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=V+D9+o7G/ymDOGKu4SCSQIvGmuHtAwpUMqlXkM3YB6M=; b=DPTuLBbpvhsoPplLb3OCzKV1xnEyDZmh8l6gkfmwLU3hGoPRsJVFqsv2scoLkTuGBy A3ow08xt7Dots+T325iVpfe0DRw2iToQRcTNwKV6gn4li0E3sbwn8d8ZotutALlOUQUZ fw9CxkvYwdmtdJ2NGNVZyHMeKb5317pk5usNiCU7ZtBbe33yboXDO24Pi5toZiGFurTf O4E4U6RFdY/NLIy4EHT8tf4+StDoQHUZ9/Vga7eR4K25/lUoKV8dsO7BrhRL7Funekfd XQOMExJL781jQ3o9Mzj1SRUfji2EDQEFThxRR0ktDLU8BdbUI9/YjFbbQwKgX1FPCW1b 0hgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727420491; x=1728025291; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V+D9+o7G/ymDOGKu4SCSQIvGmuHtAwpUMqlXkM3YB6M=; b=IPiEBZtAWrWdSGVe+GFXI0W6F1cJnWkeOKpfpfH3PiR18YqOFZNGyONkU4R4nlK2C/ 4vtDD7G5FhpHUGrRQKIN0zGv4EsAs8OfLXFwyFbnXUG2h44tGKlx8oyHSSaZ/T0g7n+6 eOJWpTtg+eBseQ0DiQtt3n8jyOhGqlWCZ72sGNvJuwo/87f/coLoZ6pls9+etGwn94Jg 4cvg6YfW1zAJH/CEJfl3CQNW4WoVfaOyzxxhs9wLCdYz8zD6M3X4+ruuLddNBZWNnZfE 9Blmeg9ll3m3ZDc/Lt1ZmSk2q/vm5t/3rjDMoL1GK5t6PNdBlp+/egfLBJmaX1XNHpZE kkaw== X-Forwarded-Encrypted: i=1; AJvYcCU0CX1YFFuoKWstJJM1o3GJrpbGNkwzJUa86U5JO6YnrrrqbU2wRVq/hnWN1UOUPMShoHK5trRJaXp2OqSD4TVl@lists.infradead.org, AJvYcCVPKrVZ4HkjsblXX4W+q8fM7FkWzsruAgRZ0VQkfrUJ3pfXmN+0y55K8l1Ov7IOzCDm+F8NnZ6StCIUpNXyfqI=@lists.infradead.org X-Gm-Message-State: AOJu0YxnL1v/RvlXCO56Wt61ouDtiUlBTbCOUVOanhbIEAxEHdooXHwA ZbHDcP3ah9Ju2EQF2iTTD/qc9tbR9QPw5wX1oUwv5mdgAG9mIbf1 X-Google-Smtp-Source: AGHT+IGkAxYW8GNPQCEuaiab18J3qC/gbPLDVKzyTDXDfndAX4vGC/veXCZ5MM/mKbk8GhIbnrPXGA== X-Received: by 2002:a05:6a00:3d0d:b0:717:9406:c1be with SMTP id d2e1a72fcca58-71b25f0b1efmr1655641b3a.1.1727420491214; Fri, 27 Sep 2024 00:01:31 -0700 (PDT) Received: from [192.168.60.56] ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264b7decsm939078b3a.47.2024.09.27.00.01.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Sep 2024 00:01:30 -0700 (PDT) Message-ID: <7944f4dd-96f0-40df-8c91-523409e3cb20@gmail.com> Date: Fri, 27 Sep 2024 15:01:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3576 To: Krzysztof Kozlowski , vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, william.wu@rock-chips.com, tim.chen@rock-chips.com, frank.wang@rock-chips.com References: <20240926103223.29538-1-frawang.cn@gmail.com> Content-Language: en-US From: Frank Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240927_000132_812330_8E6957A4 X-CRM114-Status: UNSURE ( 9.09 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On 2024/9/26 22:19, Krzysztof Kozlowski wrote: > On 26/09/2024 12:32, Frank Wang wrote: >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - rockchip,rk3576-usb2phy >> + then: >> + properties: >> + clocks: >> + minItems: 3 >> + maxItems: 3 > Read one more time the example I gave you. Top-level constraints are > saying max one clock. > > Best regards, > Krzysztof > Sorry for overlooking this, I will set both "clocks" and "clock-names" to true, and add the else case below the above codes for the "old" SoCs. Just like the below. -  clocks: -    maxItems: 1 +  clocks: true -  clock-names: -    const: phyclk +  clock-names: true    assigned-clocks:      description: @@ -189,6 +187,13 @@ allOf:              - const: phyclk              - const: aclk              - const: aclk_slv +    else: +      properties: +        clocks: +          maxItems: 1 +        clock-names: +          const: phyclk + Best regards, Frank