From: Michal Simek <michal.simek@xilinx.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
<linux-arm-kernel@lists.infradead.org>
Cc: Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH] arm64: dts: zynqmp: Add power domain for the DisplayPort DMA controller
Date: Mon, 8 Mar 2021 17:25:42 +0100 [thread overview]
Message-ID: <794fcdc5-ebe1-703f-9db0-65313ef59df2@xilinx.com> (raw)
In-Reply-To: <20210306230915.14979-1-laurent.pinchart@ideasonboard.com>
On 3/7/21 12:09 AM, Laurent Pinchart wrote:
> The DisplayPort DMA controller (DPDMA) is located in the same power
> domain as the DisplayPort Subsystem (DPSUB). Specify the power domain in
> the device tree.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> I'm actually not entirely sure about the truthfulness of the commit
> message, as I haven't been able to located this information in the
> reference manual. Nonetheless, without this patch, I get a clock enable
> failure when starting the display:
>
> [ 70.517104] zynqmp_pll_enable() clock enable failed for vpll_int, ret = -22
> [ 70.527552] zynqmp-dpsub fd4a0000.display: failed to enable a pixel clock
>
> I'm thus quite confident the patch is correct. If anyone has more
> information and would like to reword the commit message, please feel
> free to do so.
>
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index c113c76f360d..dc5c3a09c77e 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -749,6 +749,7 @@ zynqmp_dpdma: dma-controller@fd4c0000 {
> interrupts = <0 122 4>;
> interrupt-parent = <&gic>;
> clock-names = "axi_clk";
> + power-domains = <&zynqmp_firmware PD_DP>;
> #dma-cells = <1>;
> };
>
>
Applied.
M
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-03-08 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 23:09 [PATCH] arm64: dts: zynqmp: Add power domain for the DisplayPort DMA controller Laurent Pinchart
2021-03-08 10:08 ` Michal Simek
2021-03-08 10:58 ` Rajan Vaja
2021-03-08 11:00 ` Michal Simek
2021-03-08 12:50 ` Rajan Vaja
2021-03-08 16:25 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=794fcdc5-ebe1-703f-9db0-65313ef59df2@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).