From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83CCCC7EE2E for ; Thu, 8 Jun 2023 06:38:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CKTYcxVdcvB+2kVH1w2zuvkZeUG7D7qn9zIctFWGu8g=; b=FD8PLkU5fas3T+ UwPJdMHOrdL5RSSSsyswTuNMKHHkCoXxE9Iijjhh3cawuySjD4ZRgdGAoiV3haKC84QInjUmR73Gt GooNEmi2NARqGceIRCaXpjz/VO21YmMQo849m+w+CujIdhTcUXVGRb21U4rpm/fHoEmqLIiFCNR9v Stn29vH+WUWCSFqFc85fTrFocFN6VtR1uL9DHdz/qz42wVrsrKzwS2WKXB1SQ88nBo3QDjCs8E42q P4WqfcgUQoy2D9U4T5/aP38GCwAswg66ty0ryB++tYE+dM8JcefbK0AYWgLwxqTvtPDHcfJIFyyJp 2XOTjFY4bZG2IuWWZ1Wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q79Hc-008Gt4-1J; Thu, 08 Jun 2023 06:38:08 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q79Ha-008Grs-0I for linux-arm-kernel@lists.infradead.org; Thu, 08 Jun 2023 06:38:07 +0000 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-51480d3e161so309246a12.3 for ; Wed, 07 Jun 2023 23:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686206281; x=1688798281; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lqo0A7BM5THz83RAtHMEkVHjNz7WCnOgKYrgDzsaaU4=; b=CUbo1fahuMwU8hQpPyLHBQTQNthgS0+azjXEB5AuMpivBaAN7sKBcqOMHCbudzENfS E2sZnGqcbYx2nNJ0yBKlteFKjUuDqif5VYX9YDV94/AGcAdw+KtmKakYxEmVd724gm4D cgg6z7n3Hn31+jor2LbZSAW6BjWkrJIirz5GlLUhGi1HX7d8qocpZ6PC2QHc5U8lL5Sm Mixy66cV0bGiUy/Q5e5jVgtKz1exAoXZFKX4pvxrlUOrC+w+rqPSUHlRk3q2Y9UaSL6/ /KuNUsRD5M0DtbjpW3yM9eCYmIcUSlviUeNpmY1YHxxcAc+4XrL/W+Y6dMQhcCAeYlde 5I2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686206281; x=1688798281; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lqo0A7BM5THz83RAtHMEkVHjNz7WCnOgKYrgDzsaaU4=; b=l1hc+BpvOX5pDnFP+XqJE9Dm5lnlZDWorCt94W6c9coTTjTqiuIU02UloZ8xx+LKuv Ce/fOMHvI4bbJLFligX8IH+iVYKlJnI8vyNVJ8j7N1PQ53Y3kHRX3DfDncE9wJ7uogJo Y3hzA0eir1+x2MWmYBkPbT+wuQypmkqO/mxUyl8qshSnhEWT7mkG90DPlR7X6OOcuhi6 Q6yz/zdjABnT0TlGmH/JDyHsay2fqPMbe+ODALSNrdI7NISp+d6G9oPndJzxC8u6rGYb ec11aPUt2ClvfQ3LfX8Q4YV0rrfmTptBt9CvlZMQAlh8g3z2fnE533Tse6r1eeb/El/u 0+hg== X-Gm-Message-State: AC+VfDyay0Vl97iRFwf4MtmuP/5gv2fyILpYH3yNomA8iB3tkWgJGAFO 6h4BNIlfOivBY965QYiOtW6pcQ== X-Google-Smtp-Source: ACHHUZ4KhhXuTCYSDPgoRLBB4u32f/WMlazF4shqwwkZ3icYzTu7KI3MJObyFYaJY0xBRdj6ON+xew== X-Received: by 2002:aa7:cc98:0:b0:50d:88f3:2e30 with SMTP id p24-20020aa7cc98000000b0050d88f32e30mr7084851edt.13.1686206281341; Wed, 07 Jun 2023 23:38:01 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id n27-20020a056402515b00b00502689a06b2sm168728edd.91.2023.06.07.23.37.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 23:38:00 -0700 (PDT) Message-ID: <797c61d2-b8f1-e80e-24b9-4c7a7d266080@linaro.org> Date: Thu, 8 Jun 2023 08:37:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [v6 0/4] Support pwm/tach driver for aspeed ast26xx Content-Language: en-US To: Billy Tsai , jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au, andrew@aj.id.au, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, corbet@lwn.net, p.zabel@pengutronix.de, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-doc@vger.kernel.org, patrick@stwcx.xyz References: <20230608021839.12769-1-billy_tsai@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: <20230608021839.12769-1-billy_tsai@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_233806_142920_A5665CB4 X-CRM114-Status: GOOD ( 11.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/06/2023 04:18, Billy Tsai wrote: > Unlike the old design that the register setting of the TACH should based > on the configure of the PWM. In ast26xx, the dependency between pwm and > tach controller is eliminated and becomes a separate hardware block. One > is used to provide pwm output and another is used to monitor the frequency > of the input. Therefore, this patch serials implements them by writing the > two driver "pwm-aspeed-ast2600.c" and "tach-aspeed-ast2600.c". The former > is following the pwm subsystem which can apply the existed driver to > controller the fan(pwm-fan.c), beeper(pwm-beeper.c) and so on. The latter > is following the sysfs interface of hwmon to creat the node for fan > monitor. You like to ignore my comments... How did you implement them? Go one by one - answer to v4 emails. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel